<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Hi Marcel,</p>
<p><br>
</p>
<p><span>#refreshWindowColor depends on #paneColor which in turn depends on the model of the SystemWindow. If we call #refereshWindowColor directly in SystemWindow >> #initialize, the pane color will not match to the model at the end of #<span>buildPluggableWindow:.
Is this what we want?</span></span><br>
</p>
<p><span><span><br>
</span></span></p>
<p><span><span>Best,</span></span></p>
<p><span><span>Christoph</span></span></p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="_rp_T4" id="Item.MessagePartBody">
<div class="_rp_U4 ms-font-weight-regular ms-font-color-neutralDark rpHighlightAllClass rpHighlightBodyClass" id="Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont">
<div><font size="3" color="black"><span style="font-size:12pt"><a href="http://www.hpi.de/" target="_blank" rel="noopener noreferrer" id="LPNoLP"><font size="2"><span id="LPlnk909538"><font color="#757B80"></font></span></font></a></span></font></div>
</font></div>
</div>
</font></div>
</div>
</div>
</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Donnerstag, 17. September 2020 16:19:39<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: ToolBuilder-Morphic-ct.264.mcz</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
So, let's fix it in SystemWindow instead, not here. :-)
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 17.09.2020 14:17:33 schrieb commits@source.squeak.org <commits@source.squeak.org>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">A new version of ToolBuilder-Morphic was added to project The Inbox:<br>
http://source.squeak.org/inbox/ToolBuilder-Morphic-ct.264.mcz<br>
<br>
==================== Summary ====================<br>
<br>
Name: ToolBuilder-Morphic-ct.264<br>
Author: ct<br>
Time: 17 September 2020, 2:17:24.709813 pm<br>
UUID: f0cb613b-9652-a146-9d77-016577d87700<br>
Ancestors: ToolBuilder-Morphic-mt.263<br>
<br>
Initially refresh window color when building a window.<br>
<br>
While this also happens later #openInWorld, the call is missing is something else is done with the window instead, e.g. #openInWindow or #imageForm.<br>
<br>
=============== Diff against ToolBuilder-Morphic-mt.263 ===============<br>
<br>
Item was changed:<br>
----- Method: MorphicToolBuilder>>buildPluggableWindow: (in category 'widgets required') -----<br>
buildPluggableWindow: aSpec<br>
| widget |<br>
<br>
aSpec layout == #proportional ifFalse:[<br>
"This needs to be implemented - probably by adding a single pane and then the rest"<br>
^self error: 'Not implemented'.<br>
].<br>
<br>
widget := (self windowClassFor: aSpec) new.<br>
self register: widget id: aSpec name.<br>
<br>
widget model: aSpec model.<br>
<br>
"Set child dependent layout properties."<br>
widget wantsPaneSplitters: (aSpec wantsResizeHandles ifNil: [true]).<br>
self setLayoutHintsFor: widget spec: aSpec.<br>
widget layoutInset: (aSpec padding ifNil: [ProportionalSplitterMorph gripThickness]).<br>
widget cellGap: (aSpec spacing ifNil: [ProportionalSplitterMorph gripThickness]).<br>
<br>
"Now create the children."<br>
panes := OrderedCollection new.<br>
aSpec children isSymbol<br>
ifTrue: [<br>
widget getChildrenSelector: aSpec children.<br>
widget update: aSpec children]<br>
ifFalse: [<br>
self buildAll: aSpec children in: widget].<br>
widget setUpdatablePanesFrom: panes.<br>
<br>
aSpec label ifNotNil: [:label|<br>
label isSymbol <br>
ifTrue:[widget getLabelSelector: label]<br>
ifFalse:[widget setLabel: label]].<br>
<br>
aSpec multiWindowStyle notNil ifTrue:<br>
[widget savedMultiWindowState: (SavedMultiWindowState on: aSpec model)].<br>
<br>
widget closeWindowSelector: aSpec closeAction.<br>
self buildHelpFor: widget spec: aSpec. <br>
<br>
widget bounds: (RealEstateAgent <br>
initialFrameFor: widget <br>
initialExtent: (aSpec extent ifNil:[widget initialExtent])<br>
world: self currentWorld).<br>
<br>
+ widget refreshWindowColor.<br>
+ <br>
^ widget!<br>
<br>
<br>
</div>
</blockquote>
</div>
</div>
</body>
</html>