<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Hi Eliot,</p>
<p><br>
</p>
<p>very nice finding once again! I #timeProfile'd the menu button action and as I expected, the most expensive operation is the shout styling by the new inspectors, including the decompilation of every method:</p>
<p><br>
</p>
<p><img size="399308" contenttype="image/png" id="img727041" style="max-width: 99.9%; user-select: none;" contextid="img713724" tabindex="0" src="cid:1fdde244-d227-4d8d-9bfb-6b7176b7bc6f"><br>
</p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="_rp_T4" id="Item.MessagePartBody">
<div class="_rp_U4 ms-font-weight-regular ms-font-color-neutralDark rpHighlightAllClass rpHighlightBodyClass" id="Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont">
<div><font size="3" color="black"><span style="font-size:12pt"><a href="http://www.hpi.de/" target="_blank" rel="noopener noreferrer" id="LPNoLP"><font size="2"><span id="LPlnk909538"><font color="#757B80"></font></span></font></a></span></font></div>
</font></div>
</div>
</font></div>
</div>
</div>
</div>
<div class="_rp_T4" id="Item.MessagePartBody"><br>
</div>
<div class="_rp_T4" id="Item.MessagePartBody">First, when loading <span>ShoutCore-ct.78 (Inbox), the speed doubles (but probably that's rather a problem with my sources file, see the thread about this commit).</span></div>
<div class="_rp_T4" id="Item.MessagePartBody"><span><br>
</span></div>
<div class="_rp_T4" id="Item.MessagePartBody">Second, we do not redraw the world while running to the selection, so we do not need to update the inspectors at all. I think we could split up #doStep into some #basicDoStep (which would perform the actual stepping
logic) + some #updateContextDuring: (which would update the stack list and the inspectors), then we would need to trigger the updates only once from #runToSelection:.</div>
<div class="_rp_T4" id="Item.MessagePartBody">As an alternative, we could make this method a bit more complex but responsive by applying the same updating logic from #runUntil.</div>
<div class="_rp_T4" id="Item.MessagePartBody"><br>
</div>
<div class="_rp_T4" id="Item.MessagePartBody">What do you think? :-)</div>
<div class="_rp_T4" id="Item.MessagePartBody"><br>
</div>
<div class="_rp_T4" id="Item.MessagePartBody">Best,</div>
<div class="_rp_T4" id="Item.MessagePartBody">Christoph</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Eliot Miranda <eliot.miranda@gmail.com><br>
<b>Gesendet:</b> Samstag, 19. September 2020 20:17:12<br>
<b>An:</b> The general-purpose Squeak developers list; Taeumel, Marcel<br>
<b>Betreff:</b> [squeak-dev] Can we make computing the local variables in the debugger lazy?</font>
<div> </div>
</div>
<div>
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div class="gmail_default"><font face="arial, sans-serif" size="4">Hi Marcel,</font></div>
<div class="gmail_default"><font face="arial, sans-serif" size="4"><br>
</font></div>
<div class="gmail_default"><font face="arial, sans-serif" size="4"> can we try and reduce the frequency at which we compute the variables in the context inspector in the debugger? It is a noticeable performance hit. I really like the user interface, but
the performance hit is making debugging difficult.</font></div>
<div class="gmail_default"><font face="arial, sans-serif" size="4"><br>
</font></div>
<div class="gmail_default"><font face="arial, sans-serif" size="4">As an example use this:</font></div>
<div class="gmail_default"><font face="arial, sans-serif" size="4"><br>
</font></div>
<div class="gmail_default">
<div class="gmail_default"><font size="4" face="times new roman, serif">| samples sineTable sound |</font></div>
<div class="gmail_default"><font size="4" face="times new roman, serif">"1 second of A below middle C (220Hz). 16000 / 220 is 72.72 recurring"</font></div>
<div class="gmail_default"><font size="4" face="times new roman, serif">sineTable := SoundPlayer sineTable: 73.</font></div>
<div class="gmail_default"><font size="4" face="times new roman, serif">sineTable doWithIndex: "And let's not deafen anyone..."</font></div>
<div class="gmail_default"><font size="4" face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"></span>[:sample :index| sineTable at: index put: sample // 4].</font></div>
<div class="gmail_default"><font size="4" face="times new roman, serif">samples := SoundBuffer new: 16000.</font></div>
<div class="gmail_default"><font size="4" face="times new roman, serif">1 to: samples size by: sineTable size do:</font></div>
<div class="gmail_default"><font size="4" face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"></span>[:i| samples replaceFrom: i to: (i + sineTable size - 1 min: 16000) with: sineTable startingAt: 1].</font></div>
<div class="gmail_default"><font size="4" face="times new roman, serif">1 to: 146 do:</font></div>
<div class="gmail_default"><font size="4" face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"></span>[:i|</font></div>
<div class="gmail_default"><font size="4" face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"></span>samples at: i put: ((samples at: i) * i / 146) asInteger.</font></div>
<div class="gmail_default"><font size="4" face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"></span>samples at: 16001 - i put: ((samples at: 16001 - i) * i / 146) asInteger].</font></div>
<div class="gmail_default"><font size="4" face="times new roman, serif">sound := SampledSound</font></div>
<div class="gmail_default"><font size="4" face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"></span>samples: samples</font></div>
<div class="gmail_default"><font size="4" face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"></span>samplingRate: 16000.</font></div>
<div class="gmail_default"><font size="4" face="times new roman, serif">sound := MixedSound new</font></div>
<div class="gmail_default"><font size="4" face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"></span>add: sound pan: 0.25;</font></div>
<div class="gmail_default"><font size="4" face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"></span>add: sound pan: 0.75;</font></div>
<div class="gmail_default"><font size="4" face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"></span>yourself.</font></div>
<div class="gmail_default"><font size="4" face="times new roman, serif">sound computeSamplesForSeconds: sound duration</font></div>
<div class="gmail_default"><font face="arial, sans-serif" size="4"><br>
</font></div>
<div class="gmail_default"><font face="arial, sans-serif" size="4"><br>
</font></div>
<div class="gmail_default"><font face="arial, sans-serif" size="4">Open a workspace in e.g. a 64-bit image prior to Tools-mt.965 (I used an image containing Tools-mt.942). Debug the above in the workspace. Position the cursor at "<span style="color:rgb(0,0,0)">sound
computeSamplesForSeconds: sound duration" and do "run to here". It is essentially instantaneous.</span></font></div>
<div class="gmail_default"><span style="color:rgb(0,0,0)"><font face="arial, sans-serif" size="4"><br>
</font></span></div>
<div class="gmail_default"><font color="#000000" face="arial, sans-serif" size="4"><span style="caret-color: rgb(0, 0, 0);">Now do the same in a contemporary trunk image. It takes almost 6 seconds.</span></font></div>
<div class="gmail_default"><font color="#000000" face="arial, sans-serif" size="4"><span style="caret-color: rgb(0, 0, 0);"><br>
</span></font></div>
<div class="gmail_default"><font color="#000000" face="arial, sans-serif" size="4"><span style="caret-color: rgb(0, 0, 0);">I used to be able to click step as fast as I could and the system would keep up with me. Now I find that if I click too fast I can accumulate
excess clicks and when I stp clicking the system will continue stepping and go too far.</span></font></div>
<div class="gmail_default"><font color="#000000" face="arial, sans-serif" size="4"><span style="caret-color: rgb(0, 0, 0);"><br>
</span></font></div>
<div class="gmail_default"><font color="#000000" face="arial, sans-serif" size="4"><span style="caret-color: rgb(0, 0, 0);">I don't want to lose the feedback the new variables list gives us. But I do find the performance hit tedious. I wonder could we cache
the list and only update it</span></font></div>
<div class="gmail_default"><font color="#000000" face="arial, sans-serif" size="4"><span style="caret-color: rgb(0, 0, 0);">- when Morphic updates, and</span></font></div>
<div class="gmail_default"><font color="#000000" face="arial, sans-serif" size="4"><span style="caret-color: rgb(0, 0, 0);">- when the context changes?</span></font></div>
<div class="gmail_default"><font color="#000000" face="arial, sans-serif" size="4"><span style="caret-color: rgb(0, 0, 0);"><br>
</span></font></div>
<div class="gmail_default"><span style="color:rgb(0,0,0)"><font face="arial, sans-serif" size="4"><br>
</font></span></div>
</div>
<div dir="ltr" class="gmail_signature">
<div dir="ltr">
<div><span style="border-collapse:separate"><font face="arial, sans-serif" size="4">
<div>_,,,^..^,,,_<br>
</div>
<div>best, Eliot</div>
</font></span></div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>