<div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:large">Hi Marcel, Hi Christoph,</div><div class="gmail_default" style="font-size:large"><br></div><div class="gmail_default" style="font-size:large"> I emailed the list and cc'ed you to get your attention. Forgive my rude interruption. I finally found out where the slow down really is. It is in </div><div class="gmail_default" style="font-size:large"><br></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif">Inspector>>fieldList</font></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>"Return a list of texts that identify the fields for the object under inspection so that the user can make an informed decision on what to inspect."</font></div><div class="gmail_default" style="font-size:large"><span class="gmail-Apple-tab-span" style="white-space:pre"><font face="times new roman, serif"> </font></span></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>^ self fieldListStyler</font></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>ifNil: [self fields collect: [:field | field name]]</font></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>ifNotNil: [:styler |</font></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>self updateStyler: styler.</font></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>self fields collect: [:field |</font></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>field shouldStyleName</font></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>ifTrue: [styler styledTextFor: field name asText]</font></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>ifFalse: [field name]]]</font></div><div class="gmail_default" style="font-size:large"><br></div><div class="gmail_default" style="font-size:large">So this runs a styler over the entire method every time one steps. And if one is stepping through a doit it will call the decompiler to generate the source to style, every time you step. We have to do better :-)</div><div class="gmail_default" style="font-size:large"><br></div><div class="gmail_default" style="font-size:large">Here's how to profile it. Debug a doit. I wrote this one:</div><div class="gmail_default" style="font-size:large"><br></div><div class="gmail_default" style="font-size:large"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span><font face="times new roman, serif">| t |</font></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>t := 0.</font></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>[| a b c |</font></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>a := 1. b := 2. c := 100.</font></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>(a = 1 and: [b = 2 and: [c = 100]])</font></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>ifTrue:</font></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>[1 to: 100 by: 2 do:</font></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>[:i| t := t + 1]]</font></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>ifFalse:</font></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>[a to: c by: b do:</font></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>[:i| t := t + 1]]] repeat.</font></div><div class="gmail_default" style="font-size:large"><font face="times new roman, serif"><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>t</font></div><div class="gmail_default" style="font-size:large"><br></div><div class="gmail_default" style="font-size:large">Once in the debugger inspect the "Over" button. Then in that inspector evaluate </div><div class="gmail_default" style="font-size:large"><br></div><div class="gmail_default" style="font-size:large"> <font face="times new roman, serif">AndreasSystemProfiler spyOn: [1000 timesRepeat: [self performAction]]</font></div><div class="gmail_default" style="font-size:large"><br></div><div class="gmail_default" style="font-size:large">and you'll see that essentially all the time is going into SHTextStylerST80(SHTextStyler) styledTextFor:</div></div></div></div></div></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Oct 2, 2020 at 1:44 PM <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Eliot Miranda uploaded a new version of Tools to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Tools-eem.994.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/trunk/Tools-eem.994.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Tools-eem.994<br>
Author: eem<br>
Time: 2 October 2020, 1:44:29.015648 pm<br>
UUID: 23145257-280d-4a4a-a4ba-3b5cc367f9a9<br>
Ancestors: Tools-eem.993<br>
<br>
Oops! Compiledmethod>>blockExtentsToTempsMap needs to observe that startKeysToBlockExtents has moved to DebuggerMethodMap.<br>
<br>
=============== Diff against Tools-eem.993 ===============<br>
<br>
Item was changed:<br>
----- Method: CompiledMethod>>blockExtentsToTempsMap (in category '*Tools-Debugger-support') -----<br>
blockExtentsToTempsMap<br>
"If the receiver has been copied with temp names answer a<br>
map from blockExtent to temps map in the same format as<br>
BytecodeEncoder>>blockExtentsToTempNamesMap. if the<br>
receiver has not been copied with temps answer nil."<br>
^self holdsTempNames ifTrue:<br>
+ [self mapFromBlockKeys: (self debuggerMap startKeysToBlockExtents values sort: [:assocA :assocB| assocA first <= assocB first])<br>
- [self mapFromBlockKeys: (self startKeysToBlockExtents values sort: [:assocA :assocB| assocA first <= assocB first])<br>
toSchematicTemps: self tempNamesString]!<br>
<br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div>