<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:large">Hi Javier,</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 20, 2020 at 12:27 PM Javier Diaz-Reinoso via Squeak-dev <<a href="mailto:squeak-dev@lists.squeakfoundation.org">squeak-dev@lists.squeakfoundation.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div dir="auto" style="word-wrap:break-word;line-break:after-white-space">I find you like the 'Workspace from ', I think at first I conserve that but then I discard as redundant, but if you need that the change is OK with me.</div></div></blockquote><div><br></div><div class="gmail_default" style="font-size:large">It's not that I like it or don't.  It's the way the system worked and one shouldn't break things like that just for personal preference.  So in integrating your code I had two criteria</div><div class="gmail_default" style="font-size:large">- fix the bugs (your code to track the directory and line ending, and to get the title and save name right, is clearly an improvement)</div><div class="gmail_default" style="font-size:large">- don't change the observable behaviour except in eliminating bugs</div><div class="gmail_default" style="font-size:large"><br></div><div class="gmail_default" style="font-size:large">I'm happy not to have "Workspace from ..." in the title but I don't get to just do that on a whim.  That would need to be discussed and something close to consensus reached before it could be changed.</div><div class="gmail_default" style="font-size:large"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div dir="auto" style="word-wrap:break-word;line-break:after-white-space"><br></div><div dir="auto" style="word-wrap:break-word;line-break:after-white-space">By the way I also have a hack for your PluggableSystemWindowWithLabelButton, I don't like the hidden (magic?) button, I always try to move the window and instead the menu pop up, so I modify the button as a visible and with '<=>' as the label, remind me of the Previous, Next arrows in other text editors like XCode:</div><div dir="auto" style="word-wrap:break-word;line-break:after-white-space"><img id="gmail-m_759134446520072260016369277-04B5-4E4C-8101-20BB4F772B20" src="cid:1754c3ac3e517038cc01"></div><div dir="auto" style="word-wrap:break-word;line-break:after-white-space"><br></div><div dir="auto" style="word-wrap:break-word;line-break:after-white-space">I think you probably don't like that also, but I always have the 'extra st' folder for my modifications, thats is the things I like in Squeak.<br><div><br><blockquote type="cite"><div>On 20 Oct 2020, at 12:31, Eliot Miranda <<a href="mailto:eliot.miranda@gmail.com" target="_blank">eliot.miranda@gmail.com</a>> wrote:</div><br><div><br><br style="font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div class="gmail_quote" style="font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div dir="ltr" class="gmail_attr">On Tue, Oct 20, 2020 at 10:26 AM Javier Diaz-Reinoso via Squeak-dev <<a href="mailto:squeak-dev@lists.squeakfoundation.org" target="_blank">squeak-dev@lists.squeakfoundation.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space">Not with this change.<br></div></blockquote><div><br></div><div style="font-size:large">I tweaked it a bit.  It should be ok now.  If you'd like to review my massage of your code I'd appreciate it.</div><div style="font-size:large"></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div><br><blockquote type="cite"><div>On 19 Oct 2020, at 20:29, gettimothy via Squeak-dev <<a href="mailto:squeak-dev@lists.squeakfoundation.org" target="_blank">squeak-dev@lists.squeakfoundation.org</a>> wrote:</div><br><div><div><div style="font-size:10pt;font-family:Verdana,Arial,Helvetica,sans-serif">Thabk you.<br><br><br>I am not sure if this other OCD nightmare has been addressed in this discusion, bot the tail end of the title suffers from a similar issue.<br><br>Workspace titled OCD.txt, save workspace contents to file->  OCD.txt.txt<br>File in contents to Workspace...<br>Workspace titled OCD.txt.txt  save workspace contents to file->  OCD.txt.txt.txt<br>.....<br><br>Cheers<br><div id="gmail-m_7591344465200722600gmail-m_-3193007172557227275message"></div><br id="gmail-m_7591344465200722600gmail-m_-3193007172557227275br3"><div id="gmail-m_7591344465200722600gmail-m_-3193007172557227275signature"></div><div id="gmail-m_7591344465200722600gmail-m_-3193007172557227275content"><br>---- On Mon, 19 Oct 2020 20:19:19 -0400<span> </span><b><a href="mailto:eliot.miranda@gmail.com" target="_blank">eliot.miranda@gmail.com</a><span> </span></b>wrote ----<br><br><blockquote style="border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:6px;margin-left:5px"><div><div dir="ltr"><div style="font-size:large">Thanks Javier, I integrated it today.  Finally :-)</div></div><br><div><div dir="ltr">On Sun, Oct 18, 2020 at 8:59 AM Javier Diaz-Reinoso via Squeak-dev <<a href="mailto:squeak-dev@lists.squeakfoundation.org" target="_blank">squeak-dev@lists.squeakfoundation.org</a>> wrote:<br></div><blockquote style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div>I send the list a change set years ago and was ignored, the current version I use also preserve the lineConversion and remember the name for save:<div><br><div></div></div></div><div><div><div><br><blockquote><div>On 18 Oct 2020, at 07:41, Eliot Miranda <<a href="mailto:eliot.miranda@gmail.com" target="_blank">eliot.miranda@gmail.com</a>> wrote:</div><br><div><span style="font-family:Helvetica;font-size:14px;font-style:normal;font-weight:normal;letter-spacing:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">Hi Tim,</span><br style="font-family:Helvetica;font-size:14px;font-style:normal;font-weight:normal;letter-spacing:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div dir="ltr" style="font-family:Helvetica;font-size:14px;font-style:normal;font-weight:normal;letter-spacing:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br></div><div dir="ltr" style="font-family:Helvetica;font-size:14px;font-style:normal;font-weight:normal;letter-spacing:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br><blockquote>On Oct 18, 2020, at 3:57 AM, gettimothy via Squeak-dev <<a href="mailto:squeak-dev@lists.squeakfoundation.org" target="_blank">squeak-dev@lists.squeakfoundation.org</a>> wrote:<br><br></blockquote></div><blockquote style="font-family:Helvetica;font-size:14px;font-style:normal;font-weight:normal;letter-spacing:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div dir="ltr"><div style="font-family:Verdana,Arial,Helvetica,sans-serif;font-size:10pt"><div>Ignore as fitting<br></div></div></div></blockquote><div style="font-family:Helvetica;font-size:14px;font-style:normal;font-weight:normal;letter-spacing:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br></div><span style="font-family:Helvetica;font-size:14px;font-style:normal;font-weight:normal;letter-spacing:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">I can join you; this gets on my tits.</span><div style="font-family:Helvetica;font-size:14px;font-style:normal;font-weight:normal;letter-spacing:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br><blockquote><div dir="ltr"><div style="font-family:Verdana,Arial,Helvetica,sans-serif;font-size:10pt"><div><br></div><div><a href="https://www.pinterest.com/indigogeek/ocd-nightmares/" target="_blank">https://www.pinterest.com/indigogeek/ocd-nightmares/</a><br></div><div><br></div><div><br></div><blockquote style="border:1px solid rgb(204,204,204);padding:7px;background-color:rgb(245,245,245)"><div><div>FileList >>viewContentsInWorkspace<br></div><div>"View the contents of my selected file in a new workspace"<br></div><div><br></div><div>| aString aFileStream aName |<br></div><div>aString := (aFileStream := directory readOnlyFileNamed: self fullName) setConverterForCode contentsOfEntireFile.<br></div><div>aName := aFileStream localName.<br></div><div>aFileStream close.<br></div><div>UIManager default edit: aString withSqueakLineEndings label:<b><span> </span>'Workspace from ',</b>aName<br></div></div></blockquote><div><br></div><div>maybe its the OCD in me, but that verbiage preceding the file name at the top of a workspace is redundant and annoying.<br></div><div><br></div><div>1. redundant--it is at the top of a Workspace.<br></div><div>2. the infinitely expanding title ala <i><b>Worspace from Workspace from Worspace from Workspace from Foo.txt</b></i><br></div><div>3. I have to edit each title upon file in. see OCD above.<br></div><div><br></div><div><br></div><div>A simple change to the method:<br></div><blockquote style="border:1px solid rgb(204,204,204);padding:7px;background-color:rgb(245,245,245)"><div><div>FileList >> viewContentsInWorkspace<br></div><div>"View the contents of my selected file in a new workspace"<br></div><div><br></div><div>| aString aFileStream aName |<br></div><div>aString := (aFileStream := directory readOnlyFileNamed: self fullName) setConverterForCode contentsOfEntireFile.<br></div><div>aName := aFileStream localName.<br></div><div>aFileStream close.<br></div><div><b>UIManager default edit: aString withSqueakLineEndings label: aName</b><br></div><div><br></div><div><br></div></div></blockquote><div><br></div><div>eradicates the OCD nightmare  <br></div></div></div></blockquote><div><br></div>The only thing I’d suggest differently is that it check if the file name contains “Workspace’ and if not, still adds the ‘Workspace from ’ prefix.</div><div style="font-family:Helvetica;font-size:14px;font-style:normal;font-weight:normal;letter-spacing:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br><blockquote><div dir="ltr"><div style="font-family:Verdana,Arial,Helvetica,sans-serif;font-size:10pt"><div><span style="font-size:10pt">cheers,</span></div><div><br></div><div>tty</div></div></div></blockquote></div></div></blockquote></div><br></div></div><br></blockquote></div><br><div><br></div>--<span> </span><br><div dir="ltr"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div><br></div></blockquote></div></div><br></div><br></div></blockquote></div><br></div><br></blockquote></div><br clear="all" style="font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div style="font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br></div><span style="font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">--<span> </span></span><br style="font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div dir="ltr" style="font-family:Helvetica;font-size:14px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div></div></blockquote></div><br></div></div><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div></div>