<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Hi Tim,</p>
<p><br>
</p>
<p>some scattered comments on your changes: It's a great idea to refactor this windowTitle stuff!</p>
<p><br>
</p>
<p>Personally, I think it would look nicer if you could leave out the spaces between the brackets, e.g. "<span>Implementors of initialize [987]" instead of "<span>Implementors of initialize [ 987 ]".</span></span></p>
<p></p>
<p><br>
</p>
<p>Not a regression, but still a bug: Select 42 in some method in a MessageTrace and browse senders -> <span>Error: Instances of SmallInteger are not indexable from #findAgainNow. Is this related to your changes?</span></p>
<p><br>
</p>
<p>> <span>Possibly better to do asOrderedCollection sort ?</span></p>
<p><span><br>
</span></p>
<p><span>Sounds reasonable.</span></p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">
<div class="x__rp_U4 x_ms-font-weight-regular x_ms-font-color-neutralDark x_rpHighlightAllClass x_rpHighlightBodyClass" id="x_Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="x_divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="x_Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont"></font></div>
</div>
</font></div>
</div>
</div>
</div>
<div class="x__rp_T4" id="x_Item.MessagePartBody"><br>
</div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">> <span style="font-size:12pt">Now, about that improvement to the Shout stuff...</span>
<div><br>
</div>
<div>Your ideas sound interesting. We have collected so many ideas on what Shout/attributes could do else (<a href="http://forum.world.st/Changeset-ShoutAttribute-amp-semi-styling-td5106776.html" class="x_OWAAutoLink">ShoutAttribute</a>, highlight searched
text, and here are some other rough ideas: highlight all occurrences of the currently selected word/selector as you may know it from VS Code; automatically style hyperlinks with a TextURL
<span style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">(ask Tom Beckmann for more details on this idea</span><span style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">) </span>or class names with a TextLink; a text attribute
that adds a tooltip to a certain subtext; allow to browse a word by Ctrl + clicking it, probably again via a text attribute; ...). Maybe we should finally split up the TextAttribute hierarchy into two layers, one low-level layer for emphasis, indent, etc.,
and one high-level layer for attributes that need to be converted into low-level attributes before display, e.g. StyleAttribute, HighlightAttribute, etc. This conversion could be done by a shout-like mechanism. Yeah, these are indeed rough ideas, just wanted
to collect them anywhere. :-)</div>
<div><br>
</div>
<div>Best,</div>
<div>Christoph</div>
</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von tim Rowledge <tim@rowledge.org><br>
<b>Gesendet:</b> Montag, 19. Oktober 2020 02:32:39<br>
<b>An:</b> The general-purpose Squeak developers list<br>
<b>Betreff:</b> Re: [squeak-dev] Improving the SystemNavigation browseMessageList... stuff</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">OK, review time !<br>
<br>
See inbox Tools-tpr.1003 and System-tpr.1181 for some fairly simple changes to how the message list is built (as a set and sorted etc) and improvements to how the window label is derived.
<br>
<br>
The only visible change should be that when the window initially opens the label will reflect the fact that the first item is actually selected - the prior code actually started in a weird state with the label that should be used when nothing is selected. I
think it is more correct now but one might argue that nothing should be selected by default for this sort of browser.<br>
<br>
Now, about that improvement to the Shout stuff...<br>
<br>
tim<br>
--<br>
tim Rowledge; tim@rowledge.org; <a href="http://www.rowledge.org/tim">http://www.rowledge.org/tim</a><br>
Useful random insult:- Wasn't fully debugged before being released.<br>
<br>
<br>
<br>
</div>
</span></font>
</body>
</html>