<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Hi Jakob,</p>
<p><br>
</p>
<p>thanks for the detailed review! :-)</p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">
<div class="x__rp_U4 x_ms-font-weight-regular x_ms-font-color-neutralDark x_rpHighlightAllClass x_rpHighlightBodyClass" id="x_Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="x_divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="x_Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont">
<div><font size="3" color="black"><span style="font-size:12pt"><a href="http://www.hpi.de/" target="_blank" rel="noopener noreferrer" id="LPNoLP"><font size="2"><span id="LPlnk909538"><font color="#757B80"></font></span></font></a></span></font></div>
</font></div>
</div>
</font></div>
</div>
</div>
</div>
<div class="x__rp_T4" id="x_Item.MessagePartBody"><br>
</div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">> <span style="font-size:12pt">How about using MCDefinition>>#isRevisionOf: instead of a description </span><span style="font-size:12pt">= b description? Saves people like me from wondering why description </span><span style="font-size:12pt">is
used here (and what it contains anyway).</span>
<div><br>
</div>
<div>Because I did not know this small but useful method. :P Will be fixed in the next version ...</div>
<div><br>
</div>
<div>> <span style="font-size:12pt">In domain terms, why is it significant here that the definitions are </span><span style="font-size:12pt">members of an organization? Why does this procedure not apply to </span><span style="font-size:12pt">organization changes
or script changes, for example?</span>
<div><br>
</div>
<div>Fair question. #description is only unique for a definition that is part of an organization. Given a set of two MCVersions one of which would add and the second one would delete an MCOrganizationDefinition for separate packages, by the current implementation
these organization definitions would be revisions of each other and thus would be wiped up in #<span>forgetSuperfluousMethodRemovals. However, since you're commenting this, I'm asking myself two questions:</span></div>
<div>
<ol style="margin-bottom:0px; margin-top:0px">
<li><span>Is it a valid operation to remove an entire organization definition under any circumstances?</span></li><li><span>Couldn't we instead modify the #definition implementation of MCOrganizationDefinition and insert the containing system category name at this place? Semantically, this would look better for me, but unfortunately, <span style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">MCOrganizationDefinition
does not have a relevant instance variable ...</span></span></li></ol>
<div><br>
</div>
</div>
<div>> <span style="font-size:12pt">Instead of allocating another Collection instance, you could also use </span><span style="font-size:12pt">an OrderedCollection for the removals and use removeAllSuchThat:, or </span><span style="font-size:12pt">put all the
conditions in just one reject block.</span>
<div><br>
</div>
<div>Good idea.</div>
<div><br>
</div>
<div>> <span style="font-size:12pt">> Thanks to Tom Beckmann (TB)</span>
<div>> </div>
<div>> Finally, doesn't Tom use tobe as his author initials?</div>
<div><br>
</div>
<div>Does he? In Pheno (2018), he uses TB. However, the following returns to 'tobe':</div>
<div><br>
</div>
<div><span>SystemNavigation authors at: 'Tom Beckmann'</span><br>
</div>
<div><span><br>
</span></div>
<div><span>Hm ... ;-)</span></div>
<div><span><br>
</span></div>
<div><span>Best,</span></div>
<div><span>Christoph</span></div>
</div>
</div>
</div>
</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Jakob Reschke <forums.jakob@resfarm.de><br>
<b>Gesendet:</b> Montag, 16. November 2020 17:28:19<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org; Thiede, Christoph; Tom Beckmann<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: Monticello-ct.732.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Hi,<br>
<br>
Am Mo., 16. Nov. 2020 um 16:00 Uhr schrieb <commits@source.squeak.org>:<br>
><br>
> + removals := removals reject: [:removal |<br>
> + removal isOrganizationMember and: [<br>
> + additions anySatisfy: [:addition |<br>
> + addition isOrganizationMember and: [addition description = removal description]]]].!<br>
<br>
How about using MCDefinition>>#isRevisionOf: instead of a description<br>
= b description? Saves people like me from wondering why description<br>
is used here (and what it contains anyway).<br>
<br>
In domain terms, why is it significant here that the definitions are<br>
members of an organization? Why does this procedure not apply to<br>
organization changes or script changes, for example?<br>
<br>
Instead of allocating another Collection instance, you could also use<br>
an OrderedCollection for the removals and use removeAllSuchThat:, or<br>
put all the conditions in just one reject block.<br>
<br>
> Thanks to Tom Beckmann (TB)<br>
<br>
Finally, doesn't Tom use tobe as his author initials?<br>
<br>
Kind regards,<br>
Jakob<br>
</div>
</span></font>
</body>
</html>