<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Thanks for the fast merge!</p>
<p><br>
</p>
<p>---</p>
<p><br>
</p>
<p>Concerning this refactoring, I'm not sure whether it actually improves readability. :-)</p>
<p>It might be a few byte steps faster, but that should not be our ultimate goal in all high-level domain-specific packages.</p>
<p>Your version only implicitly shows that nil should be returned if the project is morphic.</p>
<p>And the assignment expression ... not convinced, again. There have been enough discussions about it when they added the feature to Python 3, but I think it's true that doing multiple things in one statement is rather confusing than intuitive.</p>
<p><br>
</p>
<p>That's no big deal, of course, I'm only mentioning it because you explicitly uploaded this refactoring. I would have rather expect the reciprocal changeset as a refactoring that conforms to my own personal taste of coding style. :-)</p>
<p><br>
</p>
<p>Have a nice weekend,</p>
<p>Christoph</p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Sonntag, 3. Januar 2021 20:56:08<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Trunk: Tools-eem.1022.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Eliot Miranda uploaded a new version of Tools to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Tools-eem.1022.mcz">http://source.squeak.org/trunk/Tools-eem.1022.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Tools-eem.1022<br>
Author: eem<br>
Time: 3 January 2021, 11:56:05.837731 am<br>
UUID: 67d66d1d-d650-45f4-8a72-1dd88c6d8ba4<br>
Ancestors: Tools-ct.1021<br>
<br>
Less verbosity in ObjectExplorer>>#world<br>
<br>
=============== Diff against Tools-ct.1021 ===============<br>
<br>
Item was changed:<br>
----- Method: ObjectExplorer>>world (in category 'monitoring') -----<br>
world<br>
- <br>
| project |<br>
+ ^(project := Project current) isMorphic ifTrue: [project world]!<br>
- project := Project current.<br>
- project isMorphic ifFalse: [^ nil].<br>
- ^ project world!<br>
<br>
<br>
</div>
</span></font>
</body>
</html>