<body><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Javier.<div><br></div><div>I backported that #shrinkWrap fix to 5.3. Maybe this helps a little bit. Still, <span style="font-size: 10pt">UISimpleGroupBoxMorph should really have its own table layout. :-)</span></div><div><span style="font-size: 10pt"><br></span></div><div><span style="font-size: 10pt">Best,</span></div><div><span style="font-size: 10pt">Marcel</span></div><div class="mb_sig"></div><blockquote class='history_container' type='cite' style='border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;'>
<p style='color: #AAAAAA; margin-top: 10px;'>Am 25.01.2021 13:41:52 schrieb Marcel Taeumel <marcel.taeumel@hpi.de>:</p><div style='font-family:Arial,Helvetica,sans-serif'><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Javier.<div><br></div><div>Since UISimpleGroupBoxMorph manages the layout of label and contents, it needs a TableLayoutPolicy. Then it works as expected:</div><div><br></div><div><img id="3c57295d-f7b8-4df6-959a-e3dafd18be0e" src="cid:4131e1b8-2953-4ea2-84e7-e9bcf99d7781" width="139" height="59"></img><br></div><div><br></div><div>Still, I wonder why #adjustLayoutBounds does not wrap around the misaligned submorphs when not having that layout:</div><div><br></div><div><img id="513d395d-dfaa-4869-b0b9-1477ab6a6938" src="cid:7224ae52-3c55-4cb9-83c6-aa79688aff92" width="131" height="48"></img><br></div><div><br></div><div>At least, I would expect this:</div><div><br></div><div><img id="4d2ffa0d-32cc-46db-bcb3-a07433ae8cf3" src="cid:88ac97ce-c655-415c-971b-9aefca61a24e" width="151" height="56"></img><br></div><div>Hmmm.....</div><div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 25.01.2021 12:46:14 schrieb Marcel Taeumel <marcel.taeumel@hpi.de>:</p><div style="font-family:Arial,Helvetica,sans-serif"><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
> <span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">You are blaming indeterminate hacks in BobosUi for the problems</span><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Sorry. I was just saying, that BobsUI subclassed almost all UI classes in Morphic and made changes that override many things in the base system. For this, of course, it assumes a certain behavior (or misbhevior) in the base system. Consequently, compatibility issues could arise anywhere. :-/</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">></span><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">who show the same bug, also this test work in 5.2 ans with the revert of Morph>>adjustLayoutBounds.</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif"><span style="font-size: 13px">Reverting this method produces many bugs. 5 tests in TableLayout fail, for example.</span></span></div><div><span style="font-family: Arial, Helvetica, sans-serif"><span style="font-size: 13px"><br></span></span></div><div><span style="font-family: Arial, Helvetica, sans-serif"><span style="font-size: 13px">> </span></span><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">So I think this is a "clean" bug created for the changes in the table layout in 5.3.</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Thank you, for reproducing the behavior. I will take a look at it.</span></div><div><span style="font-family: Arial, Helvetica, sans-serif"><span style="font-size: 13px"><br></span></span></div><div><span style="font-family: Arial, Helvetica, sans-serif"><span style="font-size: 13px">Best,</span></span></div><div><span style="font-family: Arial, Helvetica, sans-serif"><span style="font-size: 13px">Marcel</span></span></div><div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 22.01.2021 18:16:29 schrieb Javier Diaz-Reinoso via Squeak-dev <squeak-dev@lists.squeakfoundation.org>:</p><div style="font-family:Arial,Helvetica,sans-serif">
<div class="" style="word-wrap:break-word; line-break:after-white-space"><br class="">
<div>
<blockquote type="cite" class="" style="min-width: 500px">
<div class="">On 19 Jan 2021, at 06:50, Marcel Taeumel <<a href="mailto:marcel.taeumel@hpi.de" class="">marcel.taeumel@hpi.de</a>> wrote:</div>
<br class="x_Apple-interchange-newline">
<div class="">
<div id="x___MailbirdStyleContent" dir="ltr" class="" style="font-size: 10pt;font-family: Arial;text-align: left">
Hmm.... "BobsUI" uses a mix of layout policies and overrides through custom implementations of #extent: or #width: or #height:. Hmpf. Sometimes even in the same morph that actually uses such a policy. It also looks like that BobsUI fixes several layout bugs
from 5.2 and before through subclassing. Unfortunately, one would have to go through all UI* classes and remove all those changes (or hacks).
<div class=""><br class="">
</div>
<div class="">I do not have the resources to do that now. :-( What needs to be done is to replace all hacks in #width: and #height: (etc.) with proper configuration of layout properties (i.e., #hResizing, #vResizing, ...)</div>
<div class=""><br class="">
</div>
<div class="">The one thing you can easily fix is to replace all "#cellInset:" calls with "#cellGap:", which is explained in the Squeak 5.3 release notes.</div>
<div class=""><br class="">
</div>
<div class=""><span class="" style="font-size: 10pt">Best,</span><br class="">
</div>
<div class="">Marcel</div>
</div>
</div>
</blockquote>
<br class="">
</div>
<div>[... cut ...]</div>
<div><br class="">
</div>
<div>You are blaming indeterminate hacks in BobosUi for the problems, al least for the UIGroupBoxMorph problem that is not correct. I now extracted that morph from BobsUi to <a href="http://UISimpleGroupBoxMorph.st" class="">UISimpleGroupBoxMorph</a> removing
all instances and selectors who are not involves in the initialization, also recreated by hand the tree of morphsusing only regular morphs, this is in the workspace 'test UISimpleGroupBox.text', the result of evaluating is:</div>
<div><br class="">
</div>
</div>
<div><img src="cid:d0c24ac7-66b4-44c9-9015-73123ab9d66e@hpi.uni-potsdam.de"></img> </div>
<div class="" style="word-wrap:break-word; line-break:after-white-space">
<div class=""><br class="">
</div>
<div class="">who show the same bug, also this test work in 5.2 ans with the revert of Morph>>adjustLayoutBounds.</div>
<div class=""><br class="">
</div>
<div class="">So I think this is a "clean" bug created for the changes in the table layout in 5.3.</div>
<div class=""><br class="">
</div>
<div class="">As for the other problems with the UITitleBarMorph and the extra spaces, I think is also produced by bugs in the same area, after all BobsUI are not changing that area.</div>
<div class=""><br class="">
</div>
<div class=""></div>
</div>
<div class="" style="word-wrap:break-word; line-break:after-white-space">
<div></div>
</div>
<div class="" style="word-wrap:break-word; line-break:after-white-space">
<div class=""></div>
<div class="">
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
</div>
</div>
</div></blockquote></div></div></blockquote></div></div></blockquote>
</div></body>