<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Btw - independently of this change - it's a shame that we still need to nest #and: blocks just because #and: is inlined but #(and:){2,} are not. We should change this someday ... or just wait for Sista to arrive. :-)</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="_rp_T4" id="Item.MessagePartBody">
<div class="_rp_U4 ms-font-weight-regular ms-font-color-neutralDark rpHighlightAllClass rpHighlightBodyClass" id="Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont">
<div><font size="3" color="black"><span style="font-size:12pt"><a href="http://www.hpi.de/" target="_blank" rel="noopener noreferrer" id="LPNoLP"><font size="2"><span id="LPlnk909538"><font color="#757B80"></font></span></font></a></span></font></div>
</font></div>
</div>
</font></div>
</div>
</div>
</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Thiede, Christoph<br>
<b>Gesendet:</b> Montag, 1. Februar 2021 15:45:46<br>
<b>An:</b> The general-purpose Squeak developers list<br>
<b>Betreff:</b> AW: [squeak-dev] The Trunk: Kernel-eem.1366.mcz</font>
<div> </div>
</div>
<div>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Hi all,</p>
<p><br>
</p>
<p>Eliot, thank you for the speed-up! I have uploaded <span>Kernel-ct.1369 to the inbox to fix the regression in the simulator.</span></p>
<p><span><br>
</span></p>
<p><span>@Levente I don't see the need for mirror primitives here; the PrimitiveFailToken is a concept internal to the simulator and iiuc mirror primitives should only be used when dealing with objects from the *simulated* code. Am I wrong? :-)</span></p>
<p><span><br>
</span></p>
<p><span>Best,</span></p>
<p><span>Christoph</span></p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">
<div class="x__rp_U4 x_ms-font-weight-regular x_ms-font-color-neutralDark x_rpHighlightAllClass x_rpHighlightBodyClass" id="x_Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="x_divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="x_Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont">
<div><font size="3" color="black"><span style="font-size:12pt"><a href="http://www.hpi.de/" target="_blank" rel="noopener noreferrer" id="LPNoLP"><font size="2"><span id="LPlnk909538"><font color="#757B80"></font></span></font></a></span></font></div>
</font></div>
</div>
</font></div>
</div>
</div>
</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Levente Uzonyi <leves@caesar.elte.hu><br>
<b>Gesendet:</b> Donnerstag, 28. Januar 2021 15:56:07<br>
<b>An:</b> The general-purpose Squeak developers list<br>
<b>Betreff:</b> Re: [squeak-dev] The Trunk: Kernel-eem.1366.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Hi Marcel,<br>
<br>
On Thu, 28 Jan 2021, Marcel Taeumel wrote:<br>
<br>
> Hi Levente.<br>
> > I also wonder why you used #objectClass: there instead of #class in the<br>
> previous version. Perhaps there was a good reason.<br>
> Maybe because of ProtoObject (and proxies)? I think the long-term plan was to not treat #class as a special send anymore so that proxies can override that interface.<br>
<br>
In that case there are two problems with the rewrite.<br>
<br>
Btw, Eliot didn't mention it in the other thread, but #class is currently <br>
a way to avoid suspension points, just like #==, #ifNil:ifNotNil:, <br>
#caseOf:otherwise:, ifTrue:ifFalse:, etc.<br>
<br>
<br>
Levente<br>
<br>
> <br>
> Best,<br>
> Marcel<br>
><br>
> Am 28.01.2021 13:46:12 schrieb Levente Uzonyi <leves@caesar.elte.hu>:<br>
><br>
> Hi Eliot,<br>
><br>
> On Wed, 27 Jan 2021, commits@source.squeak.org wrote:<br>
><br>
> > Eliot Miranda uploaded a new version of Kernel to project The Trunk:<br>
> > <a href="http://source.squeak.org/trunk/Kernel-eem.1366.mcz">http://source.squeak.org/trunk/Kernel-eem.1366.mcz</a><br>
> ><br>
> > ==================== Summary ====================<br>
> ><br>
> > Name: Kernel-eem.1366<br>
> > Author: eem<br>
> > Time: 26 January 2021, 4:27:57.204259 pm<br>
> > UUID: 3a706d32-c2d6-416f-82c1-bbf735650385<br>
> > Ancestors: Kernel-eem.1365<br>
> ><br>
> > Slightly faster implementation of Context>>#isPrimFailToken:.<br>
> > Improve the comments in Context>>#isHandlerContext/#isUnwindContext.<br>
> > Nuke an obsolete method.<br>
> ><br>
> > =============== Diff against Kernel-eem.1365 ===============<br>
> ><br>
> > Item was changed:<br>
> > ----- Method: Context>>isHandlerContext (in category 'private-exceptions') -----<br>
> > isHandlerContext<br>
> > + "Answer if the receiver is for a method that is marked as an exception handler.<br>
> > + BlockClosure>>#on:do: uses this primitive to identify itself to the VM<br>
> > + as an exception handler method, which the VM uses in primitive 197<br>
> > + Context>>#findNextHandlerContextStarting, primitiveFindHandlerContext,<br>
> > + to accelerate the search for exception handlers."<br>
> > - "is this context for method that is marked?"<br>
> > ^method primitive = 199!<br>
> ><br>
> > Item was changed:<br>
> > ----- Method: Context>>isPrimFailToken: (in category 'private') -----<br>
> > isPrimFailToken: anObject<br>
> > + ^(self objectClass: anObject) isArray<br>
> > - ^(self objectClass: anObject) == Array<br>
><br>
> I think you meant to write<br>
><br>
> ^(anObject isArray<br>
><br>
> I also wonder why you used #objectClass: there instead of #class in the<br>
> previous version. Perhaps there was a good reason.<br>
> <br>
><br>
> Levente<br>
><br>
> > and: [anObject size = 2<br>
> > + and: [(anObject at: 1) == PrimitiveFailToken]]!<br>
> > - and: [anObject first == PrimitiveFailToken]]!<br>
> ><br>
> > Item was changed:<br>
> > ----- Method: Context>>isUnwindContext (in category 'private-exceptions') -----<br>
> > isUnwindContext<br>
> > + "Answer if the receiver is for a method that is marked as a non-local return/exception unwind protect.<br>
> > + BlockClosure>>#ensure: and BlockClosure>>#ifCurtailed: use this primitive to identify<br>
> > + themseves to the VM as unwind protect methods. The VM uses this in primitive 195<br>
> > + Context>>#findNextUnwindContextUpTo:, primitiveFindNextUnwindContext, to<br>
> > + accelerate the search for unwind protects."<br>
> > - "is this context for method that is marked?"<br>
> > ^method primitive = 198!<br>
> ><br>
> > Item was removed:<br>
> > - ----- Method: Context>>tryPrimitiveFor:receiver:args: (in category 'private') -----<br>
> > - tryPrimitiveFor: method receiver: receiver args: arguments<br>
> > - "If this method has a primitive index, then run the primitive and return its result.<br>
> > - Otherwise (and also if the primitive fails) return PrimitiveFailToken,<br>
> > - as an indication that the method should be activated and run as bytecodes."<br>
> > - | primIndex |<br>
> > - (primIndex := method primitive) = 0 ifTrue: [^{PrimitiveFailToken. nil}].<br>
> > - ^ self doPrimitive: primIndex method: method receiver: receiver args: arguments!<br>
> <br>
> <br>
></div>
</span></font></div>
</body>
</html>