<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto">Hi Christoph,<div dir="ltr"><br><blockquote type="cite">On Mar 2, 2021, at 5:17 AM, Thiede, Christoph <Christoph.Thiede@student.hpi.uni-potsdam.de> wrote:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr">
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
<meta content="text/html; charset=UTF-8">
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Hi Eliot,</p>
<p><br>
</p>
<p>thanks for the fix! Sorry for raising the same question again, but wouldn't it still be safer to dispense with the #isArray call here? It allows the simulated code to break out of the simulation by overriding #isArray anywhere. </p></div></div></div></blockquote><div><p class="p1" style="margin: 0px; font-stretch: normal; line-height: normal; -webkit-text-size-adjust: auto;"><span class="s1"><br></span></p><p class="p1" style="margin: 0px; font-stretch: normal; line-height: normal; -webkit-text-size-adjust: auto;"><span class="s1">As I understand it no. The clue is in the variable name. contextOrPrimFailToken can only ever be a Context or an Array, so the send of isArray serves only to quickly differentiate between a Context and an Array. The message doesn’t get sent to any other kinds of object at that point so the concern that other classes may define isArray does not apply here.</span></p></div><div><blockquote type="cite"><div dir="ltr"><div dir="ltr"><div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif"><p>I think I posted a proof of
concept here: <a href="http://forum.world.st/The-Trunk-Kernel-eem-1366-mcz-tp5126558p5126713.html" class="x_OWAAutoLink" id="LPlnk461878">http://forum.world.st/The-Trunk-Kernel-eem-1366-mcz-tp5126558p5126713.html</a> :-)</p>
<div><br>
</div>
Best,
<div>Christoph
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Dienstag, 2. Februar 2021 03:57:12<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Trunk: Kernel-eem.1367.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Eliot Miranda uploaded a new version of Kernel to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Kernel-eem.1367.mcz">http://source.squeak.org/trunk/Kernel-eem.1367.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Kernel-eem.1367<br>
Author: eem<br>
Time: 1 February 2021, 6:57:09.713484 pm<br>
UUID: def9aaa1-eb71-4da5-8f86-85856d9b88ad<br>
Ancestors: Kernel-eem.1366<br>
<br>
Fix mistake in the previous commit. Thanks Levente!<br>
<br>
=============== Diff against Kernel-eem.1366 ===============<br>
<br>
Item was changed:<br>
----- Method: Context>>isPrimFailToken: (in category 'private') -----<br>
+ isPrimFailToken: contextOrPrimFailToken<br>
+ "Answer if contextOrPrimFailToken, which will either be a Context object or<br>
+ a primitive fail token (a tuple of the PrimitiveFailToken unique object and<br>
+ a primitive failure code), is the latter. This should only be used with the<br>
+ (possibly indirect) results of Context>>doPrimitive:method:receiver:args:"<br>
+ ^contextOrPrimFailToken isArray<br>
+ and: [contextOrPrimFailToken size = 2<br>
+ and: [(contextOrPrimFailToken at: 1) == PrimitiveFailToken]]!<br>
- isPrimFailToken: anObject<br>
- ^(self objectClass: anObject) isArray<br>
- and: [anObject size = 2<br>
- and: [(anObject at: 1) == PrimitiveFailToken]]!<br>
<br>
<br>
</div>
</span></font>
<span></span><br></div></blockquote></div></body></html>