<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Hi Marcel,</p>
<p><br>
</p>
<p>with reference to the Win32 UX Guidelines, I was trying to express exactly the opposite: Simple, non-self-descriptive button labels can be dangerous because users often do not read the entire dialog before clicking the supposedly right button. For this reason,
I think we should rather have a general shift towards more "wordy" buttons than towards more abstract button titles. :-)</p>
<p><br>
</p>
<p><span style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;">However, we could prepend every action with a short word, something like:</span></p>
<p><span style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;"><br>
</span></p>
<p><span style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;"></span></p>
<div>[<b>*</b><b>Yes,*</b><b> remove it</b>]</div>
<div>[<b>*</b><b>Yes,*</b> remove it and browse references]</div>
<div>[<b>*Cancel*</b>]</div>
<div>[<b>*</b><b>Cancel*</b> but browse references]</div>
<div><br>
</div>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="_rp_T4" id="Item.MessagePartBody">I think the win32 guidelines are really interesting here. They also propose
<a href="https://docs.microsoft.com/en-us/windows/win32/uxguide/win-dialog-box#command-links" class="OWAAutoLink">
command links</a> that can be used to explain the single options in greater detail - and also, they provide a modern look :-) -, so if we had some free resources, we could also build something similar for the MorphicUIManager. Iirc the guidelines also mention
a pattern to put the Cancel button into a corner to separate it from the "main proceed actions". We could also apply this pattern. However, all of these ideas would be more complex than sticking with the current, limited possibilities ...
<div class="_rp_U4 ms-font-weight-regular ms-font-color-neutralDark rpHighlightAllClass rpHighlightBodyClass" id="Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont">
<div><font size="3" color="black"><span style="font-size:12pt"><a href="http://www.hpi.de/" target="_blank" rel="noopener noreferrer" id="LPNoLP"><font size="2"><span id="LPlnk909538"><font color="#757B80"></font></span></font></a></span></font></div>
</font></div>
</div>
</font></div>
</div>
</div>
</div>
<div class="_rp_T4" id="Item.MessagePartBody"><br>
</div>
<div class="_rp_T4" id="Item.MessagePartBody">What do you think? :-)</div>
<div class="_rp_T4" id="Item.MessagePartBody"><br>
</div>
<div class="_rp_T4" id="Item.MessagePartBody">Best,</div>
<div class="_rp_T4" id="Item.MessagePartBody">Christoph</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Mittwoch, 3. März 2021 12:17:27<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] Merge Request: removeClass.cs</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
> <span style="font-family: Calibri, Arial, Helvetica, sans-serif;font-size: 16px">Hm, but wouldn't this make the labels even longer and harder to read? </span>
<div><span style="font-family: Calibri, Arial, Helvetica, sans-serif;font-size: 16px"><br>
</span></div>
<div><span style="font-family: Calibri, Arial, Helvetica, sans-serif;font-size: 16px">Let me rephrase. The current labels are way too wordy. They should, however, start with a simple "Yes" or "No", followed by a compact explanation of what else happens when
users click the button.</span></div>
<div><span style="font-family: Calibri, Arial, Helvetica, sans-serif;font-size: 16px"><br>
</span></div>
<div><span style="font-family: Calibri, Arial, Helvetica, sans-serif;font-size: 16px">Given that the title reads "Remove class", the buttons could be:</span></div>
<div><span style="font-family: Calibri, Arial, Helvetica, sans-serif;font-size: 16px"><br>
</span></div>
<div><span style="font-family: Calibri, Arial, Helvetica, sans-serif;font-size: 16px">[Yes]</span></div>
<div><span style="font-family: Calibri, Arial, Helvetica, sans-serif;font-size: 16px">[Yes, and browse references]</span></div>
<div><span style="font-family: Calibri, Arial, Helvetica, sans-serif;font-size: 16px">[No]</span></div>
<div><span style="font-family: Calibri, Arial, Helvetica, sans-serif;font-size: 16px">[No, but browse references]</span></div>
<div><br>
</div>
<div><span style="font-family: Calibri, Arial, Helvetica, sans-serif;font-size: 16px">Best,</span><br>
</div>
<div><span style="font-family: Calibri, Arial, Helvetica, sans-serif;font-size: 16px">Marcel</span></div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 03.03.2021 12:13:37 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div id="divtagdefaultwrapper" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif" dir="ltr">
<p>Hi Marcel,</p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: rgb(0, 0, 0);font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols">
<div name="divtagdefaultwrapper" style="font-family: Calibri,Arial,Helvetica,sans-serif;font-size: ;margin: 0">
<div>
<div class="_rp_T4" id="Item.MessagePartBody">
<div class="_rp_U4 ms-font-weight-regular ms-font-color-neutralDark rpHighlightAllClass rpHighlightBodyClass" id="Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="divtagdefaultwrapper"><span style="font-family: Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="Signature">
<div style="margin:0px"><span style="">
<div><font size="3" color="black"><span style="font-size: 12pt"><a href="http://www.hpi.de/" target="_blank" rel="noopener noreferrer" id="LPNoLP"><font size="2"><span id="LPlnk909538"><font color="#757B80"></font></span></font></a></span></font></div>
</span></div>
</div>
</span></div>
</div>
</div>
</div>
<div class="_rp_T4" id="Item.MessagePartBody"><br>
</div>
<div class="_rp_T4" id="Item.MessagePartBody">thanks for the feedback!</div>
<div class="_rp_T4" id="Item.MessagePartBody"><br>
</div>
<div class="_rp_T4" id="Item.MessagePartBody">> <span style="font-size: 12pt">Could you keep the title</span>
<div><br>
</div>
<div>Good catch! That functionality is not provided at the moment by UIManager>>#chooseFrom:.... We would need to extend the UIManager protocol first. Which I would actually dislike to do because it's finally time to implement a proper UserNotification hierarchy
instead. I'm looking really forward to tackle this one soon! :-)</div>
<div><br>
</div>
<div>> <span>and add the prefixes "yes" or "no" before the options?</span></div>
<div><span><br>
</span></div>
<div><span>Hm, but wouldn't this make the labels even longer and harder to read? Also, I intended to avoid generic yes/no labels as also recommended by the Win32 UX Guidelines [1], for example. Isn't it rather a good thing to force the user to think about the
action they are going to select before they do the wrong thing by accident?</span></div>
<div><span>(The same discussion could apply to the standard "Is it OK to discard" dialog. I have seen multiple Squeak newbies, including myself, that were remarkably confused by the semantics of this dialog. I would vote for redesigning this dialog, too, by
the way. :-))</span></div>
<div><span><br>
</span></div>
<div><span>> </span><span style="font-size: 12pt">What is your preferred way of having line breaks in the text?</span><span>
<div><br>
</div>
<div>My preferred way would be to defer this job to the UIManager implementation (more concretely: DialogWindow), finally. It just feels wrong to hack this into every domain-specific notificator, and different font sizes/styles are not honored at all at the
moment. Auto line-breaking could try to break the text into an approximately squared shape, similar to what Microsoft Windows and probably other window managers are doing. But this would require some trial- and failure or approximation logic in the UI implementation,
I guess.</div>
<div><br>
</div>
<div>> <span>What about having a single extra button for "more options" in such confirmation dialogs? Maybe like a small drop-down menu.</span></div>
<div><span><br>
</span></div>
<div><span>Rather not, if possible. :-) I use the browse options very often (except the "sorry I asked" one) and it would be a shame to spend a second click for it. And reduce visibility.</span></div>
<div><span>We could also make use of links inside the text, but this would be a downgrade as well since they do not support proper keyboard navigation. Also, clicking a link would not close the dialog automatically.</span></div>
</span></div>
<div><span><br>
</span></div>
<div>What do you think? Are four buttons really too much? :-)<span>
<div></div>
</span></div>
<div><br>
</div>
<div>Best,</div>
<div>Christoph</div>
<div><span><br>
</span></div>
<div><span>[1] <a href="https://docs.microsoft.com/en-us/windows/win32/uxguide/win-dialog-box#commit-buttons:~:text=Responding%20to%20main%20instructions" class="OWAAutoLink" id="LPlnk116325" previewremoved="true">https://docs.microsoft.com/en-us/windows/win32/uxguide/win-dialog-box#commit-buttons:~:text=Responding%20to%20main%20instructions</a></span></div>
</div>
</div>
<div><span style="font-size: 10pt;color: #808080"></span></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Mittwoch, 3. März 2021 10:18:52<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] Merge Request: removeClass.cs</span>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
<div>Hmm... tricky. :-)</div>
<div><br>
</div>
<div>Here is the current one:</div>
<img id="91ef4f60-e555-4f14-b2d7-750c9287db94" width="247" height="180" src="cid:6ab47abe-1e5c-494a-840d-b25a59cb71a5"><!-- </img> --><!-- </img> --><br>
<div class="mb_sig"></div>
<div>- Could you keep the title and add the prefixes "yes" or "no" before the options?</div>
<div>- What is your preferred way of having line breaks in the text?</div>
<div><br>
</div>
<div>Here is the current remove-selector dialog:</div>
<div><img id="0b47baed-9e4d-4864-94fb-7807c5e1f03d" width="292" height="133" src="cid:75ebde4b-b7dd-45dc-b2a6-15f70ec12617"><!-- </img> --><!-- </img> --><br>
</div>
<div>... Well, this does not scale at all. What about having a single extra button for "more options" in such confirmation dialogs? Maybe like a small drop-down menu.</div>
<div><br>
</div>
<div>[Yes] [No] <--- SPACE---> [More...]</div>
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div><br>
</div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 02.03.2021 18:26:16 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div id="divtagdefaultwrapper" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif" dir="ltr">
<p>This changeset refactors the #removeClass logic (which has been upgraded by Marcel recently) and extracts it to SystemNavigation, analogously to <span>System-ct.1221. It also refines the dialog to search for senders and subclasses of the class to remove
as we know it from #removeMessage.</span></p>
<p><span><br>
</span></p>
<p><span><img size="23381" contenttype="image/png" id="img133219" style="max-width: 99.9%; user-select: none;" contextid="img720973" tabindex="0" src="cid:21b5558d-d73d-4d2c-bcc4-eeb40f7dee49"><!-- </img> --><!-- </img> --><br>
</span></p>
<p><span><br>
</span></p>
<p><span>Please merge or give me feedback for improvements. :-)</span></p>
<p><span><br>
</span></p>
<p><span>Best,</span></p>
<p><span>Christoph</span></p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: rgb(0, 0, 0);font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols">
<div name="divtagdefaultwrapper" style="font-family: Calibri,Arial,Helvetica,sans-serif;font-size: ;margin: 0">
<div><span style="font-size: 10pt;color: #808080"></span></div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</body>
</html>