<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Yes, you're right with the <span>MyTestError, of course. Thanks for merging this and all the other recent stuff!! :-)</span></p>
<p><span><br>
</span></p>
<p><span>Best,</span></p>
<p><span>Christoph</span></p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">
<div class="x__rp_U4 x_ms-font-weight-regular x_ms-font-color-neutralDark x_rpHighlightAllClass x_rpHighlightBodyClass" id="x_Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="x_divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="x_Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont">
<div><font size="3" color="black"><span style="font-size:12pt"><a href="http://www.hpi.de/" target="_blank" rel="noopener noreferrer" id="LPNoLP"><font size="2"><span id="LPlnk909538"><font color="#757B80"></font></span></font></a></span></font></div>
</font></div>
</div>
</font></div>
</div>
</div>
</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Dienstag, 13. April 2021 18:32:45<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Trunk: Tests-nice.450.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Nicolas Cellier uploaded a new version of Tests to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Tests-nice.450.mcz">http://source.squeak.org/trunk/Tests-nice.450.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Tests-nice.450<br>
Author: nice<br>
Time: 13 April 2021, 6:32:38.49942 pm<br>
UUID: 88d71628-1262-524d-bbc0-7489c23848f3<br>
Ancestors: Tests-mt.449<br>
<br>
Revises ExceptionTests >> #testCatchingDefaultAction to work when being debugged/simulated as well. This also decouples the test from the implementation details of UnhandledWarnings. Also, Warning may be entirely disabled by a Preference, making the test fail.<br>
<br>
Removes #testHandlerFromAction from expectedFailures because it now finally works.<br>
<br>
This is same as Tests-ct.448 and Tests-ct.449, with a slightly different test, such that the defaultAction is triggered. Thanks Christoph!<br>
<br>
=============== Diff against Tests-mt.449 ===============<br>
<br>
Item was removed:<br>
- ----- Method: ExceptionTests>>expectedFailures (in category 'failures') -----<br>
- expectedFailures<br>
- "This test is a feature request. For more information on this issue visit:<br>
- <a href="http://forum.world.st/The-Inbox-Tests-TestRunner-156-mcz-tc4643910.html#a4643987">
http://forum.world.st/The-Inbox-Tests-TestRunner-156-mcz-tc4643910.html#a4643987</a><br>
- <a href="http://forum.world.st/ExceptionTests-Wrong-error-handler-tc4848699.html">
http://forum.world.st/ExceptionTests-Wrong-error-handler-tc4848699.html</a><br>
- <a href="http://forum.world.st/ExceptionTests-gt-testHandlerFromAction-fails-tc4872828.html#a4872958">
http://forum.world.st/ExceptionTests-gt-testHandlerFromAction-fails-tc4872828.html#a4872958</a>"<br>
- <br>
- ^ #(testHandlerFromAction).!<br>
<br>
Item was changed:<br>
----- Method: ExceptionTests>>testCatchingDefaultAction (in category 'tests - outer') -----<br>
testCatchingDefaultAction<br>
"The #defaultAction method is executed in the context of the signaling environment.<br>
+ It must thus be caught by the handler."<br>
+ <br>
- The defaultAction will raise an UnhandledWarning that should be caught by this handler."<br>
| result |<br>
+ result := [MyTestNotification signalForAction: [MyTestError signal: '2nd exception']]<br>
+ on: MyTestError<br>
+ do: [:ex | '2nd exception caught'].<br>
+ self assert: '2nd exception caught' equals: result.!<br>
- result := [ Warning signal: 'Warning signalled' ] on: UnhandledWarning do: [ :ex | 'UnhandledWarning caught' ].<br>
- self assert: 'UnhandledWarning caught' equals: result!<br>
<br>
Item was changed:<br>
Notification subclass: #MyTestNotification<br>
+ instanceVariableNames: 'action'<br>
- instanceVariableNames: ''<br>
classVariableNames: ''<br>
poolDictionaries: ''<br>
category: 'Tests-Exceptions'!<br>
<br>
Item was added:<br>
+ ----- Method: MyTestNotification class>>signalForAction: (in category 'signaling') -----<br>
+ signalForAction: aBlock<br>
+ <br>
+ ^ self new<br>
+ action: aBlock;<br>
+ signal!<br>
<br>
Item was added:<br>
+ ----- Method: MyTestNotification>>action (in category 'accessing') -----<br>
+ action<br>
+ <br>
+ ^ action!<br>
<br>
Item was added:<br>
+ ----- Method: MyTestNotification>>action: (in category 'accessing') -----<br>
+ action: aBlock<br>
+ <br>
+ action := aBlock!<br>
<br>
Item was added:<br>
+ ----- Method: MyTestNotification>>defaultAction (in category 'priv handling') -----<br>
+ defaultAction<br>
+ <br>
+ self action ifNotNil: [^ self action cull: self].<br>
+ <br>
+ ^ super defaultAction!<br>
<br>
<br>
</div>
</span></font>
</body>
</html>