<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Hi all,</p>
<p><br>
</p>
<p>sorry for the late reply, this must somehow have escaped my attention.</p>
<p><br>
</p>
<p>Yes, <span>Kernel-ct.1363 depends on <span>Kernel-ct.1362 and (hopefully?) improves the understandability of the method. Eliot has requested this in the thread of Kernel-ct.1362.</span></span></p>
<p><span><span><br>
</span></span></p>
<p><span><span>> </span></span><span style="font-size:12pt">it breaks testRunSimulatedContextAtEachStep.</span><span><span></p>
<div><br>
</div>
<div>True. Blocks should indeed be supported I think. Then we need indeed "<span style="font-size:12pt">current := aBlock asContext. c</span><span style="font-size:12pt">urrent privSender: self." instead of #asContextWithSender:. Shall add a third version to
do this or does the merger want to do this? :-)</span></div>
<div><span style="font-size:12pt"><br>
</span></div>
<div><span style="font-size:12pt">Best,</span></div>
<div><span style="font-size:12pt">Christoph</span></div>
</span></span>
<p></p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Nicolas Cellier <nicolas.cellier.aka.nice@gmail.com><br>
<b>Gesendet:</b> Montag, 19. April 2021 16:29:04<br>
<b>An:</b> The general-purpose Squeak developers list<br>
<b>Betreff:</b> Re: [squeak-dev] status of inbox Kernel-ct.1363</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">I see only a minor problem with this version:<br>
<br>
it breaks testRunSimulatedContextAtEachStep.<br>
This test did profit by polymorphism of asContext to use a Context<br>
instead of a Block(Closure).<br>
But Context does no understand asContextWithSender:<br>
<br>
Maybe more a problem of the test itself than of the proposed change.<br>
<br>
<br>
Le jeu. 15 avr. 2021 à 11:52, Nicolas Cellier<br>
<nicolas.cellier.aka.nice@gmail.com> a écrit :<br>
><br>
> I mean authorship...<br>
><br>
> Le jeu. 15 avr. 2021 à 11:50, Nicolas Cellier <nicolas.cellier.aka.nice@gmail.com> a écrit :<br>
>><br>
>> With the merge commit that would make 3 commits for a single method. My plan is to cherry pick the change on top of trunk with proper comment. With our tools, ownership is preserved anyway :)<br>
>><br>
>> Le jeu. 15 avr. 2021 à 11:05, Marcel Taeumel <marcel.taeumel@hpi.de> a écrit :<br>
>>><br>
>>> Hi Nicolas,<br>
>>><br>
>>> ct.1363 depends on ct.1362, the latter being easier to review. Maybe Christoph (ct) can point us to the "request" he mentioned in the message in 1363. Yet, it looks like Eliot (indirectly) approved this already:
<a href="http://forum.world.st/The-Inbox-Kernel-ct-1362-mcz-tp5124354.html">http://forum.world.st/The-Inbox-Kernel-ct-1362-mcz-tp5124354.html</a> ..? Or at least he planned to look at this.<br>
>>><br>
>>> (Let's hope that the words "branch commit" do not hide more dependencies. Not sure what it means here.)<br>
>>><br>
>>> Best,<br>
>>> Marcel<br>
>>><br>
>>> Am 15.04.2021 10:48:09 schrieb Nicolas Cellier <nicolas.cellier.aka.nice@gmail.com>:<br>
>>><br>
>>> Hi all,<br>
>>> again a good and difficult to analyze contribution.<br>
>>> We mostly send runSimulated:contextAtEachStep: to thisContext, except<br>
>>> in one case in base image:<br>
>>><br>
>>> MessageTally tallySends: [3.14159 printString]<br>
>>><br>
>>> This is effectively broken in trunk, and repaired after applying Kernel-ct.1363.<br>
>>> Before I merge this, additional advice is welcome, this is a tough<br>
>>> subject, breaking the Debugger would be the last thing we want to do.<br>
>>><br>
>>><br>
<br>
</div>
</span></font>
</body>
</html>