<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>But let's take this as something positive and inspirative instead. :-) Do we maybe need a new tool for this? When editing a class/method, automatically display a small "under construction" icon/hint if there is already a pending patch for it in the inbox?
This might also help us to avoid future merge conflicts in a workflow that is not aligned at fast integration cycles. Just brainstorming ... :-)</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
<br>
<div style="color: rgb(0, 0, 0);">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Thiede, Christoph<br>
<b>Gesendet:</b> Freitag, 30. April 2021 19:01 Uhr<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> AW: [squeak-dev] The Trunk: Tests-nice.458.mcz</font>
<div> </div>
</div>
<div>
<meta content="text/html; charset=UTF-8">
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Hi Nicolas,</p>
<p><br>
</p>
<p>I appreciate all your work, but it would be great if you could also check the inbox before. I already had implemented equivalent tests in <span>Tests-ct.447 three months ago. Now I feel a tiny little bit nihilistic. :-)</span></p>
<p><span><br>
</span></p>
<p><span>Best,</span></p>
<p><span>Christoph</span></p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Mittwoch, 28. April 2021 18:12:10<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Trunk: Tests-nice.458.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt">
<div class="PlainText">Nicolas Cellier uploaded a new version of Tests to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Tests-nice.458.mcz" id="LPlnk946694" previewremoved="true">http://source.squeak.org/trunk/Tests-nice.458.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Tests-nice.458<br>
Author: nice<br>
Time: 28 April 2021, 6:11:51.033213 pm<br>
UUID: 13fec56a-805e-754e-bd02-8cbaa015e102<br>
Ancestors: Tests-jr.457<br>
<br>
Document the fact that becomeForward: does NOT forward identityHash of receiver anymore (since Collections-eem.885 April 2020)<br>
<br>
See #elementsForwardIdentityTo: vs #elementsForwardIdentityAndHashTo:<br>
<br>
See also <a href="http://forum.world.st/How-to-become-immediate-objects-td5114931.html" id="LPlnk447572" previewremoved="true">
http://forum.world.st/How-to-become-immediate-objects-td5114931.html</a>
<div id="LPBorder_GT_16198024269540.22494579770442846" style="margin-bottom: 20px; overflow: auto; width: 100%; text-indent: 0px;">
<table id="LPContainer_16198024269520.3386565253549074" role="presentation" cellspacing="0" style="width: 90%; background-color: rgb(255, 255, 255); position: relative; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top: 1px dotted rgb(200, 200, 200); border-bottom: 1px dotted rgb(200, 200, 200);">
<tbody>
<tr valign="top" style="border-spacing: 0px;">
<td id="TextCell_16198024269530.9528077653614659" colspan="2" style="vertical-align: top; position: relative; padding: 0px; display: table-cell;">
<div id="LPRemovePreviewContainer_16198024269530.4541009447541682"></div>
<div id="LPTitle_16198024269530.31207618498725087" style="top: 0px; color: rgb(36, 96, 118); font-weight: 400; font-size: 21px; font-family: wf_segoe-ui_light, "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; line-height: 21px;">
<a id="LPUrlAnchor_16198024269530.4960325086143289" href="http://forum.world.st/How-to-become-immediate-objects-td5114931.html" target="_blank" style="text-decoration: none;">Squeak - Dev - How to become immediate objects? :-)</a></div>
<div id="LPMetadata_16198024269530.8940901560650483" style="margin: 10px 0px 16px; color: rgb(102, 102, 102); font-weight: 400; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 14px;">
forum.world.st</div>
<div id="LPDescription_16198024269540.7625221429261773" style="display: block; color: rgb(102, 102, 102); font-weight: 400; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 20px; max-height: 100px; overflow: hidden;">
How to become immediate objects? :-). Hi, all! I suppose that since ModificationForbidden and read-only objects, the following is no longer possible: MyExternalResource allInstancesDo: [:resource...</div>
</td>
</tr>
</tbody>
</table>
</div>
<br>
<br>
<br>
=============== Diff against Tests-jr.457 ===============<br>
<br>
Item was changed:<br>
----- Method: BecomeTest>>testBecomeForward (in category 'tests') -----<br>
testBecomeForward<br>
"Test the forward become."<br>
| a b c d |<br>
<br>
a := 'ab' copy.<br>
b := 'cd' copy.<br>
+ c := Array with: a.<br>
- c := a.<br>
d := b.<br>
<br>
a becomeForward: b.<br>
<br>
self <br>
assert: a = 'cd';<br>
assert: b = 'cd';<br>
+ assert: a == b;<br>
+ assert: c first == b;<br>
+ assert: d == b.<br>
- assert: c = 'cd';<br>
- assert: d = 'cd'.<br>
<br>
- <br>
!<br>
<br>
Item was added:<br>
+ ----- Method: BecomeTest>>testBecomeForwardCopyIdentityHash (in category 'tests') -----<br>
+ testBecomeForwardCopyIdentityHash<br>
+ "Check that<br>
+ 1. the argument to becomeForward: is modified to have the receiver's identity hash.<br>
+ 2. the receiver's identity hash is unchanged."<br>
+ <br>
+ | a b ha |<br>
+ <br>
+ a := 'ab' copy.<br>
+ b := 'cd' copy.<br>
+ ha := a identityHash.<br>
+ <br>
+ a becomeForward: b copyHash: true.<br>
+ <br>
+ self <br>
+ assert: a identityHash = ha;<br>
+ assert: b identityHash = ha.<br>
+ <br>
+ !<br>
<br>
Item was changed:<br>
----- Method: BecomeTest>>testBecomeForwardDontCopyIdentityHash (in category 'tests') -----<br>
testBecomeForwardDontCopyIdentityHash<br>
"Check that<br>
1. the argument to becomeForward: is NOT modified to have the receiver's identity hash.<br>
+ 2. the receiver's identity hash is changed."<br>
- 2. the receiver's identity hash is unchanged."<br>
<br>
| a b hb |<br>
<br>
a := 'ab' copy.<br>
b := 'cd' copy.<br>
hb := b identityHash.<br>
<br>
a becomeForward: b copyHash: false.<br>
<br>
self <br>
assert: a identityHash = hb;<br>
assert: b identityHash = hb.<br>
<br>
!<br>
<br>
Item was changed:<br>
----- Method: BecomeTest>>testBecomeForwardIdentityHash (in category 'tests') -----<br>
testBecomeForwardIdentityHash<br>
+ "Document that the receiver hash is changed, but the argument hash is unchanged.<br>
+ (a becomeForward: b) has thus same effect as (a becomeForward: b copyHash: false)"<br>
- "Check that<br>
- 1. the argument to becomeForward: is modified to have the receiver's identity hash.<br>
- 2. the receiver's identity hash is unchanged."<br>
<br>
+ | a b hb |<br>
- | a b ha |<br>
<br>
a := 'ab' copy.<br>
b := 'cd' copy.<br>
+ hb := b identityHash.<br>
- ha := a identityHash.<br>
<br>
a becomeForward: b.<br>
<br>
self <br>
+ assert: a identityHash = hb;<br>
+ assert: b identityHash = hb.<br>
- assert: a identityHash = ha;<br>
- assert: b identityHash = ha.<br>
<br>
!<br>
<br>
<br>
</div>
</span></font></div>
</div>
</div>
</body>
</html>