<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Hi Nicolas,</p>
<p><br>
</p>
<p>I appreciate all your work, but it would be great if you could also check the inbox before. I already had implemented equivalent tests in <span>Tests-ct.447 three months ago. Now I feel a tiny little bit nihilistic. :-)</span></p>
<p><span><br>
</span></p>
<p><span>Best,</span></p>
<p><span>Christoph</span></p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Mittwoch, 28. April 2021 18:12:10<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Trunk: Tests-nice.458.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Nicolas Cellier uploaded a new version of Tests to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Tests-nice.458.mcz">http://source.squeak.org/trunk/Tests-nice.458.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Tests-nice.458<br>
Author: nice<br>
Time: 28 April 2021, 6:11:51.033213 pm<br>
UUID: 13fec56a-805e-754e-bd02-8cbaa015e102<br>
Ancestors: Tests-jr.457<br>
<br>
Document the fact that becomeForward: does NOT forward identityHash of receiver anymore (since Collections-eem.885 April 2020)<br>
<br>
See #elementsForwardIdentityTo: vs #elementsForwardIdentityAndHashTo:<br>
<br>
See also <a href="http://forum.world.st/How-to-become-immediate-objects-td5114931.html">
http://forum.world.st/How-to-become-immediate-objects-td5114931.html</a><br>
<br>
=============== Diff against Tests-jr.457 ===============<br>
<br>
Item was changed:<br>
----- Method: BecomeTest>>testBecomeForward (in category 'tests') -----<br>
testBecomeForward<br>
"Test the forward become."<br>
| a b c d |<br>
<br>
a := 'ab' copy.<br>
b := 'cd' copy.<br>
+ c := Array with: a.<br>
- c := a.<br>
d := b.<br>
<br>
a becomeForward: b.<br>
<br>
self <br>
assert: a = 'cd';<br>
assert: b = 'cd';<br>
+ assert: a == b;<br>
+ assert: c first == b;<br>
+ assert: d == b.<br>
- assert: c = 'cd';<br>
- assert: d = 'cd'.<br>
<br>
- <br>
!<br>
<br>
Item was added:<br>
+ ----- Method: BecomeTest>>testBecomeForwardCopyIdentityHash (in category 'tests') -----<br>
+ testBecomeForwardCopyIdentityHash<br>
+ "Check that<br>
+ 1. the argument to becomeForward: is modified to have the receiver's identity hash.<br>
+ 2. the receiver's identity hash is unchanged."<br>
+ <br>
+ | a b ha |<br>
+ <br>
+ a := 'ab' copy.<br>
+ b := 'cd' copy.<br>
+ ha := a identityHash.<br>
+ <br>
+ a becomeForward: b copyHash: true.<br>
+ <br>
+ self <br>
+ assert: a identityHash = ha;<br>
+ assert: b identityHash = ha.<br>
+ <br>
+ !<br>
<br>
Item was changed:<br>
----- Method: BecomeTest>>testBecomeForwardDontCopyIdentityHash (in category 'tests') -----<br>
testBecomeForwardDontCopyIdentityHash<br>
"Check that<br>
1. the argument to becomeForward: is NOT modified to have the receiver's identity hash.<br>
+ 2. the receiver's identity hash is changed."<br>
- 2. the receiver's identity hash is unchanged."<br>
<br>
| a b hb |<br>
<br>
a := 'ab' copy.<br>
b := 'cd' copy.<br>
hb := b identityHash.<br>
<br>
a becomeForward: b copyHash: false.<br>
<br>
self <br>
assert: a identityHash = hb;<br>
assert: b identityHash = hb.<br>
<br>
!<br>
<br>
Item was changed:<br>
----- Method: BecomeTest>>testBecomeForwardIdentityHash (in category 'tests') -----<br>
testBecomeForwardIdentityHash<br>
+ "Document that the receiver hash is changed, but the argument hash is unchanged.<br>
+ (a becomeForward: b) has thus same effect as (a becomeForward: b copyHash: false)"<br>
- "Check that<br>
- 1. the argument to becomeForward: is modified to have the receiver's identity hash.<br>
- 2. the receiver's identity hash is unchanged."<br>
<br>
+ | a b hb |<br>
- | a b ha |<br>
<br>
a := 'ab' copy.<br>
b := 'cd' copy.<br>
+ hb := b identityHash.<br>
- ha := a identityHash.<br>
<br>
a becomeForward: b.<br>
<br>
self <br>
+ assert: a identityHash = hb;<br>
+ assert: b identityHash = hb.<br>
- assert: a identityHash = ha;<br>
- assert: b identityHash = ha.<br>
<br>
!<br>
<br>
<br>
</div>
</span></font>
</body>
</html>