<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 21, 2021 at 11:58 PM <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Marcel Taeumel uploaded a new version of Tools to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Tools-mt.1058.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/trunk/Tools-mt.1058.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Tools-mt.1058<br>
Author: mt<br>
Time: 22 June 2021, 8:58:40.213448 am<br>
UUID: dd77c5e8-ea36-4e94-9022-de53acef15d2<br>
Ancestors: Tools-eem.1057<br>
<br>
Fixes missing "references to binding" entry in DictionaryInspector menu.<br></blockquote><div><br></div><div class="gmail_default" style="font-size:small">Thanks Marcel!</div><div class="gmail_default" style="font-size:small"></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<br>
The bug was that there are bindings other than (sub-)instances of Binding, even regular Associations. Well, #isVariableBinding is older than Environment's Binding hierarchy. Not sure whether even Undeclared should hold instances of Binding.<br>
<br>
See <a href="http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-June/215860.html" rel="noreferrer" target="_blank">http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-June/215860.html</a><br>
<br>
=============== Diff against Tools-eem.1057 ===============<br>
<br>
Item was changed:<br>
  ----- Method: DictionaryInspector>>isBindingSelected (in category 'bindings') -----<br>
  isBindingSelected<br>
        "Whether the currently selection association is a binding to a class or global."<br>
<br>
        ^ self selectedKey ifNil: [false] ifNotNil: [:key |<br>
+               (self object associationAt: key) isVariableBinding]!<br>
-               (self object associationAt: key) isKindOf: Binding]!<br>
<br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div></div>