<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Dave, hi all!<div class="mb_sig"></div>
<div><br></div><div>There was an update issue because a class definition will always be loaded before the updated methods, which meant that "DateAndTime now" stopped working after the classVar <span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">InitializeFromPrimitive was removed, which was a problem because it apparently required during code loading.</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Using the update map (i.e. Monticello Configuration), I could solve this issue by first changing "DateAndTime class >> now" to not use </span><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">InitializeFromPrimitive any longer.</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">So, there is no bigger issue here. Just an unexpected side effect with the MC code loading mechanism.</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Best,</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Marcel</span></div><blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 03.07.2021 23:38:46 schrieb commits@source.squeak.org <commits@source.squeak.org>:</p><div style="font-family:Arial,Helvetica,sans-serif">David T. Lewis uploaded a new version of Chronology-Core to project The Trunk:<br>http://source.squeak.org/trunk/Chronology-Core-dtl.67.mcz<br><br>==================== Summary ====================<br><br>Name: Chronology-Core-dtl.67<br>Author: dtl<br>Time: 3 July 2021, 5:38:37.488688 pm<br>UUID: 142336d9-cfb5-476e-ba15-a8daf9aad710<br>Ancestors: Chronology-Core-dtl.66<br><br>Cruft removal. DateAndTime no longer needs to be in the startUp list. The canInitializeFromPrimitive workaround is no longer needed. Do not use the no-argument call to primitiveUtcWithOffset, which works fine but is easier to understand in the image if we always use a single primitive interface.<br><br>=============== Diff against Chronology-Core-dtl.66 ===============<br><br>Item was changed:<br> Magnitude subclass: #DateAndTime<br> instanceVariableNames: 'utcMicroseconds localOffsetSeconds'<br>+ classVariableNames: 'AutomaticTimezone ClockProvider LocalTimeZone PosixEpochJulianDays'<br>- classVariableNames: 'AutomaticTimezone ClockProvider InitializeFromPrimitive LocalTimeZone PosixEpochJulianDays'<br> poolDictionaries: 'ChronologyConstants'<br> category: 'Chronology-Core'!<br> <br> !DateAndTime commentStamp: 'dtl 3/12/2016 10:32' prior: 0!<br> I represent a point in UTC time as defined by ISO 8601. I have zero duration.<br> <br> My implementation uses variables utcMicroseconds and localOffsetSeconds. This represents time magnitude as elapsed microseconds since the Posix epoch, with localOffsetSeconds representing local offset from UTC. The magnitude is used for comparison and duration calculations, and the local offset is used for displaying this magnitude in the context of a local time zone.<br> <br> The implementation ignores leap seconds, which are adjustments made to maintain earth rotational clock time in synchronization with elapsed seconds.<br> <br> DateAndTime class>>now will use #primitiveUtcWithOffset to obtain current time in UTC microseconds with current local offset in seconds. The primitive provides an atomic query for UTC time and local offset as measured by the OS platform. If primitiveUtcWithOffset is not available, the traditional implementation is used, which relies on a primitive for microseconds in the local time zone and derives UTC based on the TimeZone setting.<br> !<br><br>Item was removed:<br>- ----- Method: DateAndTime class>>canInitializeFromPrimitive (in category 'system startup') -----<br>- canInitializeFromPrimitive<br>- "Some implementations of primitiveUtcWithOffset do not support passing the<br>- DateAndTime instance as a parameter to the primitive."<br>- <br>- ^self basicNew initializeFromPrimitive utcMicroseconds notNil!<br><br>Item was changed:<br> ----- Method: DateAndTime class>>initialize (in category 'initialize-release') -----<br> initialize<br> <br> ClockProvider := Time.<br>+ PosixEpochJulianDays := 2440588.!<br>- PosixEpochJulianDays := 2440588.<br>- InitializeFromPrimitive := self canInitializeFromPrimitive.<br>- Smalltalk addToStartUpList: self.<br>- self startUp: true<br>- !<br><br>Item was changed:<br> ----- Method: DateAndTime class>>now (in category 'ansi protocol') -----<br> now<br> "Answer time now as reported by #primitiveUtcWithOffset. If the primitive is not<br> available, answer the Posix epoch GMT."<br> <br> self automaticTimezone<br>+ ifTrue: [ ^ self basicNew initializeFromPrimitive ]<br>- ifTrue: [ InitializeFromPrimitive<br>- ifTrue: [ ^ self basicNew initializeFromPrimitive ]<br>- ifFalse: [ | timeArray |<br>- timeArray := Time posixMicrosecondClockWithOffset.<br>- ^ self utcMicroseconds: timeArray first offset: timeArray second ] ]<br> ifFalse: [ | timeArray |<br> timeArray := Time posixMicrosecondClockWithOffset.<br> ^ self utcMicroseconds: timeArray first offset: self localOffsetSeconds ]<br> !<br><br>Item was removed:<br>- ----- Method: DateAndTime class>>startUp: (in category 'system startup') -----<br>- startUp: startingAfresh<br>- "Set local timezone"<br>- startingAfresh<br>- ifTrue: [InitializeFromPrimitive := self canInitializeFromPrimitive.<br>- Time initialize. "set LastClockTick to 0".<br>- self now]!<br><br>Item was changed:<br> ----- Method: Time class>>posixMicrosecondClockWithOffset (in category 'clock') -----<br> posixMicrosecondClockWithOffset<br> "Answer an array with local microseconds since the Posix epoch and the<br> current seconds offset from GMT in the local time zone."<br> <br> | array posixUtcValue |<br>+ array := self primPosixMicrosecondClockWithOffset: (Array new: 2).<br>- array := self primPosixMicrosecondClockWithOffset.<br> posixUtcValue := array at: 1.<br> (self updateTimeZoneCacheAt: posixUtcValue) ifTrue: [ "Time zone may have changed: fetch again."<br> self primPosixMicrosecondClockWithOffset: array.<br> posixUtcValue := array at: 1 ].<br> ClockPolicy caseOf: {<br> [#acceptPlatformTime] -> [^ array] .<br> [#monotonicAllowDuplicates] -> [<br> posixUtcValue > LastClockTick<br> ifTrue: [LastClockTick := posixUtcValue]<br> ifFalse: [array at: 1 put: LastClockTick]] .<br> [#monotonicForceMicrosecondIncrement] -> [<br> posixUtcValue > LastClockTick<br> ifTrue: [LastClockTick := posixUtcValue]<br> ifFalse: [LastClockTick := LastClockTick + 1. "add one microsecond"<br> array at: 1 put: LastClockTick]] .<br> [#monotonicForceNanosecondIncrement] -> [<br> posixUtcValue > LastClockTick<br> ifTrue: [LastClockTick := posixUtcValue]<br> ifFalse: [LastClockTick := LastClockTick + (1 / 1000). "add one nanosecond"<br> array at: 1 put: LastClockTick]]<br> } otherwise: [].<br> ^array!<br><br>Item was removed:<br>- ----- Method: Time class>>primPosixMicrosecondClockWithOffset (in category 'private') -----<br>- primPosixMicrosecondClockWithOffset<br>- "Answer an array with UTC microseconds since the Posix epoch and the<br>- current seconds offset from GMT in the local time zone. If the primitive is<br>- not available, then answer the time and offset of Posix epoch GMT. This enables<br>- the image to continue running in the absence of #primitiveUtcWithOffset, thus<br>- avoiding the need to fallback code based on the earlier local microsecond clock<br>- mechanism."<br>- <br>- <primitive: 'primitiveutcwithoffset'=""><br>- ^{0. 0}!<br><br>Item was changed:<br>+ ----- Method: Time class>>primPosixMicrosecondClockWithOffset: (in category 'clock') -----<br>- ----- Method: Time class>>primPosixMicrosecondClockWithOffset: (in category 'private') -----<br> primPosixMicrosecondClockWithOffset: arrayOrObjectWithTwoSlots<br> "Answer an array with UTC microseconds since the Posix epoch and the<br> current seconds offset from GMT in the local time zone. If the primitive is<br> not available, then answer the time and offset of Posix epoch GMT. This enables<br> the image to continue running in the absence of #primitiveUtcWithOffset, thus<br> avoiding the need to fallback code based on the earlier local microsecond clock<br> mechanism.<br> <br> The parameter may be a two element array, or an object whose first two instance<br> variables are expected to be UTC microseconds and seconds offset from GMT."<br> <br> <primitive: 'primitiveutcwithoffset'=""><br> <br> (arrayOrObjectWithTwoSlots instVarAt: 1)<br> ifNil: [arrayOrObjectWithTwoSlots instVarAt: 1 put: 0].<br> (arrayOrObjectWithTwoSlots instVarAt: 2)<br> ifNil: [arrayOrObjectWithTwoSlots instVarAt: 2 put: 0]!<br><br>Item was changed:<br>+ (PackageInfo named: 'Chronology-Core') postscript: 'Smalltalk removeFromStartUpList: DateAndTime'!<br>- (PackageInfo named: 'Chronology-Core') postscript: '"Make sure UpdateVMTimeZoneCacheAt of Time is initialized."<br>- Time classPool at: #UpdateVMTimeZoneCacheAt put: 0.<br>- "Separated Time''s startup duties from DateAndTime."<br>- Smalltalk addToStartUpList: Time before: DateAndTime'!<br><br><br></primitive:></primitive:></div></blockquote></div>