<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
        {margin-top:0;
        margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>In this case, the shadows were actually kind of intended because the field blocks should never refer to the receiver instance ...</p>
<p>Not sure how we can ensure this otherwise. At least we have tests for the "copy expression" feature which depends on this invariant.</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Mittwoch, 8. September 2021 05:38:07<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Trunk: Tools-eem.1064.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Eliot Miranda uploaded a new version of Tools to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Tools-eem.1064.mcz">http://source.squeak.org/trunk/Tools-eem.1064.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Tools-eem.1064<br>
Author: eem<br>
Time: 7 September 2021, 8:38:04.292324 pm<br>
UUID: 2544ee88-6941-42d9-bc13-e3b384fb4708<br>
Ancestors: Tools-ul.1063<br>
<br>
Fix some shadowed inst var warnings in the inspector; 'object' is an inst var name but was used as a block arg name in a few methods.<br>
<br>
=============== Diff against Tools-ul.1063 ===============<br>
<br>
Item was changed:<br>
  ----- Method: BasicInspector>>fieldSelf (in category 'fields') -----<br>
  fieldSelf<br>
  <br>
         ^ (self newFieldForType: #self key: #self)<br>
                 name: 'self'; emphasizeName;<br>
+                valueGetter: [:obj | self basicObjectPrintString]; printValueAsIs;<br>
-                valueGetter: [:object | self basicObjectPrintString]; printValueAsIs;<br>
                 valueGetterExpression: 'self';<br>
+                valueSetter: [:obj :value | self object: value];  "Switch to another object-under-inspection."<br>
-                valueSetter: [:object :value | self object: value];  "Switch to another object-under-inspection."<br>
                 yourself!<br>
<br>
Item was changed:<br>
  ----- Method: BasicInspector>>streamInstanceVariablesOn: (in category 'fields - streaming') -----<br>
  streamInstanceVariablesOn: aStream<br>
  <br>
         | attributesForInstVars |<br>
         attributesForInstVars :=  (UserInterfaceTheme current get: #instVar for: #SHTextStylerST80) ifNil: [#()].<br>
         <br>
         (thisContext objectClass: self object) allInstVarNames withIndexDo: [:name :index |            
<br>
                 aStream nextPut: ((self newFieldForType: #instVar key: name)<br>
                         name: name; styleName: attributesForInstVars;<br>
+                        valueGetter: [:obj | thisContext object: obj instVarAt: index];<br>
-                        valueGetter: [:object | thisContext object: object instVarAt: index];<br>
                         valueGetterExpression: ('thisContext object: {1} instVarAt: {2}' format: { 'self'. index });
<br>
+                        valueSetter: [:obj :value | thisContext object: obj instVarAt: index put: value];<br>
-                        valueSetter: [:object :value | thisContext object: object instVarAt: index put: value];<br>
                         yourself)].!<br>
<br>
Item was changed:<br>
  ----- Method: Inspector>>fieldAllInstVars (in category 'fields') -----<br>
  fieldAllInstVars<br>
  <br>
         ^ (self newFieldForType: #all key: #allInstVars)<br>
                 name: self allInstVarsTranslated; emphasizeName;<br>
+                valueGetter: [:obj | obj longPrintString]; printValueAsIs;<br>
-                valueGetter: [:object | object longPrintString]; printValueAsIs;<br>
                 yourself!<br>
<br>
Item was changed:<br>
  ----- Method: Inspector>>fieldSelf (in category 'fields') -----<br>
  fieldSelf<br>
  <br>
         ^ (self newFieldForType: #self key: #self)<br>
                 name: 'self'; styleName: ((UserInterfaceTheme current get: #self for: #SHTextStylerST80) ifNil: [#()]);<br>
+                valueGetter: [:obj | obj];<br>
+                valueSetter: [:obj :value | self object: value]; "Switch to another object-under-inspection."<br>
-                valueGetter: [:object | object];<br>
-                valueSetter: [:object :value | self object: value]; "Switch to another object-under-inspection."<br>
                 yourself!<br>
<br>
Item was changed:<br>
  ----- Method: Inspector>>streamInstanceVariablesOn: (in category 'fields - streaming') -----<br>
  streamInstanceVariablesOn: aStream<br>
  <br>
         | attributesForInstVars |<br>
         attributesForInstVars :=  (UserInterfaceTheme current get: #instVar for: #SHTextStylerST80) ifNil: [#()].<br>
         <br>
         (self object perform: #class "do not inline send of #class, receiver could be a proxy") allInstVarNames withIndexDo: [:name :index |           
<br>
                 aStream nextPut: ((self newFieldForType: #instVar key: name)<br>
                         name: name; styleName: attributesForInstVars;<br>
+                        valueGetter: [:obj | obj instVarNamed: name];<br>
+                        valueSetter: [:obj :value | obj instVarNamed: name put: value];<br>
-                        valueGetter: [:object | object instVarNamed: name];<br>
-                        valueSetter: [:object :value | object instVarNamed: name put: value];<br>
                         yourself)].!<br>
<br>
<br>
</div>
</span></font>
</body>
</html>