<body><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Tobias --<div><br></div><div>> <span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Please don't deprecate stuff unnecessarily :)</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif"><span style="font-size: 13px">Why do you think that #strictlyPositive is necessary? Well, we can at least leave it as a convenience method. I was just curious why we would not want to use it in SmallInteger. I suspected performance ...</span></span></div><div><span style="font-family: Arial, Helvetica, sans-serif"><span style="font-size: 13px"><br></span></span></div><div><span style="font-family: Arial, Helvetica, sans-serif"><span style="font-size: 13px">Best,</span></span></div><div><span style="font-family: Arial, Helvetica, sans-serif"><span style="font-size: 13px">Marcel</span></span></div><div class="mb_sig"></div><blockquote class='history_container' type='cite' style='border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;'>
<p style='color: #AAAAAA; margin-top: 10px;'>Am 10.09.2021 17:11:12 schrieb Tobias Pape <das.linux@gmx.de>:</p><div style='font-family:Arial,Helvetica,sans-serif'><br><br>> On 10. Sep 2021, at 16:05, Marcel Taeumel <marcel.taeumel@hpi.de> wrote:<br>> <br>> Hi Levente --<br>> <br>> > removed Integer >> #isPowerOfTwo because it was not used: all subclasses implement that method<br>> <br>> Hmm... what about removing the one in SmallInteger instead bc. its implementation is not that special. #strictlyPositive might be deprecated as well, looking at its 4 senders. Maybe just replace those few integer uses with "> 0" instead. <br>> <br>I like strictlyPositive. Not just because it's a unary message.<br>Please don't deprecate stuff unnecessarily :)<br><br>Best regards<br> -Tobias<br><br>> Best,<br>> Marcel<br>>> Am 10.09.2021 15:56:05 schrieb commits@source.squeak.org <commits@source.squeak.org>:<br>>> <br>>> Levente Uzonyi uploaded a new version of Kernel to project The Inbox:<br>>> http://source.squeak.org/inbox/Kernel-ul.1411.mcz<br>>> <br>>> ==================== Summary ====================<br>>> <br>>> Name: Kernel-ul.1411<br>>> Author: ul<br>>> Time: 10 September 2021, 3:16:23.23175 pm<br>>> UUID: 9d7f74f9-52b9-4a1c-babf-60de439244bb<br>>> Ancestors: Kernel-ul.1409<br>>> <br>>> - let all Numbers respond to #isPowerOfTwo.<br>>> - removed Integer >> #isPowerOfTwo because it was not used: all subclasses implement that method<br>>> <br>>> =============== Diff against Kernel-ul.1409 ===============<br>>> <br>>> Item was added:<br>>> + ----- Method: Fraction>>isPowerOfTwo (in category 'testing') -----<br>>> + isPowerOfTwo<br>>> + "Return true if the receiver is an integral power of two."<br>>> + <br>>> + ^numerator = 1 and: [ denominator isPowerOfTwo ]!<br>>> <br>>> Item was removed:<br>>> - ----- Method: Integer>>isPowerOfTwo (in category 'testing') -----<br>>> - isPowerOfTwo<br>>> - "Return true if the receiver is an integral power of two."<br>>> - <br>>> - ^self strictlyPositive and: [ (self bitAnd: self - 1) = 0 ]!<br>>> <br>>> Item was added:<br>>> + ----- Method: Number>>isPowerOfTwo (in category 'testing') -----<br>>> + isPowerOfTwo<br>>> + "Return true if the receiver is an integral power of two."<br>>> + <br>>> + self subclassResponsibility!<br>>> <br>>> Item was added:<br>>> + ----- Method: ScaledDecimal>>isPowerOfTwo (in category 'testing') -----<br>>> + isPowerOfTwo<br>>> + "Return true if the receiver is an integral power of two."<br>>> + <br>>> + ^fraction isPowerOfTwo!<br>>> <br>>> <br>> <br><br><br><br></commits@source.squeak.org></marcel.taeumel@hpi.de></div></blockquote>
</div></body>