<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Thank you for the clarification!</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Donnerstag, 21. Oktober 2021 09:36:16<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: Morphic-ct.1787.mcz</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Christoph --
<div><br>
</div>
<div>> <span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Correct me if I am wrong, but in the second case, the event would be propagated further to the next interested parent morph.</span></div>
> <span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">In my opinion, the latter would be rather confusing in this situation.</span>
<div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br>
</span></div>
<div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Ah, right. I forgot about the dispatch. Yes, it makes sense to have this check in #mouseDown:/#keyStroke: then. Not #handles*:, because it checks its own state, not the event object's
state.</span></div>
<div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br>
</span></div>
<div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Best,</span></div>
<div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Marcel</span></div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 20.10.2021 15:57:51 schrieb christoph.thiede@student.hpi.uni-potsdam.de <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">Another argument is that an early exit in a handle method (#keyStroke: etc.) is conceptually different from returning false in a #handles... method, isn't it? Correct me if I am wrong, but in the second case,
the event would be propagated further to the next interested parent morph.<br>
<br>
In my opinion, the latter would be rather confusing in this situation. (As opposed to
<b><span style="color: #008000">Morphic</span></b>-<b><span style="color: #008000">ct</span></b>.1777.mcz where I actually wanted to enable it.)<br>
<br>
Best,<br>
Christoph<br>
<br>
<span style="color: #808080">---<br>
</span><i><span style="color: #808080">Sent from </span></i><i><u><a href="https://github.com/hpi-swa-lab/squeak-inbox-talk"><span style="color: #808080">Squeak Inbox Talk</span></a></u></i><br>
<br>
On 2021-10-20T09:09:46+02:00, marcel.taeumel@hpi.de wrote:<br>
<br>
> Hi Christoph --<br>
> <br>
> Sure, if it makes sense to you, do it. :-) Well, Morphic's #handles* methods don't scale-up too well. For short implementations of #mouseDown:/#keyStroke: etc., it makes sense to separate such conditions, though.<br>
> <br>
> Best,<br>
> Marcel<br>
> Am 19.10.2021 19:34:55 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:<br>
> Hi Marcel,<br>
> <br>
> I was trying to replicate the style from #mouseDown: & Co. Shall I also move the checks there into the relevant #handlesMouse...: selectors?<br>
> <br>
> Best,<br>
> Christoph<br>
> Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
> Gesendet: Dienstag, 19. Oktober 2021 15:39:41<br>
> An: squeak-dev<br>
> Betreff: Re: [squeak-dev] The Inbox: Morphic-ct.1787.mcz<br>
> <br>
> This check should be implemented via #handlesKeyboard:, not in #keyStroke:.<br>
> <br>
> Best,<br>
> Marcel<br>
> Am 18.10.2021 18:00:38 schrieb commits at source.squeak.org <commits at source.squeak.org>:<br>
> A new version of Morphic was added to project The Inbox:<br>
> http://source.squeak.org/inbox/Morphic-ct.1787.mcz<br>
> <br>
> ==================== Summary ====================<br>
> <br>
> Name: Morphic-ct.1787<br>
> Author: ct<br>
> Time: 18 October 2021, 6:00:19.065559 pm<br>
> UUID: 5a7cd867-c35a-bf4a-9f21-4f51eae8b612<br>
> Ancestors: Morphic-ul.1780<br>
> <br>
> Don't raise an error when pressing a key while focusing an empty scroll bar (such as the main panel in a freshly opened preference browser).<br>
> <br>
> =============== Diff against Morphic-ul.1780 ===============<br>
> <br>
> Item was changed:<br>
> ----- Method: ScrollPane>>keyStroke: (in category 'event handling') -----<br>
> keyStroke: evt<br>
> "If pane is not empty, pass the event to the last submorph,<br>
> assuming it is the most appropriate recipient (!!)"<br>
> <br>
> + scroller hasSubmorphs ifTrue:<br>
> + [scroller lastSubmorph keyStroke: evt].!<br>
> - scroller submorphs last keyStroke: evt!<br>
> <br>
> <br>
> -------------- next part --------------<br>
> An HTML attachment was scrubbed...<br>
> URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20211020/d19e6fcb/attachment.html><br>
> <br>
> </div>
</blockquote>
</div>
</div>
</body>
</html>