<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">Okay. See Morphic-mt.1799 in Trunk.<div><br></div><div>Best,</div><div>Marcel<br><div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 22.11.2021 19:22:37 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p><div style="font-family:Arial,Helvetica,sans-serif">
<div id="divtagdefaultwrapper" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif" dir="ltr">
<p>Hi Marcel,</p>
<p><br>
</p>
<p>thanks again for reviewing and merging this!</p>
<p><br>
</p>
<p>> <span>Adds and uses breadth-first search for submorph lookup because it matches the natural way widgets are organized in a window. The existing depth-first in #allMorphsDo: might take surprising paths.</span></p>
<p><span><br>
</span></p>
<p><span>I keep finding some tools where this heuristic is not yet good enough. For example, in the Monticello Browser, I would expect the package list on the left to be focused by default, but instead, the repository list on the right is focused. What would
you think about a strategy that orders all descendant morphs by their natural reading order and always chooses the left-most from the first row (#x ascending , #y ascending)? Or would you prefer to specify this information in the relevant toolbuilder methods
instead?</span></p>
<p><span><br>
</span></p>
<p><span>Best,</span></p>
<p><span>Christoph</span></p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Freitag, 19. November 2021 18:17:25<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] Merge Request: defaultFocusMorph.cs</span>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Merged.
<div><br>
</div>
<div>Revisions in SystemWindow >> #defaultFocusMorph and more tool-specific use of #defaultFocus: besides the preference browser.</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 20.10.2021 16:31:00 schrieb christoph.thiede@student.hpi.uni-potsdam.de <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">Hi all,<br>
<br>
if a new window is invoked via a keyboard gesture, with the proposed changeset, the keyboard focus is automatically passed to the new window. See SystemWindow >> #defaultFocusMorph. By default, the first keyboard-interested (sub)+morph is selected, but you
can specify a different focus holder by setting the #defaultFocusMorph property of the window or the #defaultFocus parameter of the pluggable window spec.<br>
<br>
I think this improves the keyboard workflow in Squeak a bit. For instance, it enables the following workflows:<br>
- Ctrl + 0 (search bar), type '6 * 7', Alt + o (spawn), <b>Alt + p (print it)</b><br>
- Ctrl + 3 (Tools menu), type 'browser', Enter, <b>Alt + f (find), type 'Object', Enter</b><br>
<br>
Please review and merge if you don't have any objections. Happy squeaking! :-)<br>
<br>
Best,<br>
Christoph<br>
<br>
<span style="color: #808080">---<br>
</span><i><span style="color: #808080">Sent from </span></i><i><u><a href="https://github.com/hpi-swa-lab/squeak-inbox-talk"><span style="color: #808080">Squeak Inbox Talk</span></a></u></i>
</div>
</blockquote>
</div>
</div>
</div></blockquote></div></div>