<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div dir="ltr"><br></div><div dir="ltr"><br><blockquote type="cite">On Nov 29, 2021, at 8:52 AM, Marcel Taeumel <marcel.taeumel@hpi.de> wrote:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr"><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Christoph --<div><br></div><div>This looks rather like a regression fix that is long overdue. See ParagraphEditor >> #makeProjektLink.</div></div></div></blockquote><div><br></div>That’s right. I was editing help code and… bang! an MNU for <span style="font-family: Arial; font-size: 10pt;">makeProjectLink</span>, which was there for ParagraphEditor, so I copied it over.<div><font face="Arial" size="2"><br></font><blockquote type="cite"><div dir="ltr"><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr"><div><br></div><div>Other than that: You are right. Coupling needs to decreased! Code needs to be documented! Context menus are crowded already! :-) So, let's work on that.</div><div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 27.11.2021 20:34:20 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p><div style="font-family:Arial,Helvetica,sans-serif">
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif">
<p>Hi Eliot,</p>
<p><br>
</p>
<p>doesn't this increase the coupling between editing and projects management even more?</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Donnerstag, 11. November 2021 18:11:49<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Trunk: Morphic-eem.1790.mcz</span>
<div> </div>
</div>
</div>
<span style="font-size: 10pt"><span style="font-size: 10pt">
<div class="PlainText">Eliot Miranda uploaded a new version of Morphic to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Morphic-eem.1790.mcz">http://source.squeak.org/trunk/Morphic-eem.1790.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Morphic-eem.1790<br>
Author: eem<br>
Time: 11 November 2021, 9:11:46.040429 am<br>
UUID: fcf3f31e-f485-42d4-8863-29f2e3c2afed<br>
Ancestors: Morphic-eem.1789<br>
<br>
Implement "make project link (P)" for the Morphic help editor.<br>
<br>
=============== Diff against Morphic-eem.1789 ===============<br>
<br>
Item was added:<br>
+ ----- Method: PluggableTextMorph>>makeProjectLink (in category 'menu commands') -----<br>
+ makeProjectLink<br>
+ self handleEdit: [textMorph editor makeProjectLink]!<br>
<br>
Item was added:<br>
+ ----- Method: TextEditor>>makeProjectLink (in category 'menu commands') -----<br>
+ makeProjectLink<br>
+ | attribute thisSel |<br>
+ <br>
+ thisSel := self selection.<br>
+ <br>
+ attribute := TextSqkProjectLink new. <br>
+ thisSel := attribute analyze: self selection asString.<br>
+ <br>
+ thisSel ifNil: [^ true].<br>
+ self replaceSelectionWith: (thisSel asText addAttribute: attribute).<br>
+ ^ true!<br>
<br>
<br>
</div>
</span></span>
</div></blockquote></div><span></span><br></div></blockquote></div></body></html>