<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>The only real change in this version was the addition of this line:</p>
<p><br>
</p>
<p></p>
<div>+ widget updateColumns.</div>
<div><br>
</div>
I am sorry, I had forgotten that prettyPrintWithDiffs was turned on in my image. Immediately turning it off now ... Maybe we should have something like an .editorconfig for every Monticello package. :-)
<p></p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Donnerstag, 2. Dezember 2021 21:43:22<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Trunk: ToolBuilder-Morphic-ct.281.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Christoph Thiede uploaded a new version of ToolBuilder-Morphic to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/ToolBuilder-Morphic-ct.281.mcz">http://source.squeak.org/trunk/ToolBuilder-Morphic-ct.281.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: ToolBuilder-Morphic-ct.281<br>
Author: ct<br>
Time: 2 December 2021, 9:42:51.429746 pm<br>
UUID: 3714f3d3-013d-644c-ac49-363076421856<br>
Ancestors: ToolBuilder-Morphic-mt.280<br>
<br>
Fixes a layout slip for multi-column lists with #shrinkWrap'ped column resizings. Update the column widths eagerly to avoid an incorrect default layout when the list enters the world.<br>
<br>
The original bug can be reproduced by searching in SqueakInboxTalk for the conversation "PSA | Slow .changes access | Real-time protection in Windows Defender".<br>
<br>
=============== Diff against ToolBuilder-Morphic-mt.280 ===============<br>
<br>
Item was changed:<br>
----- Method: MorphicToolBuilder>>buildPluggableMultiColumnList: (in category 'widgets required') -----<br>
buildPluggableMultiColumnList: aSpec<br>
+ <br>
| widget listClass getIndex setIndex |<br>
+ aSpec getSelected<br>
+ ifNil: [<br>
+ listClass := self multiColumnListClass.<br>
+ getIndex := aSpec getIndex.<br>
+ setIndex := aSpec setIndex]<br>
+ ifNotNil: [<br>
+ listClass := self multiColumnListByItemClass.<br>
+ getIndex := aSpec getSelected.<br>
+ setIndex := aSpec setSelected].<br>
+ widget := listClass<br>
+ on: aSpec model<br>
+ list: aSpec list<br>
+ selected: getIndex<br>
+ changeSelected: setIndex<br>
+ menu: aSpec menu<br>
+ keystroke: aSpec keyPress.<br>
- aSpec getSelected ifNil:[<br>
- listClass := self multiColumnListClass.<br>
- getIndex := aSpec getIndex.<br>
- setIndex := aSpec setIndex.<br>
- ] ifNotNil: [<br>
- listClass := self multiColumnListByItemClass.<br>
- getIndex := aSpec getSelected.<br>
- setIndex := aSpec setSelected.<br>
- ].<br>
- widget := listClass on: aSpec model<br>
- list: aSpec list<br>
- selected: getIndex<br>
- changeSelected: setIndex<br>
- menu: aSpec menu<br>
- keystroke: aSpec keyPress.<br>
self register: widget id: aSpec name.<br>
<br>
+ " widget<br>
- " widget<br>
dragItemSelector: aSpec dragItem;<br>
dropItemSelector: aSpec dropItem;<br>
wantsDropSelector: aSpec dropAccept;<br>
dragStartedSelector: aSpec dragStarted."<br>
+ <br>
- <br>
self setListPropertiesFor: widget spec: aSpec.<br>
<br>
"Be sure to enable the horizontal scrollbar if not all columns are #spaceFill."<br>
+ (aSpec columnResizings anySatisfy: [:sym | sym ~= #spaceFill]) ifTrue: [widget hScrollBarPolicy: #whenNeeded].<br>
+ <br>
- (aSpec columnResizings anySatisfy: [:sym | sym ~= #spaceFill])<br>
- ifTrue: [widget hScrollBarPolicy: #whenNeeded].<br>
- <br>
widget<br>
cellPositioningForColumns: aSpec itemAlignments;<br>
cellInsetForColumns: aSpec itemPaddings;<br>
hResizingForColumns: aSpec columnResizings;<br>
spaceFillWeightForColumns: aSpec columnSpaceFillWeights.<br>
+ widget updateColumns.<br>
<br>
+ ^ widget!<br>
- ^widget!<br>
<br>
<br>
</div>
</span></font>
</body>
</html>