<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Ha! Nevermind. You need the explicit blank icon if the list of changes is updated async (for > 30 changes) *and* you have "colorful windows" disabled but "menu with icons" enabled. Crazy. :-)<div><br></div><div>+1 Thanks!</div><div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 15.12.2021 18:09:34 schrieb Marcel Taeumel <marcel.taeumel@hpi.de>:</p><div style="font-family:Arial,Helvetica,sans-serif"><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Christoph --<div><br></div><div>I am unable to reproduce this issue and would like that you remove that "MenuIcons blankIcon" again. I tested combinations of both "menu with icons" and "colorful windows". From the looks of it, your system needs a "rebuild menus" because your changes menu is missing an item and a bar.</div><div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div><blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 15.12.2021 18:01:54 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p><div style="font-family:Arial,Helvetica,sans-serif">
<div id="divtagdefaultwrapper" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif" dir="ltr">
<p>Hi Marcel,</p>
<p><br>
</p>
<p>I'm not talking about the "<span>menu with icons" pref. I'm talking about the "colorful windows" pref. This relationship has confused me, too. :-)</span></p>
<p><span><br>
</span></p>
<p><span>Are you unable to reproduce my screenshots or would you actually prefer the inconsistent indentations?</span></p>
<p><span><br>
</span></p>
<p><span>Best,</span></p>
<p><span>Christoph</span></p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Mittwoch, 15. Dezember 2021 17:56:01<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Trunk: Morphic-ct.1825.mcz</span>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hmm... no, it actually does. Still. I don't see a need for this patch here (before pics):
<div><br>
</div>
<div><img id="f99e1eb9-0669-4394-afec-36df45647f28" width="183" height="158" src="cid:c209ca8e-5d74-43af-b2b6-eb492909fa11"></img><!-- </img> --><br>
</div>
<div><img id="445889de-2bae-425b-94fc-d0677696ce07" width="183" height="169" src="cid:54f30b2d-f744-4a59-82f6-b788e0c7ebfb"></img><!-- </img> --><br>
</div>
<div><img id="cc2ce7ac-b6b8-47b4-9f98-e2336a7cc37a" width="164" height="189" src="cid:8db35b8a-1f1a-41e7-8b27-8de674e753cc"></img><!-- </img> --><br>
</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 15.12.2021 17:51:25 schrieb Marcel Taeumel <marcel.taeumel@hpi.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
<div><span style="font-size: 10pt">-1 </span></div>
<div><span style="font-size: 10pt"><br>
</span></div>
<div><span style="font-size: 10pt">I think that the actual issue here is that the changes list does not honor "menu with icons" preference.</span><br>
</div>
<div><span style="font-size: 10pt"><br>
</span></div>
<div><span style="font-size: 10pt">Best,</span></div>
<div><span style="font-size: 10pt">Marcel</span></div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 15.12.2021 17:49:42 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif">
<p>Before:</p>
<p><img size="9823" id="x_img462119" tabindex="0" style="max-width:99.9%" src="cid:855359cf-99d4-4181-ad74-887e9f89ed9f"></img><!-- </img> --><br>
</p>
<p><br>
</p>
<p>After:</p>
<p><img size="17327" id="x_img230974" tabindex="0" style="max-width:99.9%" src="cid:8456bbe8-3f07-494b-86ea-b01bddd35670"></img><!-- </img> --><br>
</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Mittwoch, 15. Dezember 2021 17:48:48<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Trunk: Morphic-ct.1825.mcz</span>
<div> </div>
</div>
</div>
<span style="font-size: 10pt"><span style="font-size: 10pt">
<div class="PlainText">Christoph Thiede uploaded a new version of Morphic to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Morphic-ct.1825.mcz">http://source.squeak.org/trunk/Morphic-ct.1825.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Morphic-ct.1825<br>
Author: ct<br>
Time: 15 December 2021, 5:48:39.540981 pm<br>
UUID: 51a9514e-bff7-5e42-92be-97336b8b1b8e<br>
Ancestors: Morphic-mt.1824<br>
<br>
Slightly revises appearance of the changes menu in the docking bar: Unifies the indentation of icons if the preference "colorful windows" is disabled.<br>
<br>
=============== Diff against Morphic-mt.1824 ===============<br>
<br>
Item was changed:<br>
----- Method: TheWorldMainDockingBar>>listChangesOn: (in category 'submenu - changes') -----<br>
listChangesOn: menu<br>
<br>
| fetchChangesBlock |<br>
{<br>
'Browse current change set' translated. #browseChangeSet. nil.<br>
'Browse changed methods' translated. #browseChangedMethods. nil.<br>
nil. nil. nil.<br>
'Simple Change Sorter' translated. #browseChanges. ChangeSorter.<br>
'Dual Change Sorter' translated. #browseChangesDual. DualChangeSorter.<br>
nil. nil. nil.<br>
} groupsDo: [:label :selector :modelClass |<br>
label ifNil: [menu addLine] ifNotNil: [<br>
menu addItem: [:item |<br>
item<br>
contents: label;<br>
+ icon: ((modelClass ifNotNil: [self colorIcon: modelClass basicNew windowColorToUse])<br>
+ ifNil: [MenuIcons blankIcon]);<br>
- icon: (modelClass ifNotNil: [self colorIcon: modelClass basicNew windowColorToUse]);<br>
target: self;<br>
selector: selector]] ].<br>
<br>
fetchChangesBlock := [ | latestMethodChanges latestClassChanges updateBlock |<br>
self flag: #concurrency. "mt: Is this safe enough given the current update frequency of change sets and when this code is executed?"<br>
latestMethodChanges := (Array streamContents: [:s |<br>
ChangeSet current changedMethodsDo: [:method :changeType :dateAndTime :category |<br>
s nextPut: { dateAndTime. method. changeType. category }]])<br>
sorted: [:a :b | a first >= b first].<br>
latestClassChanges := (Array streamContents: [:s |<br>
ChangeSet current changedClassesDo: [:class :changeTypes :dateAndTime :category |<br>
"We are not interested in classes whose method's did only change."<br>
changeTypes ifNotEmpty: [s nextPut: { dateAndTime. class. changeTypes. category }]]])<br>
sorted: [:a :b | a first >= b first].<br>
updateBlock := [self listMethodChanges: latestMethodChanges andClassChanges: latestClassChanges on: menu].<br>
Project current uiProcess == Processor activeProcess<br>
ifTrue: updateBlock<br>
ifFalse: [Project current addDeferredUIMessage: [<br>
menu isInWorld ifTrue: [menu lastItem delete. updateBlock value]] ]].<br>
<br>
ChangeSet current numberOfChanges <= 30<br>
ifTrue: fetchChangesBlock ifFalse: [<br>
"We have too much data to process. Do it in the background to keep the UI responsive."<br>
menu add: '... fetching changes ...' translated action: nil.<br>
menu lastItem isEnabled: false.<br>
fetchChangesBlock forkAt: Processor userBackgroundPriority].!<br>
<br>
<br>
</div>
</span></span></div>
</blockquote>
</div>
</div>
</blockquote>
</div>
</div>
</div></blockquote>
</div></div></blockquote></div>