<div dir="ltr">This one was moved to Treated because I think only #sendersOfIt needed reverted. MessageTrace already has protective overrides for #browseAllCallsOn: and browseAllImplementorsOf:.<div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Jan 9, 2022 at 6:40 PM <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Chris Muller uploaded a new version of Morphic to project The Inbox:<br>
<a href="http://source.squeak.org/inbox/Morphic-cmm.1838.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/inbox/Morphic-cmm.1838.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Morphic-cmm.1838<br>
Author: cmm<br>
Time: 9 January 2022, 6:40:28.562851 pm<br>
UUID: 44f58dc2-b94c-476a-aa46-17a4a564c65e<br>
Ancestors: Morphic-mt.1837<br>
<br>
Revert Morphic-mt.1652 because it corrupts the representation of a valid execution flow in MessageTrace and prevents spawning of independent traces.<br>
<br>
=============== Diff against Morphic-mt.1837 ===============<br>
<br>
Item was changed:<br>
----- Method: TextEditor>>browseIt (in category 'menu messages') -----<br>
browseIt<br>
"Launch a browser for the current selection, if appropriate."<br>
<br>
Preferences alternativeBrowseIt ifTrue: [^ self browseClassFromIt].<br>
<br>
self lineSelectAndEmptyCheck: [^ morph flash].<br>
<br>
"First, try to show all accesses to instance or class variables."<br>
self selectedInstanceVariable ifNotNil:<br>
[:nameToClass | self systemNavigation<br>
browseAllAccessesTo: nameToClass key<br>
from: nameToClass value].<br>
self selectedClassVariable ifNotNil:<br>
+ [:binding | self systemNavigation browseAllCallsOn: binding].<br>
- [:binding | self model browseAllCallsOn: binding].<br>
<br>
"Then, either browse the class (from a binding) or all implementors of a selector."<br>
self selectedBinding ifNotNil:<br>
[:binding | ^ self systemNavigation browseClass: binding].<br>
self selectedSelector ifNotNil:<br>
+ [:selector | ^ self systemNavigation browseAllImplementorsOf: selector].<br>
- [:selector | ^ self model browseAllImplementorsOf: selector].<br>
<br>
morph flash!<br>
<br>
Item was changed:<br>
----- Method: TextEditor>>sendersOfIt (in category 'menu messages') -----<br>
sendersOfIt<br>
"Open a senders browser on the selected selector"<br>
<br>
self lineSelectAndEmptyCheck: [^ self].<br>
+ self selectedSelector ifNotNil:<br>
+ [:aSelector| ^self systemNavigation browseAllCallsOn: aSelector].<br>
+ self selectedLiteral ifNotNil:<br>
+ [:aLiteral| ^self systemNavigation browseAllCallsOn: aLiteral].<br>
+ morph flash!<br>
- self selectedSelector ifNotNil: [:aSelector |<br>
- ^ self model browseAllCallsOn: aSelector].<br>
- self selectedLiteral ifNotNil: [:aLiteral |<br>
- ^ self model browseAllCallsOn: aLiteral].<br>
- morph flash.!<br>
<br>
<br>
</blockquote></div>