<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Hi Marcel,</p>
<p><br>
</p>
<p>without a properly thought-through and documented design, I fear that any custom parsing of the message text could break too fast. Just imagine:</p>
<p><br>
</p>
<p><span>self inform: ('Dear user, this is a test with a pretty long message - decide yourself whether you make any sense of it.' withNoLineLongerThan: 53).</span><br>
</p>
<p><span><br>
</span></p>
<p><span>Which would probably be rendered incorrectly with your proposed change. A different solution would be scanning the dialog text for a special TextAttribute, this would be nice. :-)</span></p>
<p><span><br>
</span></p>
<p><span>> <span>It's way simpler than starting to implement hide/show capabilities in ProportionalLayout ;-)</span></span></p>
<p><span><span><br>
</span></span></p>
<p><span><span>Hehe! Let's address this issue again after the next release. :-)</span></span></p>
<p><span><span><br>
</span></span></p>
<p><span><span>Best,</span></span></p>
<p><span><span>Christoph</span></span></p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Dienstag, 11. Januar 2022 13:34:40<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Trunk: Monticello-ct.729.mcz</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Christoph --
<div><br>
</div>
<div>> <span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">I would have expected</span></div>
<div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px"><br>
</span></div>
<div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">Then my comparison with Markdown seems to have mislead you. Sorry. Don't overthink it. It's just a low-hanging fruit. It's way simpler than starting to implement hide/show capabilities
in ProportionalLayout ;-) </span></div>
<div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px"><br>
</span></div>
<div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">Best,</span></div>
<div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">Marcel</span></div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 11.01.2022 13:26:59 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div id="divtagdefaultwrapper" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif" dir="ltr">
<p>Hi Marcel,</p>
<p><br>
</p>
<p>Markdown sounds *very* appealing, but my personal preference would be to think through this thoroughly rather than starting with a single syntax for a rather special use case. For instance, I would have expected `- ' to map to a (not yet existing) EnumerationAttribute
with an indented bullet point (•). I would prefer to collect more use cases before going into the implementation of such an API. Just my 2 cents. :-)</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Dienstag, 11. Januar 2022 13:13:46<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Trunk: Monticello-ct.729.mcz</span>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi all --
<div><br>
</div>
<div>If you want to, we can add a very simple portion of Markdown to parse it into a list morph in the dialog. Just match for hyphens at the beginning of two or more lines:</div>
<div><br>
</div>
<div>Hello!</div>
<div>- This</div>
<div>- is</div>
<div>- a</div>
<div>- list</div>
<div><br>
</div>
<div>The dialog could show 3 lines by default and the rest via scrolling. Is this too much magic?</div>
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 10.01.2022 13:12:08 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif">
<p>Hi all,</p>
<p><br>
</p>
<p>these are nested strings via #format:. :-) The message actually looks like this:</p>
<p><br>
</p>
<p><img size="13852" id="x_img318229" tabindex="0" style="max-width:99.9%" src="cid:89b9f8d6-8197-4ac2-87f8-57922088cb12"><!-- </img> --><!-- </img> --><br>
</p>
<p><br>
</p>
<p>Do you have any other change requests to the message? :-)</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von tim Rowledge <tim@rowledge.org><br>
<b>Gesendet:</b> Montag, 10. Januar 2022 05:42:26<br>
<b>An:</b> The general-purpose Squeak developers list<br>
<b>Betreff:</b> Re: [squeak-dev] The Trunk: Monticello-ct.729.mcz</span>
<div> </div>
</div>
</div>
<span style="font-size: 10pt"><span style="font-size: 10pt">
<div class="PlainText">I agree with Chris here; though the split handling of the 1/more versions is nice.<br>
<br>
As for the version name truncation, a nicer solution would be for the notifier UI to have a scrollbar if is it needed. And while fantasising, if there is more than one version to report using a UI list would be nice, especially since it would provide for a
scrollbar in the eventuality that many items need listing.<br>
<br>
> On 2022-01-09, at 5:25 PM, Chris Muller <asqueaker@gmail.com> wrote:<br>
> <br>
> -1<br>
> <br>
> Seeing, "Caution, do you really want to...," is kind of annoying because it's applying the "caution" to the user's intent BEFORE saying why.
<br>
> <br>
> The old message applied the caution to the REASON, and THEN asked the user, "do you really want to...".<br>
> <br>
> From that aspect, the old message is better.<br>
> <br>
> <br>
> <br>
> <br>
> <br>
> On Mon, Jan 3, 2022 at 2:41 PM <commits@source.squeak.org> wrote:<br>
> Christoph Thiede uploaded a new version of Monticello to project The Trunk:<br>
> <a href="http://source.squeak.org/trunk/Monticello-ct.729.mcz">http://source.squeak.org/trunk/Monticello-ct.729.mcz</a><br>
> <br>
> ==================== Summary ====================<br>
> <br>
> Name: Monticello-ct.729<br>
> Author: ct<br>
> Time: 17 September 2020, 7:04:53.385813 pm<br>
> UUID: 5eea47cc-405e-7841-9544-0f57a9b92fa0<br>
> Ancestors: Monticello-cmm.726<br>
> <br>
> Proposal: Enhance truncation of "newer versions avaiable" warning (and make it multilingual-ready)<br>
> <br>
> =============== Diff against Monticello-cmm.726 ===============<br>
> <br>
> Item was changed:<br>
> ----- Method: MCWorkingCopyBrowser>>checkForNewerVersions (in category 'actions') -----<br>
> checkForNewerVersions<br>
> + "Answer true if there are no newer versions preventing us from saving a version."<br>
> + <br>
> | newer |<br>
> newer := workingCopy possiblyNewerVersionsIn: self repository.<br>
> + <br>
> + newer ifEmpty: [^ true].<br>
> + <br>
> + ^ self confirm: ('CAUTION!! {1}:\{2}\Do you really want to save this version?' withCRs translated format: {<br>
> + newer size = 1<br>
> + ifTrue: ['This version in the repository may be newer' translated]<br>
> + ifFalse: ['These {1} versions in the repository may be newer' translated format: {newer size}].<br>
> + (newer size > 3<br>
> + ifFalse: [newer]<br>
> + ifTrue: [(newer first: 3) , {'...'} , {newer last}]) asCommaString withNoLineLongerThan: 150<br>
> + })!<br>
> - ^ newer isEmpty or: [<br>
> - self confirm: 'CAUTION!! These versions in the repository may be newer:',
<br>
> - String cr, ((newer asCommaString withNoLineLongerThan: 150) truncateWithElipsisTo: 5 * 149), String cr,<br>
> - 'Do you really want to save this version?'].!<br>
> <br>
> <br>
> <br>
<br>
<br>
tim<br>
--<br>
tim Rowledge; tim@rowledge.org; <a href="http://www.rowledge.org/tim">http://www.rowledge.org/tim</a><br>
Design simplicity: It was developed on a shoe-string budget.<br>
<br>
<br>
<br>
</div>
</span></span></div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</body>
</html>