<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Levente, hi Christoph --<div><br></div><div>Hmm... from a key-input handling perspective, I would prefer #return and #enter over #cr or #lf etc. Hmm.... there can only be one printString/storeString. If we would change #constantNames again ... I would have to duplicate it to make the virtual key stuff look as expected again.</div><div><br></div><div>About this test. I think it makes no sense to compare strings but the resulting objects. The test should test the storeOn:/evaluate: dualism. Older storeStrings can easily be tested as well.</div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">self assert: Ch</span><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">aracter cr equals: (Compiler evaluate: 'Character cr').</span><br></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">self assert: Ch</span><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">aracter cr equals: (Compiler evaluate: 'Character return').</span><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">self assert: Ch</span><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">aracter return equals: (Compiler evaluate: 'Character cr').</span><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">self assert: Ch</span><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">aracter return equals: (Compiler evaluate: 'Character return').</span><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><br></div><div>The current results of #storeString should not matter.</div><div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 10.01.2022 23:11:10 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p><div style="font-family:Arial,Helvetica,sans-serif">
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif">
<p>Hi Levente,</p>
<p><br>
</p>
<p>good question, I had assumed Marcel had also thought this through when renaming the constant. We cannot have two printString representations for the same character, obviously. In his original patch, Marcel wrote:</p>
<p><br>
</p>
<p></p>
<div>> One more thing: Also changes the printString of ASCII-13 to #return because it seems more readable than #cr.</div>
<div>> </div>
<div>> Note that I pushed readability more into the direction of recognizing physical keys, not standard ASCII labels. I hope that's fine... In that sense, the printString for #lf might be also changed to #linefeed, which is already there.</div>
<p></p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Levente Uzonyi <leves@caesar.elte.hu><br>
<b>Gesendet:</b> Montag, 10. Januar 2022 22:21:36<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org<br>
<b>Cc:</b> packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> Re: [squeak-dev] The Trunk: CollectionsTests-ct.368.mcz</span>
<div> </div>
</div>
</div>
<span style="font-size: 10pt"><span style="font-size: 10pt">
<div class="PlainText">Hi Christoph,<br>
<br>
On Mon, 10 Jan 2022, commits@source.squeak.org wrote:<br>
<br>
> Christoph Thiede uploaded a new version of CollectionsTests to project The Trunk:<br>
> <a href="http://source.squeak.org/trunk/CollectionsTests-ct.368.mcz">http://source.squeak.org/trunk/CollectionsTests-ct.368.mcz</a><br>
><br>
> ==================== Summary ====================<br>
><br>
> Name: CollectionsTests-ct.368<br>
> Author: ct<br>
> Time: 10 January 2022, 8:03:34.822597 pm<br>
> UUID: a071bc20-7ee8-c64b-a012-4d0b77d7317d<br>
> Ancestors: CollectionsTests-ct.367<br>
><br>
> Fixes failing collection tests.<br>
<br>
Yes, the test passes now, but it marks a potentially breaking change <br>
because it affects #printString and #storeString.<br>
Do we really want it to be printed as Charcter return instead of Character cr?<br>
If yes, why return?<br>
Why not carriageReturn?<br>
<br>
<br>
Levente<br>
<br>
</div>
</span></span>
</div></blockquote></div>