<body><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Looks good! Please merge. :-)<div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div><blockquote class='history_container' type='cite' style='border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;'>
<p style='color: #AAAAAA; margin-top: 10px;'>Am 03.01.2022 23:36:50 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p><div style='font-family:Arial,Helvetica,sans-serif'>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif">
<p>Hi Marcel, hi all,</p>
<p><br>
</p>
<p>I have sent this to the inbox because I am not sure whether it might be a better idea to implement #applyTo: on UserInterfaceThemeRequest instead as a forwarding message. Please give me a second opinion. :-)</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Montag, 3. Januar 2022 23:35:03<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Inbox: Morphic-ct.1842.mcz</span>
<div> </div>
</div>
</div>
<span style="font-size: 10pt"><span style="font-size: 10pt">
<div class="PlainText">A new version of Morphic was added to project The Inbox:<br>
<a href="http://source.squeak.org/inbox/Morphic-ct.1842.mcz">http://source.squeak.org/inbox/Morphic-ct.1842.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Morphic-ct.1842<br>
Author: ct<br>
Time: 3 January 2022, 11:34:56.949397 pm<br>
UUID: 2278fc82-96e5-7c47-a89f-99b0ad45d8a8<br>
Ancestors: Morphic-ct.1841<br>
<br>
Fixes a bug that prevented UI themes from being applied to collapsed windows.<br>
<br>
"self userInterfaceTheme" answers a UserInterfaceThemeRequest rather than a UserInterfaceTheme, and sending #applyTo: to this request caused the local UI property "#applyTo" being set to "self allMorphs" rather than actually applying the UI theme.<br>
<br>
=============== Diff against Morphic-ct.1841 ===============<br>
<br>
Item was changed:<br>
----- Method: SystemWindow>>collapseOrExpand (in category 'resize/collapse') -----<br>
collapseOrExpand<br>
"Collapse or expand the window, depending on existing state"<br>
| cf |<br>
isCollapsed<br>
ifTrue: <br>
["Expand -- restore panes to morphics structure"<br>
isCollapsed := false.<br>
self beKeyWindow. "Bring to frint first"<br>
Preferences collapseWindowsInPlace<br>
ifTrue: <br>
[fullFrame := fullFrame align: fullFrame topLeft with: self getBoundsWithFlex topLeft]<br>
ifFalse:<br>
[collapsedFrame := self getBoundsWithFlex].<br>
collapseBox ifNotNil: [collapseBox setBalloonText: 'collapse this window' translated].<br>
self setBoundsWithFlex: fullFrame.<br>
paneMorphs reverseDo: <br>
[:m | self addMorph: m unlock.<br>
self world startSteppingSubmorphsOf: m].<br>
self addPaneSplitters.<br>
(self hasProperty: #applyTheme) ifTrue: [<br>
self removeProperty: #applyTheme.<br>
+ UserInterfaceTheme current applyTo: self allMorphs]]<br>
- self userInterfaceTheme applyTo: self allMorphs]]<br>
ifFalse: <br>
["Collapse -- remove panes from morphics structure"<br>
isCollapsed := true.<br>
fullFrame := self getBoundsWithFlex.<br>
"First save latest fullFrame"<br>
paneMorphs do: [:m | m delete; releaseCachedState].<br>
self removePaneSplitters.<br>
self removeCornerGrips.<br>
model modelSleep.<br>
cf := self getCollapsedFrame.<br>
(collapsedFrame isNil and: [Preferences collapseWindowsInPlace not]) ifTrue:<br>
[collapsedFrame := cf].<br>
self setBoundsWithFlex: cf.<br>
collapseBox ifNotNil: [collapseBox setBalloonText: 'expand this window' translated ].<br>
expandBox ifNotNil: [expandBox setBalloonText: 'expand this window' translated ].<br>
self sendToBack].<br>
self layoutChanged!<br>
<br>
<br>
</div>
</span></span>
</div></blockquote>
</div></body>