<body><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi all --<div><br></div><div>I fixed that filout issue in Transcript. Thanks for the pointer. Disabling/changing accept/cancel just for the Transcript case is not that simple, I suppose. Hmm... at not that important at the moment. Sorry.</div><div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div><blockquote class='history_container' type='cite' style='border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;'>
<p style='color: #AAAAAA; margin-top: 10px;'>Am 25.01.2022 23:08:31 schrieb Jaromir Matas <mail@jaromir.net>:</p><div style='font-family:Arial,Helvetica,sans-serif'>
<div class="WordSection1">
<p class="MsoNormal">Hi,</p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="mso-element:para-border-div;border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in;margin-left:.5in;margin-right:0in">
<p class="MsoNormal" style="border:none;padding:0in"><b>From: </b><a href="mailto:tim@rowledge.org">tim Rowledge</a><br>
<b>Sent: </b>Tuesday, January 25, 2022 21:08<br>
<b>To: </b><a href="mailto:squeak-dev@lists.squeakfoundation.org">The general-purpose Squeak developers list</a><br>
<b>Subject: </b>Re: [squeak-dev] Accept on a Transcript window removes the contents without any undo</p>
</div>
<p class="MsoNormal" style="mso-margin-top-alt:0in;margin-right:0in;margin-bottom:12.0pt;margin-left:.5in">
<br>
> On 2022-01-25, at 6:19 AM, mail@jaromir.net wrote:<br>
> <br>
> Hi Marcel, all,<br>
> <br>
> Accept on a Transcript window removes the contents without any undo. This is very surprising and for sure unexpected :)<br>
> <br>
> It would probably be better if it didn't do anything rthaer than that.<br>
<br>
It would be far better if the Transcript window didn't have an accept menu entry. And if that were done, then I'd suggest that the cancel should be replaced with something like 'clear', since we bind accept & cancel quite tightly together. Indeed, I'd claim
that almost nothing int he current transcript window menu should be there; a transcript is supposed to be a logfile-reader analogue, not any sort of working space.<br>
<br>
<o:p></o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">I’ve tried the “save contents to file…” on the menu - there seems to be a little bug: it opens the Debugger on Cancel… here’s a possible fix:<o:p></o:p></p>
<p class="MsoNormal">```<o:p></o:p></p>
<p class="MsoNormal">TranscriptStream >> saveContents: stringContents accessMode: accessMode<o:p></o:p></p>
<p class="MsoNormal"> "Interactive callback from TextEditor. See commentary in Model class."<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"> ^ (Project uiManager<o:p></o:p></p>
<p class="MsoNormal"> saveFilenameRequest: 'Save text contents in file...'<o:p></o:p></p>
<p class="MsoNormal"> initialAnswer: 'Transcript.text')
<o:p></o:p></p>
<p class="MsoNormal"> ifNil: [^false]; "<------- here’s the fix"<o:p></o:p></p>
<p class="MsoNormal"> ifEmpty: [false]<o:p></o:p></p>
<p class="MsoNormal"> ifNotEmpty: [:fileName |<o:p></o:p></p>
<p class="MsoNormal"> Model new<o:p></o:p></p>
<p class="MsoNormal"> saveContents: stringContents<o:p></o:p></p>
<p class="MsoNormal"> onFileNamed: fileName<o:p></o:p></p>
<p class="MsoNormal"> accessMode: accessMode].<o:p></o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">```<o:p></o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div></blockquote>
</div></body>