<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Christoph --<div><br></div><div>I am aware of the current drawbacks of #flash. If you want to change it's behavior, please elaborate on the possible issues first. If the worst that might happen is a single debugger, then we are fine.</div><div><br></div><div>Still, instead of </div><div><br></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">self addAlarm: #color: with: originalColor after: 20 "milliSeconds"</span><br></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">I would write:</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">(self future: 20 "milliseconds") color: originalColor.</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">But any way is okay, I suppose.</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-size: 10pt">Best,</span><br></div><div>Marcel</div><div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 27.01.2022 17:38:57 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p><div style="font-family:Arial,Helvetica,sans-serif">
<div id="divtagdefaultwrapper" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif" dir="ltr">
<p>Hi Marcel,</p>
<p><br>
</p>
<p>#flash is broadcasted by some models to possibly many morphs, so I think a synchronous call comes with the drawback of unnecessarily slowing down the system for each invocation. How would you think of a separate new #flashAsync for this use case? :-)</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Donnerstag, 27. Januar 2022 11:09:28<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: Morphic-ct.1859.mcz</span>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Christoph --
<div><br>
</div>
<div>-1</div>
<div><br>
</div>
<div>Please don't make a synchronous call async like this. Add a busyWait if you like, but no Morphic alarm.</div>
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 26.01.2022 21:50:31 schrieb commits@source.squeak.org <commits@source.squeak.org>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">A new version of Morphic was added to project The Inbox:<br>
http://source.squeak.org/inbox/Morphic-ct.1859.mcz<br>
<br>
==================== Summary ====================<br>
<br>
Name: Morphic-ct.1859<br>
Author: ct<br>
Time: 26 January 2022, 9:50:11.019407 pm<br>
UUID: 83e57c24-b685-2a4a-ac5a-ad0df51bba9d<br>
Ancestors: Morphic-mt.1858<br>
<br>
Proposal: Makes #flash more visible by<br>
a) using a morphic alarm to ensure that the flash also appears on fast machines (on my machine, it did not always appear before else)<br>
b) having system windows participate in a flash requested by a model too.<br>
<br>
=============== Diff against Morphic-mt.1858 ===============<br>
<br>
Item was changed:<br>
----- Method: Morph>>flash (in category 'macpal') -----<br>
flash<br>
| originalColor |<br>
originalColor := self color.<br>
+ self color:<br>
- [ self color:<br>
(originalColor<br>
ifNil: [ Color black ]<br>
+ ifNotNil: [( (originalColor alpha: 1) adjustSaturation: 0.8 brightness: 0) negated ]).<br>
+ self refreshWorld.<br>
+ self addAlarm: #color: with: originalColor after: 20 "milliSeconds".!<br>
- ifNotNil: [( (originalColor alpha: 1) adjustSaturation: 0.8 brightness: 0) negated ]) ]<br>
- ensure:<br>
- [ self refreshWorld.<br>
- self color: originalColor ]!<br>
<br>
Item was changed:<br>
----- Method: SystemWindow>>update: (in category 'label') -----<br>
update: aSymbol<br>
aSymbol = #relabel<br>
ifTrue: [^ model ifNotNil: [ self setLabel: model labelString ] ].<br>
aSymbol = #close<br>
+ ifTrue: [self delete].<br>
+ aSymbol = #flash<br>
+ ifTrue: [self flash].!<br>
- ifTrue: [self delete]!<br>
<br>
<br>
</div>
</blockquote>
</div>
</div>
</div></blockquote></div>