<div dir="ltr"><div dir="ltr">I think you reverted the intended fix to use FileDirectory slash instead of ':'<br></div><div dir="ltr"><br></div><div dir="ltr">
+ sampleSetDir := orchestraDir, ':', instName, ' f'.<br>
- sampleSetDir := orchestraDir, FileDirectory slash, instName, ' f'. <br></div><div dir="ltr"><br></div><div>Best, <br></div><div>Karl<br></div><br></div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Feb 5, 2022 at 9:50 PM <<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">David T. Lewis uploaded a new version of Sound to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Sound-dtl.86.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/trunk/Sound-dtl.86.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Sound-dtl.86<br>
Author: dtl<br>
Time: 5 February 2022, 3:47:29.747123 pm<br>
UUID: 340d381a-fa79-4de2-aba6-42171c9f2a50<br>
Ancestors: Sound-dto.85<br>
<br>
Remove accidental whitespace-only changes from previous commit<br>
<br>
=============== Diff against Sound-dto.85 ===============<br>
<br>
Item was changed:<br>
----- Method: SampledInstrument class>>readLoudAndStaccatoInstrument:fromDirectory: (in category 'instance creation') -----<br>
+ readLoudAndStaccatoInstrument: instName fromDirectory: orchestraDir<br>
- readLoudAndStaccatoInstrument: instName fromDirectory: orchestraDir <br>
"SampledInstrument<br>
+ readLoudAndStaccatoInstrument: 'oboe'<br>
+ fromDirectory: 'Tosh:Sample Library:Orchestra'"<br>
+ <br>
- readLoudAndStaccatoInstrument: 'oboe'<br>
- fromDirectory: 'Tosh:Sample Library:Orchestra'"<br>
| sampleSetDir memBefore memAfter loud short snd |<br>
+ sampleSetDir := orchestraDir, ':', instName.<br>
- sampleSetDir := orchestraDir , FileDirectory slash , instName.<br>
memBefore := Smalltalk garbageCollect.<br>
+ loud := SampledInstrument new readSampleSetFrom: sampleSetDir, ' f'.<br>
+ short := SampledInstrument new readSampleSetFrom: sampleSetDir, ' stacc'.<br>
- loud := SampledInstrument new readSampleSetFrom: sampleSetDir , ' f'.<br>
- short := SampledInstrument new readSampleSetFrom: sampleSetDir , ' stacc'.<br>
memAfter := Smalltalk garbageCollect.<br>
+ Transcript show:<br>
+ instName, ': ', (memBefore - memAfter) printString,<br>
+ ' bytes; ', memAfter printString, ' bytes left'; cr.<br>
+ AbstractSound soundNamed: instName, '-f&stacc' put:<br>
+ (snd := SampledInstrument new<br>
+ allSampleSets: loud;<br>
+ staccatoLoudAndSoftSampleSet: short).<br>
- Transcript show: instName , ': ' , (memBefore - memAfter) printString , ' bytes; ' , memAfter printString , ' bytes left';<br>
- cr.<br>
- AbstractSound soundNamed: instName , '-f&stacc' put: (snd := SampledInstrument new allSampleSets: loud;<br>
- staccatoLoudAndSoftSampleSet: short).<br>
"fix slow attacks"<br>
+ snd allNotes do: [:n | n firstSample: (n findStartPointForThreshold: 500)].<br>
+ <br>
+ AbstractSound soundNamed: instName, '-f' put:<br>
+ (snd := SampledInstrument new<br>
+ allSampleSets: loud).<br>
- snd allNotes<br>
- do: [:n | n<br>
- firstSample: (n findStartPointForThreshold: 500)].<br>
- AbstractSound soundNamed: instName , '-f' put: (snd := SampledInstrument new allSampleSets: loud).<br>
"fix slow attacks"<br>
+ snd allNotes do: [:n | n firstSample: (n findStartPointForThreshold: 1000)].<br>
+ !<br>
- snd allNotes<br>
- do: [:n | n<br>
- firstSample: (n findStartPointForThreshold: 1000)]!<br>
<br>
Item was changed:<br>
----- Method: SampledInstrument class>>readPizzInstrument:fromDirectory: (in category 'instance creation') -----<br>
+ readPizzInstrument: instName fromDirectory: orchestraDir<br>
- readPizzInstrument: instName fromDirectory: orchestraDir <br>
"SampledInstrument<br>
+ readPizzInstrument: 'violin'<br>
+ fromDirectory: 'Tosh:Sample Library:Orchestra'"<br>
+ <br>
- readPizzInstrument: 'violin'<br>
- fromDirectory: 'Tosh:Sample Library:Orchestra'"<br>
| sampleSetDir memBefore memAfter sampleSet snd |<br>
+ sampleSetDir := orchestraDir, ':', instName, ' pizz'.<br>
- sampleSetDir := orchestraDir , FileDirectory slash , instName , ' pizz'.<br>
memBefore := Smalltalk garbageCollect.<br>
sampleSet := SampledInstrument new readSampleSetFrom: sampleSetDir.<br>
memAfter := Smalltalk garbageCollect.<br>
+ Transcript show:<br>
+ instName, ': ', (memBefore - memAfter) printString,<br>
+ ' bytes; ', memAfter printString, ' bytes left'; cr.<br>
+ AbstractSound soundNamed: instName, '-pizz' put:<br>
+ (snd := SampledInstrument new allSampleSets: sampleSet).<br>
+ <br>
- Transcript show: instName , ': ' , (memBefore - memAfter) printString , ' bytes; ' , memAfter printString , ' bytes left';<br>
- cr.<br>
- AbstractSound soundNamed: instName , '-pizz' put: (snd := SampledInstrument new allSampleSets: sampleSet).<br>
"fix slow attacks"<br>
+ snd allNotes do: [:n |<br>
+ n firstSample: (n findStartPointForThreshold: 1000)].<br>
+ <br>
+ ^ snd<br>
+ !<br>
- snd allNotes<br>
- do: [:n | n<br>
- firstSample: (n findStartPointForThreshold: 1000)].<br>
- ^ snd!<br>
<br>
Item was changed:<br>
----- Method: SampledInstrument class>>readSimpleInstrument:fromDirectory: (in category 'instance creation') -----<br>
readSimpleInstrument: instName fromDirectory: orchestraDir<br>
"SampledInstrument<br>
readSimpleInstrument: 'oboe'<br>
fromDirectory: 'Tosh:Sample Library:Orchestra'"<br>
<br>
| sampleSetDir memBefore memAfter sampleSet snd |<br>
+ sampleSetDir := orchestraDir, ':', instName, ' f'.<br>
- sampleSetDir := orchestraDir, FileDirectory slash, instName, ' f'.<br>
memBefore := Smalltalk garbageCollect.<br>
sampleSet := SampledInstrument new readSampleSetFrom: sampleSetDir.<br>
memAfter := Smalltalk garbageCollect.<br>
Transcript show:<br>
instName, ': ', (memBefore - memAfter) printString,<br>
' bytes; ', memAfter printString, ' bytes left'; cr.<br>
AbstractSound soundNamed: instName, '-f' put:<br>
(snd := SampledInstrument new allSampleSets: sampleSet).<br>
<br>
"fix slow attacks"<br>
snd allNotes do: [:n |<br>
n firstSample: (n findStartPointForThreshold: 1000)].<br>
<br>
^ snd<br>
!<br>
<br>
<br>
</blockquote></div>