<body><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Christoph --<div><br></div><div>-1</div><div><br></div><div>Maybe after the release, we can try to think about that. I don't think this idea has a good cost-value ratio. ;-) Let's keep it simple and as-is for the moment.</div><div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div><blockquote class='history_container' type='cite' style='border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;'>
<p style='color: #AAAAAA; margin-top: 10px;'>Am 07.02.2022 21:46:22 schrieb commits@source.squeak.org <commits@source.squeak.org>:</p><div style='font-family:Arial,Helvetica,sans-serif'>A new version of System was added to project The Inbox:<br>http://source.squeak.org/inbox/System-ct.1303.mcz<br><br>==================== Summary ====================<br><br>Name: System-ct.1303<br>Author: ct<br>Time: 7 February 2022, 9:46:07.019465 pm<br>UUID: 84c77d47-9ac2-644a-a2d0-2bf8cc5ff4d0<br>Ancestors: System-mt.1302<br><br>Proposal: Adds support for translations of the pattern "withCRs translated". This is a first iteration of this pattern; if the proposal is well received, the implementation by be generalized. However, we must not forget that we only should support a minimal pattern of selectors here; #translated should only be sent to literal expressions such as 'hello' or 'hello\world' withCRs.<br><br>See http://lists.squeakfoundation.org/pipermail/squeak-dev/2022-February/218959.html.<br><br>=============== Diff against System-mt.1302 ===============<br><br>Item was changed:<br> ----- Method: TranslatedReceiverFinder>>findWordsWith:in: (in category 'accessing') -----<br> findWordsWith: aSymbol in: aMethodReference <br> "Find words for translation with the symbol in a method. See<br> LanguageEditorTest >>testFindTranslatedWords"<br> "| message | <br> message := MethodReference new setStandardClass: Morph class<br> methodSymbol: #supplementaryPartsDescriptions.<br> self new findWordsWIth: #translatedNoop in: message"<br> | messages keywords aParseNode |<br> aParseNode := aMethodReference decompile.<br> "Find from string literal"<br> messages := Set new.<br> self<br> search: aSymbol<br> messageNode: aParseNode<br> addTo: messages.<br> keywords := OrderedCollection new.<br> messages<br> select: [:aMessageNode | aMessageNode receiver isMemberOf: LiteralNode]<br> thenDo: [:aMessageNode | aMessageNode receiver key<br> literalStringsDo: [:literal | keywords add: literal]].<br>+ messages<br>+ select: [:aMessageNode | (aMessageNode receiver isMemberOf: MessageNode)<br>+ and: [aMessageNode receiver selector key = #withCRs]<br>+ and: [aMessageNode receiver receiver isMemberOf: LiteralNode]]<br>+ thenDo: [:aMessageNode | aMessageNode receiver receiver key<br>+ literalStringsDo: [:literal | keywords add: literal withCRs]].<br> "Find from array literal"<br> self<br> arraySearch: aSymbol<br> messageNode: aParseNode<br> addTo: keywords.<br> ^ keywords!<br><br><br></div></blockquote>
</div></body>