<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Thank you! :-)</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Mittwoch, 9. Februar 2022 17:51:03<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Trunk: Tools-mt.1129.mcz</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Done.
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 09.02.2022 15:20:04 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif">
<p>Hi Marcel,</p>
<p><br>
</p>
<p>should we provide these layout constants via 60Deprecated? I see some packages on GitHub depending on them, and I would not be surprised if I would have used them myself somewhere. :-)</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Mittwoch, 9. Februar 2022 14:00:46<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Trunk: Tools-mt.1129.mcz</span>
<div> </div>
</div>
</div>
<span style="font-size: 10pt"><span style="font-size: 10pt">
<div class="PlainText">Marcel Taeumel uploaded a new version of Tools to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Tools-mt.1129.mcz">http://source.squeak.org/trunk/Tools-mt.1129.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Tools-mt.1129<br>
Author: mt<br>
Time: 9 February 2022, 2:00:43.820754 pm<br>
UUID: fc1e3163-b722-5645-8f0c-b4bf03ef2b6e<br>
Ancestors: Tools-ct.1128<br>
<br>
Minor code cleanup. Makes the addition of ui-theme specific text attributes to illustrate "deprecation" of an artifact (e.g., class/method) re-usable via extension on Text.<br>
<br>
=============== Diff against Tools-ct.1128 ===============<br>
<br>
Item was removed:<br>
- ----- Method: CodeHolder>>defaultAnnotationPaneHeight (in category 'annotation') -----<br>
- defaultAnnotationPaneHeight<br>
- "Answer the receiver's preferred default height for new annotation panes."<br>
- <br>
- ^ Preferences parameterAt: #defaultAnnotationPaneHeight ifAbsentPut: [25]!<br>
<br>
Item was removed:<br>
- ----- Method: CodeHolder>>defaultButtonPaneHeight (in category 'annotation') -----<br>
- defaultButtonPaneHeight<br>
- "Answer the user's preferred default height for new button panes."<br>
- <br>
- ^ Preferences parameterAt: #defaultButtonPaneHeight ifAbsentPut: [25]!<br>
<br>
Item was changed:<br>
----- Method: CodeHolder>>formattedLabel:forSelector:inClass: (in category 'message list') -----<br>
formattedLabel: aString forSelector: aSymbol inClass: aClass<br>
"Show deprecated messages differently so that users recognize them quickly to avoid them. This is a performance critical method in the user interface."<br>
<br>
- | formattedLabel |<br>
self flag: #investigate. "mt: aClass must never be nil!! Faulty tools should override this call themselves or fix the caller site."<br>
aClass ifNil: [^ aString].<br>
<br>
(aSymbol = #Definition or: [aSymbol = #Comment])<br>
ifTrue: [aClass isDeprecated<br>
ifFalse: [^ aString]]<br>
ifFalse: [(aClass isDeprecated or: [(aClass compiledMethodAt: aSymbol ifAbsent: [^ aString]) isDeprecated])<br>
ifFalse: [^ aString]].<br>
<br>
+ ^ aString asText addAttributesForDeprecation!<br>
- formattedLabel := aString asText.<br>
- <br>
- (self userInterfaceTheme deprecatedMessageAttributes ifNil: [{TextColor gray. TextEmphasis struckOut}]) do: [:textAttribute |<br>
- formattedLabel addAttribute: textAttribute].<br>
- <br>
- ^ formattedLabel.!<br>
<br>
Item was added:<br>
+ ----- Method: Text>>addAttributesForDeprecation (in category '*Tools-attributes') -----<br>
+ addAttributesForDeprecation<br>
+ "Add text attributes to the receiver so that clients will recognize the underlying artifact (e.g., class or method) as deprecated."<br>
+ <br>
+ ((UserInterfaceTheme current get: #deprecatedMessageAttributes for: #CodeHolder)<br>
+ ifNil: [{TextColor gray. TextEmphasis struckOut}])<br>
+ do: [:textAttribute | self addAttribute: textAttribute].!<br>
<br>
<br>
</div>
</span></span></div>
</blockquote>
</div>
</div>
</body>
</html>