<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Hi Marcel,</p>
<p><br>
</p>
<p>> <span style="font-size: 12pt;">[x] Windows' controls are always active </span></p>
<div><br>
</div>
<div>You do not need to enable this preference to open a mini-editor on an unfocused window label. But I agree that we do have more important issues. :-)</div>
<div><br>
</div>
<div>Best,</div>
<div>Christoph</div>
<p></p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Montag, 14. Februar 2022 11:04:39<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Trunk: Morphic-mt.1874.mcz</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Christoph --
<div class="mb_sig"></div>
<div><br>
</div>
<div>I wouldn't complicate the control flow too much here. Editing a label in an inactive window seems like a rare edge case.</div>
<div><br>
</div>
<div>Give than you have</div>
<div><br>
</div>
<div>[ ] Mouse over for keyboard focus</div>
<div>[x] Windows' controls are always active </div>
<div><br>
</div>
<div>It might happen a little bit more often. Yet, the basic implementation is within StringMorph. The current approach with #acceptContents indicates that talking to the outer scope (i.e., the window) is rather ugly. So, don't treat the way I did it there
as a "free ticket" so add more such strange stuff. Instead, assess the relevance of such issue. Regarding this window-color thing ... I don't think it is important enough.</div>
<div><br>
</div>
<div>Just leave it be for now. :-)</div>
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 13.02.2022 00:45:08 schrieb christoph.thiede@student.hpi.uni-potsdam.de <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">Hi Marcel,<br>
<br>
I noticed that when you launch a mini-editor on a non-focused window that has a grey label color instead of a black label color, the grey color will also be used in the mini-editor.<br>
<br>
If you deem this worth a fix: Where would be the right place for such a fix? Use a mouse event filter in SystemWindow and update the label color (#lookFocused) preliminary? Hm ... :-)<br>
<br>
Best,<br>
Christoph<br>
<br>
<span style="color: #808080">---<br>
</span><span style="color: #808080"><i>Sent from </i></span><span style="color: #808080"><i><a href="https://github.com/hpi-swa-lab/squeak-inbox-talk"><u><span style="color: #808080">Squeak Inbox Talk</span></u></a></i></span><br>
<br>
On 2022-02-07T12:10:13+00:00, christoph.thiede@student.hpi.uni-potsdam.de wrote:<br>
<br>
> This looks so much more modern! Thank you! :-)<br>
> <br>
> <br>
> By the way, Cmd + L is not working in these mini-editors. But this is not a regression.<br>
> <br>
> <br>
> Best,<br>
> <br>
> Christoph<br>
> <br>
> ________________________________<br>
> Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org><br>
> Gesendet: Montag, 7. Februar 2022 11:04:15<br>
> An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org<br>
> Betreff: [squeak-dev] The Trunk: Morphic-mt.1874.mcz<br>
> <br>
> Marcel Taeumel uploaded a new version of Morphic to project The Trunk:<br>
> http://source.squeak.org/trunk/Morphic-mt.1874.mcz<br>
> <br>
> ==================== Summary ====================<br>
> <br>
> Name: Morphic-mt.1874<br>
> Author: mt<br>
> Time: 7 February 2022, 11:04:09.494414 am<br>
> UUID: a70b7bc5-e1e8-a743-9ef9-d1f84ea1315c<br>
> Ancestors: Morphic-mt.1873<br>
> <br>
> Fixes visual appearance of mini editor for StringMorph. For example, the one that comes when you SHIFT+Red-click a window title.<br>
> <br>
> Pull up #caretColor(:), #selectionColor(:), and #unfocusedSelectionColor(:) from TextMorphForEditView to TextMorph.<br>
> <br>
> =============== Diff against Morphic-mt.1873 ===============<br>
> <br>
> Item was changed:<br>
> ----- Method: StringMorph>>drawOn: (in category 'drawing') -----<br>
> drawOn: aCanvas<br>
> <br>
> + | drawBounds |<br>
> + drawBounds := self innerBounds. "within border, no other (layout) inset"<br>
> + drawBounds := drawBounds origin + (0 @ self fontToUse lineGapSliceForMorphs) corner: drawBounds corner.<br>
> +<br>
> aCanvas<br>
> drawString: self contents<br>
> + in: drawBounds<br>
> - in: self innerBounds<br>
> font: self fontToUse<br>
> color: self color.!<br>
> <br>
> Item was removed:<br>
> - ----- Method: StringMorph>>innerBounds (in category 'geometry - layout') -----<br>
> - innerBounds<br>
> - "Overwritten to respect the receiver's font's #lineGap."<br>
> -<br>
> - | b |<br>
> - b := super innerBounds.<br>
> - ^ b origin + (0 @ self fontToUse lineGapSliceForMorphs) corner: b corner!<br>
> <br>
> Item was changed:<br>
> ----- Method: StringMorph>>launchMiniEditor: (in category 'editing') -----<br>
> launchMiniEditor: evt<br>
> <br>
> | textMorph |<br>
> hasFocus := true. "Really only means edit in progress for this morph"<br>
> textMorph := StringMorphEditor new contentsAsIs: contents.<br>
> + textMorph font: self fontToUse.<br>
> + textMorph color: self color.<br>
> + textMorph innerBounds: self innerBounds.<br>
> - textMorph beAllFont: self fontToUse.<br>
> - textMorph bounds: (self bounds expandBy: 0 at 2).<br>
> self addMorphFront: textMorph.<br>
> evt hand newKeyboardFocus: textMorph.<br>
> textMorph editor selectFrom: 1 to: textMorph paragraph text string size!<br>
> <br>
> Item was removed:<br>
> - ----- Method: StringMorphEditor>>drawOn: (in category 'drawing') -----<br>
> - drawOn: aCanvas<br>
> -<br>
> - aCanvas fillRectangle: self bounds color: Color yellow muchLighter.<br>
> - ^ super drawOn: aCanvas!<br>
> <br>
> Item was changed:<br>
> ----- Method: StringMorphEditor>>initialize (in category 'display') -----<br>
> initialize<br>
> "Initialize the receiver. Give it a white background"<br>
> <br>
> super initialize.<br>
> + self setDefaultParameters.!<br>
> - self backgroundColor: Color white.<br>
> - self textColor: Color red.!<br>
> <br>
> Item was added:<br>
> + ----- Method: StringMorphEditor>>setDefaultParameters (in category 'display') -----<br>
> + setDefaultParameters<br>
> + "Based on PluggableTextMorph >> #setDefaultParameters."<br>
> +<br>
> + self<br>
> + backgroundColor: ((UserInterfaceTheme current get: #color for: #ScrollPane) ifNil: [Color white]);<br>
> + borderStyle: ((UserInterfaceTheme current get: #borderStyle for: #ScrollPane) ifNil: [BorderStyle simple]) copy;<br>
> + borderColor: ((UserInterfaceTheme current get: #borderColor for: #ScrollPane) ifNil: [Color gray: 0.6]);<br>
> + borderWidth: (((UserInterfaceTheme current get: #borderWidth for: #ScrollPane) ifNil: [1]) * RealEstateAgent scaleFactor) truncated.<br>
> +<br>
> + self<br>
> + caretColor: ((UserInterfaceTheme current get: #caretColor for: #PluggableTextMorph) ifNil: [Color red]);<br>
> + selectionColor: ((UserInterfaceTheme current get: #selectionColor for: #PluggableTextMorph) ifNil: [TranslucentColor r: 0.0 g: 0.0 b: 0.8 alpha: 0.2]).<br>
> +<br>
> + self setProperty: #indicateKeyboardFocus toValue: #never.!<br>
> <br>
> Item was added:<br>
> + ----- Method: TextMorph>>caretColor (in category 'accessing') -----<br>
> + caretColor<br>
> + ^ self valueOfProperty: #caretColor ifAbsent: [Color red]!<br>
> <br>
> Item was added:<br>
> + ----- Method: TextMorph>>caretColor: (in category 'accessing') -----<br>
> + caretColor: aColor<br>
> + self<br>
> + setProperty: #caretColor<br>
> + toValue: aColor.!<br>
> <br>
> Item was changed:<br>
> ----- Method: TextMorph>>createParagraph (in category 'private') -----<br>
> createParagraph<br>
> <br>
> self setProperty: #CreatingParagraph toValue: true.<br>
> <br>
> [<br>
> self setDefaultContentsIfNil.<br>
> <br>
> "...Code here to recreate the paragraph..."<br>
> paragraph := (self paragraphClass new textOwner: self owner).<br>
> paragraph wantsColumnBreaks: successor notNil.<br>
> paragraph<br>
> compose: text<br>
> style: textStyle copy<br>
> from: self startingIndex<br>
> in: self container.<br>
> wrapFlag ifFalse:<br>
> ["Was given huge container at first... now adjust"<br>
> paragraph adjustRightX].<br>
> paragraph focused: (self currentHand keyboardFocus == self).<br>
> +<br>
> + paragraph<br>
> + caretColor: self caretColor;<br>
> + selectionColor: self selectionColor;<br>
> + unfocusedSelectionColor: self unfocusedSelectionColor.<br>
> +<br>
> -<br>
> self fit.<br>
> ] ensure: [self removeProperty: #CreatingParagraph].<br>
> <br>
> ^ paragraph!<br>
> <br>
> Item was added:<br>
> + ----- Method: TextMorph>>selectionColor (in category 'accessing') -----<br>
> + selectionColor<br>
> + ^ self valueOfProperty: #selectionColor ifAbsent: [Color blue muchLighter]!<br>
> <br>
> Item was added:<br>
> + ----- Method: TextMorph>>selectionColor: (in category 'accessing') -----<br>
> + selectionColor: aColor<br>
> +<br>
> + self<br>
> + setProperty: #selectionColor<br>
> + toValue: aColor.!<br>
> <br>
> Item was added:<br>
> + ----- Method: TextMorph>>unfocusedSelectionColor (in category 'accessing') -----<br>
> + unfocusedSelectionColor<br>
> + ^ self valueOfProperty: #unfocusedSelectionColor ifAbsent: [Color blue muchLighter]!<br>
> <br>
> Item was added:<br>
> + ----- Method: TextMorph>>unfocusedSelectionColor: (in category 'accessing') -----<br>
> + unfocusedSelectionColor: aColor<br>
> +<br>
> + self<br>
> + setProperty: #unfocusedSelectionColor<br>
> + toValue: aColor.!<br>
> <br>
> Item was removed:<br>
> - ----- Method: TextMorphForEditView>>caretColor (in category 'accessing') -----<br>
> - caretColor<br>
> - ^ self valueOfProperty: #caretColor ifAbsent: [Color red]!<br>
> <br>
> Item was removed:<br>
> - ----- Method: TextMorphForEditView>>caretColor: (in category 'accessing') -----<br>
> - caretColor: aColor<br>
> - self<br>
> - setProperty: #caretColor<br>
> - toValue: aColor.!<br>
> <br>
> Item was removed:<br>
> - ----- Method: TextMorphForEditView>>createParagraph (in category 'private') -----<br>
> - createParagraph<br>
> -<br>
> - super createParagraph.<br>
> -<br>
> - paragraph<br>
> - caretColor: self caretColor;<br>
> - selectionColor: self selectionColor;<br>
> - unfocusedSelectionColor: self unfocusedSelectionColor.<br>
> -<br>
> - ^ paragraph!<br>
> <br>
> Item was removed:<br>
> - ----- Method: TextMorphForEditView>>selectionColor (in category 'accessing') -----<br>
> - selectionColor<br>
> - ^ self valueOfProperty: #selectionColor ifAbsent: [Color blue muchLighter]!<br>
> <br>
> Item was removed:<br>
> - ----- Method: TextMorphForEditView>>selectionColor: (in category 'accessing') -----<br>
> - selectionColor: aColor<br>
> -<br>
> - self<br>
> - setProperty: #selectionColor<br>
> - toValue: aColor.!<br>
> <br>
> Item was removed:<br>
> - ----- Method: TextMorphForEditView>>unfocusedSelectionColor (in category 'accessing') -----<br>
> - unfocusedSelectionColor<br>
> - ^ self valueOfProperty: #unfocusedSelectionColor ifAbsent: [Color blue muchLighter]!<br>
> <br>
> Item was removed:<br>
> - ----- Method: TextMorphForEditView>>unfocusedSelectionColor: (in category 'accessing') -----<br>
> - unfocusedSelectionColor: aColor<br>
> -<br>
> - self<br>
> - setProperty: #unfocusedSelectionColor<br>
> - toValue: aColor.!<br>
> <br>
> <br>
> -------------- next part --------------<br>
> An HTML attachment was scrubbed...<br>
> URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220207/03e562dc/attachment.html><br>
> <br>
> <br>
["passiveLabelColor.png"] </div>
</blockquote>
</div>
</div>
</body>
</html>