<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Hi Marcel,</p>
<p><br>
</p>
<p>when I open three workspaces in a fresh Trunk image now, each of them will have and keep a caret. This is surely a regression, isn't it? :-)</p>
<p><br>
</p>
<p><img size="43704" id="x_img625736" tabindex="0" style="max-width:99.9%" src="cid:0933d5c6-ab91-4023-862d-e1cb08ebc9a5"><br>
</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Montag, 28. Februar 2022 11:19:38<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Trunk: Morphic-mt.1913.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Marcel Taeumel uploaded a new version of Morphic to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Morphic-mt.1913.mcz">http://source.squeak.org/trunk/Morphic-mt.1913.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Morphic-mt.1913<br>
Author: mt<br>
Time: 28 February 2022, 11:19:33.058532 am<br>
UUID: a6a11681-f9b0-4ab7-9da6-a8411611639a<br>
Ancestors: Morphic-mt.1912<br>
<br>
Fixes a regression in text-cursor (i.e. caret) visibility. It is now visible again during type-in, not blinking.<br>
<br>
I removed the extra #hasFocus check in the caret's display routines. Now we notice some inconsistency in caret management when building new paragraphs. There are still some extra carets visible after tool construction I have to figure out. It might be related
to unnecessary editor instances...<br>
<br>
=============== Diff against Morphic-mt.1912 ===============<br>
<br>
Item was changed:<br>
----- Method: NewParagraph>>showCaret (in category 'access') -----<br>
showCaret<br>
+ ^showCaret ifNil:[true]<br>
- ^showCaret ifNil:[false]<br>
!<br>
<br>
Item was changed:<br>
----- Method: TextMorph>>createParagraph (in category 'private') -----<br>
createParagraph<br>
<br>
self setProperty: #CreatingParagraph toValue: true.<br>
<br>
[<br>
self setDefaultContentsIfNil.<br>
<br>
"...Code here to recreate the paragraph..."<br>
paragraph := (self paragraphClass new textOwner: self owner).<br>
paragraph wantsColumnBreaks: successor notNil.<br>
paragraph<br>
compose: text<br>
style: textStyle<br>
from: self startingIndex<br>
in: self container.<br>
wrapFlag ifFalse:<br>
["Was given huge container at first... now adjust"<br>
paragraph adjustRightX].<br>
paragraph focused: (self currentHand keyboardFocus == self).<br>
<br>
paragraph<br>
+ showCaret: self hasFocus;<br>
caretColor: self caretColor;<br>
selectionColor: self selectionColor;<br>
unfocusedSelectionColor: self unfocusedSelectionColor.<br>
<br>
self fit.<br>
] ensure: [self removeProperty: #CreatingParagraph].<br>
<br>
^ paragraph!<br>
<br>
<br>
</div>
</span></font>
</body>
</html>