<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Oh, my. -1 :-)<div><br></div><div>Let's keep menu click and button-bar click consistent. </div><div><br></div><div>We have</div><div>#browseSendersOfMessages ... button bar + popup menu</div><div>#browseSenders ... text/list keyboard shortcuts</div><div><br></div><div>It's confusing enough that there are two paths. What I would agree with is when we spawn a new window for the #<span style="font-size: 10pt">browseSendersOfMessages, which you can easily distinguish via requestor being #modelMenu.</span></div><div><br><div>Best,</div><div>Marcel</div></div><div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 25.02.2022 16:51:30 schrieb commits@source.squeak.org <commits@source.squeak.org>:</p><div style="font-family:Arial,Helvetica,sans-serif">A new version of Tools was added to project The Inbox:<br>http://source.squeak.org/inbox/Tools-ct.1136.mcz<br><br>==================== Summary ====================<br><br>Name: Tools-ct.1136<br>Author: ct<br>Time: 25 February 2022, 4:51:14.742129 pm<br>UUID: d3396d11-145e-294d-b51c-805c6b3b64ab<br>Ancestors: Tools-mt.1135<br><br>Revises senders/implementors in message traces so that:<br><br>* using the buttons always spawns a new window<br>* you can press shift to invert whether the new messages will be appended to the existing window or opened in a new window<br><br>See: http://lists.squeakfoundation.org/pipermail/squeak-dev/2022-February/218946.html<br><br>=============== Diff against Tools-mt.1135 ===============<br><br>Item was changed:<br> ----- Method: MessageTrace>>browseAllCallsOn:requestor: (in category 'actions') -----<br> browseAllCallsOn: selectorSymbol requestor: anObject<br> "Overwritten to modify the trace if the request origins from a model-menu command such as the message-list menu (shortcut)."<br> <br>+ (((Preferences traceMessages and: [anObject ~= #button] and: [selectorSymbol = self selectedMessageName]) xor: Sensor shiftPressed)<br>+ and: [self hasUnacceptedEdits not])<br>- (selectorSymbol = self selectedMessageName<br>- and: [ Preferences traceMessages ] and: [ self hasUnacceptedEdits not ])<br> ifTrue: [ self addParentMethodsSending: selectorSymbol ]<br> ifFalse: [ super browseAllCallsOn: selectorSymbol requestor: anObject ].!<br><br>Item was changed:<br> ----- Method: MessageTrace>>browseAllImplementorsOf:requestor: (in category 'actions') -----<br> browseAllImplementorsOf: selectorSymbol requestor: anObject<br> "Overwritten to modify the trace if the request origins from a model-menu command such as the message-list menu (shortcut)."<br> <br> | selectorToBrowse |<br> selectorToBrowse := self selection <br> ifNil: [ selectorSymbol ] <br> ifNotNil: [ self getImplementorNamed: selectorSymbol asSymbol "since we can get passed literals"].<br>+ (((Preferences traceMessages and: [anObject ~= #button]) xor: Sensor shiftPressed) and: [self hasUnacceptedEdits not])<br>- (Preferences traceMessages and: [ self hasUnacceptedEdits not ])<br> ifTrue: [ self addChildMethodsNamed: selectorToBrowse ]<br> ifFalse: [ super browseAllImplementorsOf: selectorToBrowse requestor: anObject ].!<br><br>Item was added:<br>+ ----- Method: MessageTrace>>browseMessagesFromButton (in category 'controls') -----<br>+ browseMessagesFromButton<br>+ <br>+ self getSelectorAndSendQuery: #browseAllImplementorsOf:requestor: to: self with: #(button).!<br><br>Item was added:<br>+ ----- Method: MessageTrace>>browseSendersOfMessagesFromButton (in category 'controls') -----<br>+ browseSendersOfMessagesFromButton<br>+ <br>+ self getSelectorAndSendQuery: #browseAllCallsOn:requestor: to: self with: #(button).!<br><br>Item was added:<br>+ ----- Method: MessageTrace>>optionalButtonPairs (in category 'controls') -----<br>+ optionalButtonPairs<br>+ <br>+ ^ super optionalButtonPairs collect: [:spec |<br>+ spec second<br>+ caseOf:<br>+ {[#browseSendersOfMessages] -> [spec copy<br>+ at: 2 put: #browseSendersOfMessagesFromButton;<br>+ yourself].<br>+ [#browseMessages] -> [spec copy<br>+ at: 2 put: #browseMessagesFromButton;<br>+ yourself]}<br>+ otherwise: [spec]]!<br><br><br></div></blockquote></div>