<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
> <span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">FYIO: These were no US-only shortcuts.</span><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Well, they were meant to be for a US keyboard layout since no modifier has to be pressed there.</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Best,</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Marcel</span></div><div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 06.04.2022 18:34:57 schrieb christoph.thiede@student.hpi.uni-potsdam.de <christoph.thiede@student.hpi.uni-potsdam.de>:</p><div style="font-family:Arial,Helvetica,sans-serif">
> - No support for US-only [=/-] anymore; was used for text kern +/- 1<br>
<br>
FYIO: These were no US-only shortcuts. In 5.3, opt + 9 was #narrow (not 8), and with Qwertz, opt + shift + 0 was #wide. However, I'm fine with <opt>5 > "Custom attribute...", just as a note. :)<br>
<br>
Do you think we should add menu entries for kerning into the <opt>5 menu?<br>
<br>
Best,<br>
Christoph<br>
<br>
<span style="color: #808080">---<br>
</span><span style="color: #808080"><i>Sent from </i></span><span style="color: #808080"><i><a href="https://github.com/hpi-swa-lab/squeak-inbox-talk"><u><span style="color: #808080">Squeak Inbox Talk</span></u></a></i></span><br>
<br>
On 2022-03-26T15:25:53+00:00, christoph.thiede@student.hpi.uni-potsdam.de wrote:<br>
<br>
> Very nice revisions! I was a bit confused that the shortcut for the emphasis menu has changed - at least this is a breaking change and some of us may have internalized this shortcut -, but the new shortcut makes sense. :-)<br>
> <br>
> <br>
> > - No #narrow anymore (was [8])<br>
> <br>
> Now it is still reachable through <opt>5 > "Custom attribute..." > "TextKern kern: -1", again. :P<br>
> <br>
> <br>
> Best,<br>
> <br>
> Christoph<br>
> <br>
> ________________________________<br>
> Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org><br>
> Gesendet: Freitag, 11. März 2022 10:03:26<br>
> An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org<br>
> Betreff: [squeak-dev] The Trunk: Morphic-mt.1931.mcz<br>
> <br>
> Marcel Taeumel uploaded a new version of Morphic to project The Trunk:<br>
> http://source.squeak.org/trunk/Morphic-mt.1931.mcz<br>
> <br>
> ==================== Summary ====================<br>
> <br>
> Name: Morphic-mt.1931<br>
> Author: mt<br>
> Time: 11 March 2022, 10:03:20.148495 am<br>
> UUID: b4055ef5-466d-604e-be51-2affcbba4e6a<br>
> Ancestors: Morphic-mt.1930<br>
> <br>
> Improves compromise for keyboard shortcuts in TextEditor and SmalltalkTextEditor regarding [CMD]+[0..9]:<br>
> - [1..5] No TextFontChange anymore in TextEditor bc. incompatible with scale factor and TrueType fonts<br>
> - [1..4] still argument name insert in SmalltalkEditor<br>
> - [5] opens emphasis menu (was [6])<br>
> - [6..9] add typical emphases: #bold #italic #underlined #struckOut<br>
> - No #narrow anymore (was [8])<br>
> - [0] still removes those emphases<br>
> - No support for US-only [=/-] anymore; was used for text kern +/- 1<br>
> <br>
> Note that [CTRL]+[0..9] is not affected by this change.<br>
> <br>
> =============== Diff against Morphic-mt.1930 ===============<br>
> <br>
> Item was changed:<br>
> ----- Method: SmalltalkEditor>>changeEmphasis: (in category 'editing keys') -----<br>
> changeEmphasis: characterStream<br>
> + "Change emphasis without styling if necessary. NOTE THAT [cmd]+[1..4] will insert the name of the method argument number n."<br>
> +<br>
> - "Change emphasis without styling if necessary"<br>
> self styler ifNil: [^super changeEmphasis: characterStream].<br>
> ^ self styler evaluateWithoutStyling: [super changeEmphasis: characterStream].!<br>
> <br>
> Item was changed:<br>
> ----- Method: TextEditor class>>initializeCmdKeyShortcuts (in category 'keyboard shortcut tables') -----<br>
> initializeCmdKeyShortcuts<br>
> "Initialize the (unshifted) command-key (or alt-key) shortcut table."<br>
> <br>
> "NOTE: if you don't know what your keyboard generates, use Sensor kbdTest"<br>
> <br>
> "TextEditor initialize"<br>
> <br>
> | cmdMap cmds |<br>
> cmdMap := Array new: 256 withAll: #noop:. "use temp in case of a crash"<br>
> cmdMap at: 1 + 1 put: #cursorHome:. "home key"<br>
> cmdMap at: 4 + 1 put: #cursorEnd:. "end key"<br>
> cmdMap at: 8 + 1 put: #backspace:. "ctrl-H or delete key"<br>
> cmdMap at: 11 + 1 put: #cursorPageUp:. "page up key"<br>
> cmdMap at: 12 + 1 put: #cursorPageDown:. "page down key"<br>
> cmdMap at: 13 + 1 put: #crWithIndent:. "cmd-Return"<br>
> cmdMap at: 27 + 1 put: #offerMenuFromEsc:. "escape key"<br>
> cmdMap at: 28 + 1 put: #cursorLeft:. "left arrow key"<br>
> cmdMap at: 29 + 1 put: #cursorRight:. "right arrow key"<br>
> cmdMap at: 30 + 1 put: #cursorUp:. "up arrow key"<br>
> cmdMap at: 31 + 1 put: #cursorDown:. "down arrow key"<br>
> cmdMap at: 32 + 1 put: #selectWord:. "space bar key"<br>
> cmdMap at: 127 + 1 put: #forwardDelete:. "del key"<br>
> <br>
> + '0123456789'<br>
> - '0123456789-='<br>
> do: [:char | cmdMap at: char asciiValue + 1 put: #changeEmphasis:].<br>
> <br>
> cmds := #($a #selectAll: $c #copySelection: $e #exchange: $f #find: $g #findAgain: $j #doAgain: $k #offerFontMenu: $u #align: $v #paste: $w #backWord: $x #cut: $y #swapChars: $z #undo:).<br>
> 1 to: cmds size<br>
> by: 2<br>
> do: [:i | cmdMap at: (cmds at: i) asciiValue + 1 put: (cmds at: i + 1)].<br>
> <br>
> cmdActions := cmdMap!<br>
> <br>
> Item was changed:<br>
> ----- Method: TextEditor>>changeEmphasis: (in category 'editing keys') -----<br>
> changeEmphasis: aKeyboardEvent<br>
> "Change the emphasis of the current selection or prepare to accept characters with the change in emphasis. Emphasis change amounts to a font change. Keeps typeahead."<br>
> <br>
> + "[cmd]+[0..9]"<br>
> - "control 0..9 -> 0..9"<br>
> <br>
> | keyCode attribute oldAttributes index thisSel colors extras |<br>
> + keyCode := ('0123456789' indexOf: aKeyboardEvent keyCharacter ifAbsent: [1]) - 1.<br>
> - keyCode := ('0123456789-=' indexOf: aKeyboardEvent keyCharacter ifAbsent: [1]) - 1.<br>
> oldAttributes := paragraph text attributesAt: self pointIndex.<br>
> thisSel := self selection.<br>
> <br>
> + "mt: Index-based font changes are not compatible with variable point sizes in text styles. Make room for other shortcuts.<br>
> + (keyCode between: 1 and: 5) ifTrue: [attribute := TextFontChange fontNumber: keyCode]."<br>
> - "Decipher keyCodes for Command 0-9..."<br>
> - (keyCode between: 1 and: 5)<br>
> - ifTrue: [attribute := TextFontChange fontNumber: keyCode].<br>
> <br>
> + keyCode = 5<br>
> - keyCode = 6<br>
> ifTrue: [<br>
> colors := #(#black #magenta #red #yellow #green #blue #cyan #white).<br>
> extras := self emphasisExtras.<br>
> + index := Project uiManager chooseFrom: colors , #('choose color...' ), extras.<br>
> - index := UIManager default chooseFrom:colors , #('choose color...' ), extras<br>
> - lines: (Array with: colors size + 1).<br>
> index = 0 ifTrue: [^true].<br>
> index <= colors size<br>
> ifTrue: [attribute := TextColor color: (Color perform: (colors at: index))]<br>
> ifFalse: [<br>
> index := index - colors size - 1. "Re-number!!!!!!"<br>
> index = 0<br>
> ifTrue: [attribute := self chooseColor]<br>
> ifFalse:[^self handleEmphasisExtra: index with: aKeyboardEvent] "handle an extra"]].<br>
> + (keyCode between: 6 and: 9)<br>
> - (keyCode between: 7 and: 11)<br>
> ifTrue: [<br>
> aKeyboardEvent shiftPressed<br>
> + ifTrue: [ "Cannot be reached bc. method entry is #keyCharacter based and thus dependent on keyboard layout."<br>
> + keyCode = 6 ifTrue: [attribute := TextKern kern: -1].<br>
> + keyCode = 7 ifTrue: [attribute := TextKern kern: 1]]<br>
> - ifTrue: [<br>
> - keyCode = 10 ifTrue: [attribute := TextKern kern: -1].<br>
> - keyCode = 11 ifTrue: [attribute := TextKern kern: 1]]<br>
> ifFalse: [<br>
> + attribute := TextEmphasis<br>
> + perform: (#(#bold #italic #underlined #struckOut) at: keyCode - 5).<br>
> + oldAttributes<br>
> - attribute := TextEmphasis<br>
> - perform: (#(#bold #italic #narrow #underlined #struckOut) at: keyCode - 6).<br>
> - oldAttributes<br>
> do: [:att | (att dominates: attribute) ifTrue: [attribute turnOff]]]].<br>
> keyCode = 0 ifTrue: [attribute := TextEmphasis normal].<br>
> attribute ifNotNil: [<br>
> thisSel size = 0<br>
> ifTrue: [<br>
> "only change emphasisHere while typing"<br>
> self insertTypeAhead.<br>
> emphasisHere := Text addAttribute: attribute toArray: oldAttributes ]<br>
> ifFalse: [<br>
> self replaceSelectionWith: (thisSel asText addAttribute: attribute) ]].<br>
> ^true!<br>
> <br>
> <br>
> -------------- next part --------------<br>
> An HTML attachment was scrubbed...<br>
> URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220326/5d797d27/attachment.html><br>
> <br>
>
</div></blockquote></div>