<body><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
+1<div><br></div><div>> <span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Send from MVC. :-)</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif"><span style="font-size: 13px">Yeah!</span></span></div><div><span style="font-family: Arial, Helvetica, sans-serif"><span style="font-size: 13px"><br></span></span></div><div><span style="font-family: Arial, Helvetica, sans-serif"><span style="font-size: 13px">Best,</span></span></div><div><span style="font-family: Arial, Helvetica, sans-serif"><span style="font-size: 13px">Marcel</span></span></div><div><br></div><div class="mb_sig"></div><blockquote class='history_container' type='cite' style='border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;'>
<p style='color: #AAAAAA; margin-top: 10px;'>Am 05.04.2022 20:32:47 schrieb christoph.thiede@student.hpi.uni-potsdam.de <christoph.thiede@student.hpi.uni-potsdam.de>:</p><div style='font-family:Arial,Helvetica,sans-serif'>Send from MVC. :-)
<br>
<br>=============== Summary ===============
<br>
<br>Change Set: cleanUpChangeSorterSetMenu
<br>Date: 5 April 2022
<br>Author: Christoph Thiede
<br>
<br>Cleans up change set menu of change sorter. Remove Morphic-specific hack for controlling the position of Monticello item and split up the main menu to user pragma priorities instead. In particular, this fixes the menuBuilder failure in MVC.
<br>
<br>=============== Diff ===============
<br>
<br>ChangeSorter>>monticelloChangeSetMenu: {*Monticello-changeSet menu} · ct 4/5/2022 19:26 (changed)
<br>monticelloChangeSetMenu: aMenu
<br> <changesetmenushifted: false="">
<br> <menupriority: 600="">
<br>- "Sigh, when implementing menu pragmas this is not what I had in mind..."
<br>- aMenu add: 'delete Monticello load change sets' action: #deleteMonticelloChangeSets.
<br>- (aMenu submorphs
<br>- detect: [:m| m isMenuItemMorph and: [m contents beginsWith: 'destroy change set']]
<br>- ifNone: []) ifNotNil:
<br>- [:destroyItem| | item |
<br>- aMenu removeMorph: (item := aMenu submorphs last).
<br>- aMenu addMorph: item after: destroyItem].
<br>+ aMenu add: 'delete Monticello load change sets' translated action: #deleteMonticelloChangeSets.
<br> ^aMenu
<br>
<br>ChangeSorter>>shiftedChangeSetMenu: {changeSet menu} · ct 4/5/2022 20:26 (changed)
<br>shiftedChangeSetMenu: aMenu
<br> "Set up aMenu to hold items relating to the change-set-list pane when the shift key is down"
<br>
<br> <changesetmenushifted: true="">
<br>
<br> aMenu title: 'Change set (shifted)' translated.
<br> aMenu addStayUpItemSpecial.
<br>
<br> "CONFLICTS SECTION"
<br> aMenu add: 'conflicts with other change sets' translated action: #browseMethodConflicts.
<br> aMenu balloonTextForLastItem:
<br>'Browse all methods that occur both in this change set and in at least one other change set.' translated.
<br> self changeSetMenuForOpposite: aMenu.
<br> aMenu addLine.
<br>
<br> "CHECKS SECTION"
<br> aMenu add: 'check for slips' translated action: #lookForSlips.
<br> aMenu balloonTextForLastItem:
<br>'Check this change set for halts and references to Transcript.' translated.
<br>
<br> aMenu add: 'check for unsent messages' translated action: #checkForUnsentMessages.
<br> aMenu balloonTextForLastItem:
<br>'Check this change set for messages that are not sent anywhere in the system' translated.
<br>
<br> aMenu add: 'check for uncommented methods' translated action: #checkForUncommentedMethods.
<br> aMenu balloonTextForLastItem:
<br>'Check this change set for methods that do not have comments' translated.
<br>
<br> aMenu add: 'check for uncommented classes' translated action: #checkForUncommentedClasses.
<br> aMenu balloonTextForLastItem:
<br>'Check for classes with code in this changeset which lack class comments' translated.
<br>
<br> Utilities authorInitialsPerSe isEmptyOrNil ifFalse:
<br> [aMenu add: 'check for other authors' translated action: #checkForAlienAuthorship.
<br> aMenu balloonTextForLastItem:
<br>('Check this change set for methods whose current authoring stamp does not start with "{1}"' translated format: {Utilities authorInitials}).
<br>
<br> aMenu add: 'check for any other authors' translated action: #checkForAnyAlienAuthorship.
<br> aMenu balloonTextForLastItem:
<br>('Check this change set for methods any of whose authoring stamps do not start with "{1}"' translated format: {Utilities authorInitials})].
<br>
<br> aMenu add: 'check for uncategorized methods' translated action: #checkForUnclassifiedMethods.
<br> aMenu balloonTextForLastItem:
<br>'Check to see if any methods in the selected change set have not yet been assigned to a category. If any are found, open a browser on them.' translated.
<br> aMenu addLine.
<br>
<br> aMenu add: 'inspect change set' translated action: #inspectChangeSet.
<br> aMenu balloonTextForLastItem:
<br>'Open an inspector on this change set. (There are some details in a change set which you don''t see in a change sorter.)' translated.
<br>
<br> aMenu add: 'update' translated action: #update.
<br> aMenu balloonTextForLastItem:
<br>'Update the display for this change set. (This is done automatically when you activate this window, so is seldom needed.)' translated.
<br>
<br> aMenu add: 'go to change set''s project' translated action: #goToChangeSetsProject.
<br> aMenu balloonTextForLastItem:
<br>'If this change set is currently associated with a Project, go to that project right now.' translated.
<br>
<br> self changeSetMenuForPromote: aMenu.
<br>
<br> aMenu add: 'trim history' translated action: #trimHistory.
<br> aMenu balloonTextForLastItem:
<br>' Drops any methods added and then removed, as well as renaming and reorganization of newly-added classes. NOTE: can cause confusion if later filed in over an earlier version of these changes' translated.
<br>
<br> self changeSetMenuForDropInClassCats: aMenu.
<br>
<br> aMenu add: 'clear this change set' translated action: #clearChangeSet.
<br> aMenu balloonTextForLastItem:
<br>'Reset this change set to a pristine state where it holds no information. CAUTION: this is destructive and irreversible!' translated.
<br> aMenu add: 'expunge uniclasses' translated action: #expungeUniclasses.
<br> aMenu balloonTextForLastItem:
<br>'Remove from the change set all memory of uniclasses, e.g. classes added on behalf of etoys, fabrik, etc., whose classnames end with a digit.' translated.
<br>
<br> aMenu add: 'uninstall this change set' translated action: #uninstallChangeSet.
<br> aMenu balloonTextForLastItem:
<br>'Attempt to uninstall this change set. CAUTION: this may not work completely and is irreversible!' translated.
<br>
<br> self changeSetMenuForModification: aMenu.
<br>-
<br>- aMenu addLine.
<br>-
<br>- aMenu add: 'more...' translated action: #offerUnshiftedChangeSetMenu.
<br>- aMenu balloonTextForLastItem:
<br>- 'Takes you back to the primary change-set menu.' translated.
<br>-
<br>+
<br> ^ aMenu
<br>
<br>ChangeSorter>>shiftedChangeSetMore: {changeSet menu} · ct 4/5/2022 20:11
<br>+ shiftedChangeSetMore: aMenu
<br>+ <changesetmenushifted: false="">
<br>+ <menupriority: 1000="">
<br>+ ^ aMenu addTranslatedList: #(
<br>+ -
<br>+ ('more...' offerShiftedChangeSetMenu));
<br>+ yourself
<br>
<br>ChangeSorter>>unshiftedChangeSetMenu: {changeSet menu} · ct 4/5/2022 19:24 (changed)
<br>unshiftedChangeSetMenu: aMenu
<br> "Set up aMenu to hold commands for the change-set-list pane. This could be for a single or double changeSorter"
<br> <changesetmenushifted: false="">
<br> Smalltalk isMorphic
<br> ifTrue:
<br> [aMenu title: 'Change Set' translated]
<br> ifFalse:
<br> [aMenu title: 'Change Set:
<br>' translated , myChangeSet name].
<br> aMenu addStayUpItemSpecial.
<br>
<br> aMenu add: 'make changes go to me (m)' translated action: #newCurrent.
<br> aMenu addLine.
<br> aMenu add: 'new change set... (n)' translated action: #newSet.
<br> aMenu add: 'find...(f)' translated action: #findCngSet.
<br> aMenu add: 'select change set...' translated action: #chooseCngSet.
<br> aMenu addLine.
<br> aMenu add: 'rename change set (r)' translated action: #rename.
<br> aMenu add: 'file out (o)' translated action: #fileOut.
<br> aMenu add: 'mail to list' translated action: #mailOut.
<br> aMenu add: 'browse methods (b)' translated action: #browseChangeSet.
<br> aMenu add: 'browse change set (B)' translated action: #openChangeSetBrowser.
<br> aMenu addLine.
<br> parent
<br> ifNotNil:
<br> [aMenu add: 'copy all to other side (c)' translated action: #copyAllToOther.
<br> aMenu add: 'submerge into other side' translated action: #submergeIntoOtherSide.
<br> aMenu add: 'subtract other side (-)' translated action: #subtractOtherSide.
<br> aMenu addLine].
<br> myChangeSet hasPreamble
<br> ifTrue:
<br> [aMenu add: 'edit preamble... (p)' translated action: #editPreamble.
<br> aMenu add: 'remove preamble' translated action: #removePreamble]
<br> ifFalse: [aMenu add: 'add preamble... (p)' translated action: #editPreamble].
<br> myChangeSet hasPostscript
<br> ifTrue:
<br> [aMenu add: 'edit postscript...' translated action: #editPostscript.
<br> aMenu add: 'remove postscript' translated action: #removePostscript]
<br> ifFalse: [aMenu add: 'add postscript...' translated action: #editPostscript].
<br> aMenu addLine.
<br>
<br> aMenu add: 'destroy change set (x)' translated action: #remove.
<br>- aMenu addLine.
<br>- aMenu add: 'more...' translated action: #offerShiftedChangeSetMenu.
<br> ^ aMenu
<br>
<br>ChangeSorter>>unshiftedChangeSetMore: {changeSet menu} · ct 4/5/2022 20:25
<br>+ unshiftedChangeSetMore: aMenu
<br>+ <changesetmenushifted: true="">
<br>+ <menupriority: 1000="">
<br>+ ^ aMenu addTranslatedList: #(
<br>+ -
<br>+ ('more...' offerUnshiftedChangeSetMenu 'Takes you back to the primary change-set menu.'));
<br>+ yourself
<br>
<br>
<br>["cleanUpChangeSorterSetMenu.cs.gz"]
<br><br></menupriority:></changesetmenushifted:></changesetmenushifted:></menupriority:></changesetmenushifted:></changesetmenushifted:></menupriority:></changesetmenushifted:></div></blockquote>
</div></body>