<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Hi Marcel,</p>
<p><br>
</p>
<p>thank you! In doubt, I would always use #allSubInstancesDo: instead of #allInstancesDo: for the same reason we (almost) always use #isKindOf: rather than #isMemberOf: - because any subclass might just be an implementation detail of the original protocol.
I think this is an amount of speculative generality that does not hurt. :-) There are indeed some subclasses of Workspace (e.g., I think TruffleSqueak does this), and by default, their styling should just work like in any normal workspace.</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Dienstag, 26. April 2022 13:52:15<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: Tools-ct.1147.mcz</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Christoph --
<div class="mb_sig"></div>
<div><br>
</div>
<div>There are no subclasses of Workspace. I am not sure whether we even want to encourage to have some. At least not in this way. Hmm... #allInstancesDo: should be sufficient for this purpose.</div>
<div><br>
</div>
<div>Anyway: +1 :)</div>
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div><br>
</div>
<div><br>
</div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 26.04.2022 12:12:48 schrieb commits@source.squeak.org <commits@source.squeak.org>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">A new version of Tools was added to project The Inbox:<br>
http://source.squeak.org/inbox/Tools-ct.1147.mcz<br>
<br>
==================== Summary ====================<br>
<br>
Name: Tools-ct.1147<br>
Author: ct<br>
Time: 26 April 2022, 12:12:36.942702 pm<br>
UUID: 11944f29-f575-7b41-824d-71e945afa0d2<br>
Ancestors: Tools-tpr.1146<br>
<br>
Updates workspace styles after toggling #shouldStyle preference. This also improves the liveness in the preference wizard.<br>
<br>
=============== Diff against Tools-tpr.1146 ===============<br>
<br>
Item was changed:<br>
----- Method: Workspace class>>shouldStyle: (in category 'preferences') -----<br>
shouldStyle: aBoolean<br>
<br>
+ ShouldStyle := aBoolean.<br>
+ <br>
+ self allSubInstancesDo: [:workspace | workspace changed: #style].!<br>
- ShouldStyle := aBoolean!<br>
<br>
<br>
</div>
</blockquote>
</div>
</div>
</body>
</html>