<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Thanks for the feedback and merging this via <span>ST80-mt.284. :-)</span></p>
<p><span><br>
</span></p>
<p><span>Best,</span></p>
<p><span>Christoph</span></p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Freitag, 8. April 2022 09:45:48<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] Review Request: mvcLineLengthDialogs.1.cs</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
<span style="background-color: rgb(255, 255, 255);">Hi Christoph --</span>
<div><span style="background-color: rgb(255, 255, 255);"><br>
</span></div>
<div><span style="background-color: rgb(255, 255, 255);">> <span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">withNoLineLongerThan: 100</span></span></div>
<div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px;background-color: rgb(255, 255, 255)"><br>
</span></div>
<div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px;background-color: rgb(255, 255, 255)">Make that 45 or 65, please. Especially if it is a Text, not a String.</span></div>
<div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px;background-color: rgb(255, 255, 255)"><br>
</span></div>
<div><span style="font-family: Arial, Helvetica, sans-serif"><span style="font-size: 13px">Best,</span></span></div>
<div><span style="font-family: Arial, Helvetica, sans-serif"><span style="font-size: 13px">Marcel</span></span></div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 08.04.2022 09:44:03 schrieb Marcel Taeumel <marcel.taeumel@hpi.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Christoph --
<div><br>
</div>
<div>+1</div>
<div><br>
</div>
<div>There also is a constant in TextConstants that defines this centered style in MVC pop-ups. Maybe we should change it to leftFlush? Would also affect menus, I think.</div>
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 05.04.2022 19:31:13 schrieb christoph.thiede@student.hpi.uni-potsdam.de <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif"><b>=============== Summary ===============</b><br>
<br>
Change Set: mvcLineLengthDialogs<br>
Date: 5 April 2022<br>
Author: Christoph Thiede<br>
<br>
Adds a line-length limit to MVC dialogs. Complements Morphic-mt.1935. Due to the recent elimination of #withCRs in many places, this change has been overdue for an even longer time.<br>
<br>
Example (to be run in an MVC project):<br>
self inform: Object comment<br>
<br>
<br>
<b>=============== Diff ===============</b><br>
<br>
<b>MVCUIManager>>informUser:during: {ui requests} · ct 4/5/2022 19:14 (changed)</b><br>
<s><span style="color: #0000FF">- informUser: aString during: aBlock<br>
</span></s><span style="color: #FF0000">+ informUser: aStringOrText during: aBlock<br>
</span> "Display a message above (or below if insufficient room) the cursor <br>
during execution of the given block.<br>
<s><span style="color: #0000FF">- UIManager default informUser: 'Just a sec!' during: [(Delay forSeconds: 1) wait].<br>
</span></s><span style="color: #FF0000">+ Project uiManager informUser: 'Just a sec!' during: [1 second wait].<br>
</span> "<br>
(SelectionMenu labels: '')<br>
displayAt: Sensor cursorPoint<br>
<s><span style="color: #0000FF">- withCaption: aString<br>
</span></s><span style="color: #FF0000">+ withCaption: (aStringOrText ifNotNil: [aStringOrText withNoLineLongerThan: 100])<br>
</span> during: aBlock<br>
<br>
<b>PopUpMenu>>mvcStartUpWithCaption:icon:at:allowKeyboard: {*ST80-Menus} · ct 4/5/2022 19:10 (changed)</b><br>
mvcStartUpWithCaption: captionOrNil icon: aForm at: location allowKeyboard: aBoolean<br>
"Display the menu, with caption if supplied. Wait for the mouse button to go down, then track the selection as long as the button is pressed. When the button is released,<br>
Answer the index of the current selection, or zero if the mouse is not released over any menu item. Location specifies the desired topLeft of the menu body rectangle. The final argument indicates whether the menu should seize the keyboard focus in order
to allow the user to navigate it via the keyboard."<br>
<br>
frame ifNil: [self computeForm].<br>
Cursor normal showWhile:<br>
[self<br>
displayAt: location<br>
<s><span style="color: #0000FF">- withCaption: captionOrNil<br>
</span></s><span style="color: #FF0000">+ withCaption: (captionOrNil ifNotNil: [captionOrNil withNoLineLongerThan: 100])<br>
</span> during: [self controlActivity]].<br>
^ selection<br>
<br>
<span style="color: #808080">---<br>
</span><span style="color: #808080"><i>Sent from </i></span><span style="color: #808080"><i><a href="https://github.com/hpi-swa-lab/squeak-inbox-talk"><u><span style="color: #808080">Squeak Inbox Talk</span></u></a></i></span><br>
["mvcLineLengthDialogs.1.cs"]<br>
["mvcLineLengthDialogs.png"] </div>
</blockquote>
</div>
</div>
</blockquote>
</div>
</div>
</body>
</html>