<body><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
> <span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">I never found it intuitive that something becomes italic because you forget a missing quote.</span><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px"><br></span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">Because you are better with colors than some of us? =)</span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px"><br></span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">Best,</span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">Marcel</span></div><div class="mb_sig"></div><blockquote class='history_container' type='cite' style='border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;'>
<p style='color: #AAAAAA; margin-top: 10px;'>Am 16.05.2022 18:12:38 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p><div style='font-family:Arial,Helvetica,sans-serif'>
<div id="divtagdefaultwrapper" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif" dir="ltr">
<p>Hi all,</p>
<p><br>
</p>
<p>-0.5. :-)</p>
<p><br>
</p>
<p>No ultra-strong opinion here, but in general, comments are an inherent part of Smalltalk. As code and comments tell a shared story together, I'm not convinced by separating both from each other even more. Italic has a "virtual", "artificial", or "auxiliary"
connotation to me, as opposed to "normal" or "real" code.</p>
<p><br>
</p>
<p>Regarding unterminated comments, which are rendered as italic indeed at the moment, I never found it intuitive that something becomes italic because you forget a missing quote. Maybe we could remove this emphasis as well. We also do not apply special emphasis
to unterminated expressions with a missing closing bracket.</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Montag, 16. Mai 2022 17:05:23<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] Improving visibility of comments in Shout renders code within SqueakTheme</span>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Lauren, hi Dave, hi Tim --
<div><br>
</div>
<div>Well, I am not strongly against this (anymore) since we fixed italic rendering at least for TrueType fonts.</div>
<div><br>
</div>
<div>I am leaning towards adding an "italic comments" preference as I like the current appearance... Hmm....</div>
<div><br>
</div>
<div>Note that the effect of an invalid Shout identifier would then not be so strong anymore. Red and italic are current indications of that.</div>
<div><br>
</div>
<div>Well, the "Community (dark)" theme does this already.</div>
<div><br>
</div>
<div>+/- 0 :-)</div>
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 14.05.2022 16:44:59 schrieb David T. Lewis <lewis@mail.msen.com>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">Adding the italics to the comment font looks good to me also.<br>
<br>
Dave<br>
<br>
On Fri, May 13, 2022 at 04:02:21PM -0600, Lauren P wrote:<br>
> Seconded.<br>
> <br>
> On Fri, May 13, 2022, 11:24 tim Rowledge <tim@rowledge.org>wrote:<br>
> <br>
> > I find it very hard to discern the colour used by Shout for comments in<br>
> > the SqueakTheme. I would like to suggest that we change to make it italic<br>
> > as well as coloured.<br>
> ><br>
> > If we edit SqueakTheme class>>#addSyntaxHighlighting: where we set the<br>
> > comment style -<br>
> > set: #comment for: #SHTextStylerST80 to: {Color cyan<br>
> > muchDarker. TextEmphasis italic};<br>
> ><br>
> > and then run `self create apply` in the browser then things are more<br>
> > visible.<br>
> ><br>
> > tim<br>
> > --<br>
> > tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim<br>
> > Trancelators interpret messages from the dead<br>
> ><br>
> ><br>
> ><br>
> ><br>
<br>
> <br>
<br>
<br>
</tim@rowledge.org></div>
</blockquote>
</div>
</div>
</div></blockquote>
</div></body>