<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta content="text/html; charset=utf-8">
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="display:none">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div id="divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Commented and merged. :-)</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Dienstag, 17. Mai 2022 13:20:35<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: Tools-ct.1158.mcz</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" dir="ltr" style="font-size:10pt; font-family:Arial; color:#000000; text-align:left">
Please add commentary to the source code.
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style:solid; border-width:1px; margin-top:20px; margin-left:0px; padding-left:10px">
<p style="color:#AAAAAA; margin-top:10px">Am 17.05.2022 13:04:50 schrieb commits@source.squeak.org <commits@source.squeak.org>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">A new version of Tools was added to project The Inbox:<br>
http://source.squeak.org/inbox/Tools-ct.1158.mcz<br>
<br>
==================== Summary ====================<br>
<br>
Name: Tools-ct.1158<br>
Author: ct<br>
Time: 17 May 2022, 1:04:37.206327 pm<br>
UUID: 1cb879ce-2df7-174b-b4ba-d443e4fdc011<br>
Ancestors: Tools-mt.1157<br>
<br>
Do not update process browsers from inactive projects. Before this fix, an auto-updating process browser from a Morphic project would raise periodic errors after entering an MVC project, and an auto-updating process browser from a MVC project would cause spooky
screen updates after entering a Morphic project.<br>
<br>
Note that a better solution strategy would consist of something like StepMessages for MVC, which however do not exist as of today.<br>
<br>
=============== Diff against Tools-mt.1157 ===============<br>
<br>
Item was changed:<br>
----- Method: ProcessBrowser>>startAutoUpdate (in category 'updating') -----<br>
startAutoUpdate<br>
self isAutoUpdatingPaused<br>
ifTrue: [^ autoUpdateProcess resume].<br>
+ self isAutoUpdating ifFalse:<br>
+ [| project |<br>
+ project := Project current.<br>
+ autoUpdateProcess :=<br>
+ [[[self hasView] whileTrue:<br>
+ [2 seconds wait.<br>
+ project addDeferredUIMessage: [self updateProcessList]].<br>
+ autoUpdateProcess := nil]<br>
+ ensure: [self removeActionsForEvent: #aboutToEnterWorld]] fork.<br>
+ project world<br>
+ when: #aboutToLeaveWorld send: #pauseAutoUpdate to: self;<br>
+ when: #aboutToEnterWorld send: #startAutoUpdate to: self].<br>
+ self updateProcessList.!<br>
- self isAutoUpdating<br>
- ifFalse: [autoUpdateProcess := [[self hasView]<br>
- whileTrue: [(Delay forSeconds: 2) wait.<br>
- Project current addDeferredUIMessage: [self updateProcessList]].<br>
- autoUpdateProcess := nil] fork].<br>
- self updateProcessList<br>
- !<br>
<br>
<br>
</div>
</blockquote>
</div>
</div>
</body>
</html>