<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Hi Marcel,</p>
<p><br>
</p>
<p>but this would still leave a chance that we miss any historic states. My proposal is a bit more radical in this regard, but it makes sure that we have a consistent and deterministic set of preference values ... What problems would you concretely see with
that? The only visible effect should be that in a freshly generated image, the default button in the preference browser does not change any preferences to ancient defaults. :-)</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Samstag, 21. Mai 2022 04:07:30<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] Default preferences</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
<span style="font-family: Calibri, sans-serif;font-size: 14.6667px">> </span><span style="font-family: Calibri, sans-serif;font-size: 12pt">my proposal would be that we set all Preferences' defaultValues to their value during the release building</span><br>
<div><span style="font-family: Calibri, sans-serif;font-size: 12pt"><br>
</span></div>
<div><span style="font-family: Calibri, sans-serif;font-size: 12pt">This would be kind of dangerous and difficult to manage regarding a proper base image for the CI (i.e., the bundles). I think we should rather uncover what is not yet set in ReleaseBuilder
class >> #setPreferences and fill in the gaps. That's makes it explicit. For those values, we can surely set the defaults for old-style preferences.</span></div>
<div><span style="font-family: Calibri, sans-serif;font-size: 12pt"><br>
</span></div>
<div><span style="font-family: Calibri, sans-serif;font-size: 12pt">Best,</span></div>
<div><span style="font-family: Calibri, sans-serif;font-size: 12pt">Marcel</span></div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 20.05.2022 06:55:47 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div id="divtagdefaultwrapper" style="font-size: 12pt;color: rgb(0, 0, 0);font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols" dir="ltr">
<p>Hi Jaromir, hi all,</p>
<p><br>
</p>
<p>thanks for finding this! This is insane. I suppose that no one in the last years has ever pressed this "default" button and thus this inconsistency was never found.</p>
<p><br>
</p>
<p>We seem to have two sources of truth here:</p>
<p>1. The default value of each preference:</p>
<p> 1a. For pragma preferences, this is encoded in the getter of the preference (i.e., <span>Model class>>#useColorfulWindows falls back to true).</span></p>
<p><span> 1b. For old-style preferences, this is the defaultValue variable of the preference instance (this is not encoded anywhere, just historic instances that have been handed down since years or decades via the release images like the Olympic torch). See
<span>Preferences preferenceAt: #fastDragWindowForMorphic for example.</span><span></span></span></p>
<p><span><span>2. The default values encoded in the <span>ReleaseBuilder (or actually, the ReleaseBuilders, since this thing is even subclassed), see #setPreferences. For instance, here #useColorfulWindows is set to false.</span></span></span></p>
<p><span><span><span><br>
</span></span></span></p>
<p><span><span><span>This is really crazy. I feel like traveling ten years back in time after clicking that button. I don't know how we should solve the two sources of truth problem, but my proposal would be that we set all Preferences' defaultValues to their
value during the release building - how do you think about that? Would some others agree with that? If yes, I can implement & upload that.</span></span></span></p>
<p><span><span><span><br>
</span></span></span></p>
<p><span><span><span>> <span>A theme is not a 'preference', despite the Preference Wizard sets it, right? (slightly confusing but ok)</span></span></span></span></p>
<p><span><span><span><span><br>
</span></span></span></span></p>
<p><span><span><span><span>Yes. The Preference Wizard does not display all preferences, but it also provides access to some other options. For instance, the preference browser also does not have logic for installing recommended packages. :-)</span></span></span></span></p>
<p><span><span><span><span><br>
</span></span></span></span></p>
<p>Best,</p>
<p>Christoph</p>
<p></p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Jaromir Matas <mail@jaromir.net><br>
<b>Gesendet:</b> Freitag, 20. Mai 2022 10:03:23<br>
<b>An:</b> Squeak Dev<br>
<b>Betreff:</b> [squeak-dev] Default preferences</span>
<div> </div>
</div>
<div>
<div class="WordSection1">
<p class="MsoNormal">Hi All,</p>
<p class="MsoNormal">A quick question: What are the 'default preferences'? </p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I thought they were the ones the fresh image comes with but when you open a Preference Browser and hit the 'default' button you get another set of preferences (round buttons, colorful windows etc.) – is this a bug? Is there a way to get
back to the preferences the image comes with?</p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">A theme is not a 'preference', despite the Preference Wizard sets it, right? (slightly confusing but ok) (BTW the Community Dark theme is awesome! Even italic comments :) Using it all the time)</p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Also, if I check the 'English' tick-box in Extras -> Language, the flaps show (that must be a bug).</p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Best,</p>
<p class="MsoNoSpacing"><span lang="CS">--</span></p>
<p class="MsoNoSpacing"><strong><span style="font-family:"Calibri Light",sans-serif;color:#333333;font-weight:normal">Jaromír Matas</span></strong><span style="font-family:"Calibri Light",sans-serif;color:#555555"><o:p></o:p></span></p>
<p class="MsoNoSpacing"><span style="font-family:"Calibri Light",sans-serif;color:#2E75B6">mail@jaromir.net</span></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</body>
</html>