<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi Marcel,<div class=""><br class=""></div><div class=""><div>OK. Please feel free to delete from inbox.</div><div><br class=""></div><div>Thanks for your attention to this.</div><div><br class=""></div><div>Tim</div><div><br class=""></div><div><br class=""><blockquote type="cite" class=""><div class="">On Jun 9, 2022, at 1:57 AM, Marcel Taeumel <<a href="mailto:marcel.taeumel@hpi.de" class="">marcel.taeumel@hpi.de</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div id="__MailbirdStyleContent" style="font-size: 10pt; font-family: Arial; text-align: left;" dir="ltr" class="">
Hi Tim --<div class=""><br class=""></div><div class="">-100 for replacing "self activate" with "<span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px" class="">self submorphsDo: [:morph | morph unlock]"</span></div><div class=""><br class=""></div><div class=""><span style="font-size: 10pt" class="">I took quite some effort to make that active/inactive window stuff maintainable. We should not obfuscate the code again this way. Yet, I hear your concern that some configurations struggle with Morphic window drag. We have to find a solution that is better than exposing unmaintainable implementation details again.</span><br class=""></div><div class=""><span style="font-size: 10pt" class=""><br class=""></span></div><div class=""><span style="font-size: 10pt" class="">Best,</span></div><div class=""><span style="font-size: 10pt" class="">Marcel</span></div><div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px"><p style="color: #AAAAAA; margin-top: 10px;" class="">Am 06.06.2022 08:27:31 schrieb <a href="mailto:commits@source.squeak.org" class="">commits@source.squeak.org</a> <<a href="mailto:commits@source.squeak.org" class="">commits@source.squeak.org</a>>:</p><div style="font-family:Arial,Helvetica,sans-serif" class="">A new version of Morphic was added to project The Inbox:<br class=""><a href="http://source.squeak.org/inbox/Morphic-tcj.2000.mcz" class="">http://source.squeak.org/inbox/Morphic-tcj.2000.mcz</a><br class=""><br class="">==================== Summary ====================<br class=""><br class="">Name: Morphic-tcj.2000<br class="">Author: tcj<br class="">Time: 5 June 2022, 11:27:16.56143 pm<br class="">UUID: c9b2a85f-cde3-453b-9cb9-898c3420bc07<br class="">Ancestors: Morphic-mt.1999<br class=""><br class="">Optimize dragging into SystemWindows by not performing a complete 'activate' on mouse enter (which includes waking up the model and redrawing all submorphs & text). Also, fix typo in another method comment.<br class=""><br class="">=============== Diff against Morphic-mt.1999 ===============<br class=""><br class="">Item was changed:<br class=""> ----- Method: SystemWindow>>mouseEnterDragging: (in category 'events') -----<br class=""> mouseEnterDragging: evt<br class=""> "unlock children for drop operations"<br class=""> <br class=""> self flag: #performance. "mt: There may be no need to change appearance if no widget wants the drop."<br class=""> self isActive ifTrue: [self lookFocused].<br class=""> <br class=""> (self isActive not and: [evt hand hasSubmorphs]) ifTrue: [<br class="">+ self submorphsDo: [:morph | morph unlock]. "unlock contents for drop"<br class="">- self activate. "unlock contents for drop"<br class=""> evt hand addMouseListener: self. "for drop completion on submorph"<br class=""> ].!<br class=""><br class="">Item was changed:<br class=""> ----- Method: SystemWindow>>startDragFromLabel: (in category 'events') -----<br class=""> startDragFromLabel: evt<br class="">+ "When label events are active, we need to pass dragging to the window explicitly.<br class="">- "When label events are active, we need to pass dragging to the window explicitely<br class=""> The window only recognizes a drag with an offset of more than 3 pixels"<br class=""> <br class=""> self isSticky ifTrue: [^ self].<br class=""> self fastFramingOn <br class=""> ifTrue: [self doFastFrameDrag: evt cursorPoint]<br class=""> ifFalse: [<br class=""> self hasDropShadow: false.<br class=""> evt hand grabMorph: self topRendererOrSelf]<br class=""> !<br class=""><br class=""><br class=""></div></blockquote></div><br class=""></div></blockquote></div><br class=""></div></body></html>