<div dir="ltr"><div>Ok, fair enough.</div><div><br></div><div>Best,</div><div>Karl<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 9, 2022 at 10:46 AM Marcel Taeumel <<a href="mailto:marcel.taeumel@hpi.de">marcel.taeumel@hpi.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div id="gmail-m_8478082442129411891__MailbirdStyleContent" style="font-size:10pt;font-family:Arial;color:rgb(0,0,0);text-align:left" dir="ltr">
Hi Karl --<div><br></div><div>I do not agree with this fix here. For example, the System Browser window answers "false" for #dropEnabled but some of its lists do accept drops.</div><div><br></div><div>-1</div><div><br></div><div>It seems to be a matter of granularity. Hmm... we would need a quick check for "does any of my sub(sub)morphs accept that drop?" Just asking the window itself is not enough. Regular event handling primarily works bottom to top, not the other way around.</div><div><br></div><div>Best,</div><div>Marcel</div><div></div>
<blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-top:20px;margin-left:0px;padding-left:10px;min-width:500px">
<p style="color:rgb(170,170,170);margin-top:10px">Am 06.06.2022 11:36:18 schrieb <a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a> <<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>>:</p><div style="font-family:Arial,Helvetica,sans-serif">A new version of Morphic was added to project The Inbox:<br><a href="http://source.squeak.org/inbox/Morphic-kfr.2002.mcz" target="_blank">http://source.squeak.org/inbox/Morphic-kfr.2002.mcz</a><br><br>==================== Summary ====================<br><br>Name: Morphic-kfr.2002<br>Author: kfr<br>Time: 6 June 2022, 11:35:56.143783 am<br>UUID: 3700dde9-4ef0-c84e-a342-23f649a554e3<br>Ancestors: Morphic-kfr.2001<br><br>Don't activate SystemWindows on drags events it doesn't want<br><br>=============== Diff against Morphic-kfr.2001 ===============<br><br>Item was changed:<br> ----- Method: SystemWindow>>mouseEnterDragging: (in category 'events') -----<br> mouseEnterDragging: evt<br> "unlock children for drop operations"<br> <br>+ | textDnD |<br> self flag: #performance. "mt: There may be no need to change appearance if no widget wants the drop."<br>+ <br>+ textDnD := false.<br>+ evt hand hasSubmorphs ifTrue:[textDnD := evt hand firstSubmorph isTransferMorph]. "Workaround: We sometimes get this event triggered when there is no submorph to the hand"<br>+ (textDnD or:[self dropEnabled]) ifFalse: ["if both are false there is no d&d"<br>+ ^super mouseEnterDragging: evt].<br>+ <br> self isActive ifTrue: [self lookFocused].<br> <br> (self isActive not and: [evt hand hasSubmorphs]) ifTrue: [<br> self activate. "unlock contents for drop"<br> evt hand addMouseListener: self. "for drop completion on submorph"<br> ].!<br><br><br></div></blockquote></div><br>
</blockquote></div>