<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Eliot --<div><br></div><div>> <span style="font-family: Arial, Helvetica, sans-serif;font-size: 10pt">But lookup: *always* interns:</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 10pt"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 10pt">No, it does not. </span><span style="font-size: 10pt">You should use #lookup: instead. It has the very same semantics as #findInterned:.</span></div><div><br></div><div>In any case, I will re-load 60Deprecated again into Trunk so that you can keep your code unchanged. We can then discuss the benefit of having two identical methods for the same thing.</div><div><br></div><div>#lookup: has the better wording and hides implementation details.</div><div>#findInterned: leaks the implementation detail of "internalization"</div><div><br></div><div>#asSymbol always interns. #lookup: does not.</div><div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 15.06.2022 00:27:54 schrieb Eliot Miranda <eliot.miranda@gmail.com>:</p><div style="font-family:Arial,Helvetica,sans-serif">
<div dir="ltr"><div class="gmail_default" style="font-size: 10pt">Hi All,</div><div class="gmail_default" style="font-size: 10pt"><br></div><div class="gmail_default" style="font-size: 10pt"> I've just run into what I think is a bad mistake. My understanding of Symbol class>>findInterned: is that it answers a Symbol if its (string) argument already exists as a Symbol, and answers nil otherwise. Indeed looking at Collections-mt.935, 13 April 2021, this is the case:</div><div class="gmail_default" style="font-size: 10pt"><br></div><div class="gmail_default" style="font-size: 10pt">Symbol class>><b>findInterned:</b>aString<br><br> self hasInterned:aString ifTrue:[:symbol| ^symbol].<br> ^nil.<br></div><div class="gmail_default" style="font-size: 10pt"><br></div><div class="gmail_default" style="font-size: 10pt">In Collections-nice.936,13 April 2021 it was deprecated, but the new method in 60Deprecated-nice.95, 13 April 2021 reads:</div><br>Symbol class>><b>findInterned:</b>aString<br> <span class="gmail_default" style="font-size: 10pt"> </span>self flag: #deprecated. "use lookup: instead, they are synonym"<br> <span class="gmail_default" style="font-size: 10pt"> </span>^self lookup: aString<div><br></div><div><div class="gmail_default" style="font-size: 10pt">But lookup: *always* interns:</div><div class="gmail_default" style="font-size: 10pt"><br></div><div class="gmail_default" style="font-size: 10pt">Symbol intern: 'union {<br> sqIntptr_t valword;<br> struct { int low, high; } valleint64;<br> struct { int high, low; } valbeint64;<br> double valflt64;<br> struct { void *addr; sqIntptr_t size; } valstruct;<br> }' #'union {<br> sqIntptr_t valword;<br> struct { int low, high; } valleint64;<br> struct { int high, low; } valbeint64;<br> double valflt64;<br> struct { void *addr; sqIntptr_t size; } valstruct;<br> }' <br></div><div class="gmail_default" style="font-size: 10pt"><br></div><div class="gmail_default" style="font-size: 10pt">So I think it is *urgent* that we undeprecate findInterne3d: and restore its old meaning. I apologixze for not finding this earlier. i just ran VMMaker today after an update and that triggered the bug for the first time. I'm guessing the update flushed symbols.</div><div class="gmail_default" style="font-size: 10pt"><br></div><div class="gmail_default" style="font-size: 10pt">I'm going to make this change now.</div><br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><span style="font-size: 10pt;border-collapse: separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div></div></div>
</div></blockquote></div>