<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Of course; this was a typo. :-)</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Donnerstag, 16. Juni 2022 10:18:51<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Trunk: System-eem.1361.mcz</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
What's wrong with #allCallsOn:? Isn't the problem #allCallsOn:from:?
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 16.06.2022 09:41:51 schrieb christoph.thiede@student.hpi.uni-potsdam.de <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">Yahoo, finally! :-)<br>
<br>
Should we create an issue for broken #allCallsOn: or is this unfixable?<br>
<br>
Best,<br>
Christoph<br>
<br>
<span style="color: #808080">---<br>
</span><span style="color: #808080"><i>Sent from </i></span><span style="color: #808080"><i><a href="https://github.com/hpi-swa-lab/squeak-inbox-talk"><u><font color="#808080">Squeak Inbox Talk</font></u></a></i></span><br>
<br>
On 2022-06-15T09:00:10+02:00, marcel.taeumel@hpi.de wrote:<br>
<br>
> Thanks! This one has been bothering me for quite some time.<br>
> <br>
> Best,<br>
> Marcel<br>
> Am 14.06.2022 20:59:46 schrieb commits at source.squeak.org <commits at source.squeak.org>:<br>
> Eliot Miranda uploaded a new version of System to project The Trunk:<br>
> http://source.squeak.org/trunk/System-eem.1361.mcz<br>
> <br>
> ==================== Summary ====================<br>
> <br>
> Name: System-eem.1361<br>
> Author: eem<br>
> Time: 14 June 2022, 11:59:30.191277 am<br>
> UUID: 0269091d-007e-4db6-a77d-c459b689b7d1<br>
> Ancestors: System-dtl.1360<br>
> <br>
> Scope vareiable references (especially class variable references and property variable accesses (Tweak et al)) to the defining class, rather thna the whole system. Since allCallsOn:from: is broken, use allCallsOn:localTo: in browseAllCallsOn:localTo:<br>
> <br>
> [e.g. the first two are ok; the last is broken.<br>
> self systemNavigation allCallsOn: (EventSensor bindingOf: #EventPollPeriod) an OrderedCollection(a MethodReference EventSensor class >> #eventPollPeriod a MethodReference EventSensor class >> #eventPollPeriod:)<br>
> self systemNavigation allCallsOn: (EventSensor bindingOf: #EventPollPeriod) localTo: EventSensor an OrderedCollection(a MethodReference EventSensor class >> #eventPollPeriod a MethodReference EventSensor class >> #eventPollPeriod:)<br>
> self systemNavigation allCallsOn: (EventSensor bindingOf: #EventPollPeriod) from: EventSensor an OrderedCollection() ]<br>
> <br>
> =============== Diff against System-dtl.1360 ===============<br>
> <br>
> Item was changed:<br>
> ----- Method: SystemNavigation>>browseAllCallsOn:localTo: (in category 'browse') -----<br>
> browseAllCallsOn: aLiteral localTo: aBehavior<br>
> "Create and schedule a message browser on each method in or below the given class that refers to aLiteral."<br>
> "self default browseAllCallsOn: #open:label: localTo: CodeHolder"<br>
> <br>
> aBehavior ifNil: [ ^self inform: 'No behavior selected.' ].<br>
> ^ self headingAndAutoselectForLiteral: aLiteral do: [ :label :autoSelect |<br>
> self<br>
> + browseMessageList: [ self allCallsOn: aLiteral localTo: aBehavior ]<br>
> - browseMessageList: [ self allCallsOn: aLiteral from: aBehavior ]<br>
> name: label, ' local to ', aBehavior name<br>
> autoSelect: autoSelect ]!<br>
> <br>
> Item was changed:<br>
> ----- Method: SystemNavigation>>browseVariableReferences: (in category 'browse') -----<br>
> browseVariableReferences: aClass<br>
> aClass chooseVarThenDo:<br>
> + [:aVar |<br>
> + (aClass allInstVarNames includes: aVar)<br>
> - [ : aVar | (aClass allInstVarNames includes: aVar)<br>
> ifTrue:<br>
> + [self browseAllAccessesTo: aVar from: aClass]<br>
> + ifFalse:<br>
> + [((aClass classThatDefinesInstanceVariable: aVar) ifNil:<br>
> + [(aClass includesBehavior: SharedPool) ifFalse:<br>
> + [aClass classThatDefinesClassVariable: aVar]])<br>
> + ifNotNil:<br>
> + [:definingClass|<br>
> + self browseAllCallsOn: aVar localTo: definingClass]<br>
> + ifNil:<br>
> + [self browseAllCallsOn: aVar]]]!<br>
> - [ self<br>
> - browseAllAccessesTo: aVar<br>
> - from: aClass ]<br>
> - ifFalse: [ self browseAllCallsOn: aVar ] ]!<br>
> <br>
> <br>
> -------------- next part --------------<br>
> An HTML attachment was scrubbed...<br>
> URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220615/dc23e0cd/attachment.html><br>
> <br>
> </div>
</blockquote>
</div>
</div>
</body>
</html>