<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Christoph --<div class="mb_sig"></div>
<div><br></div><div>> <span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">IMO the current appearance of the preference</span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">> browser is not really acceptable for the release.</span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px"><br></span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">Please elaborate. :-) I like it. Just some extra window</span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">resizing needed, depending on what the user wants to</span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">browse.</span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px"><br></span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">Biggest issues are:</span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">- Still not ToolBuilder-based but a nice alternative</span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">- No input fields for float values</span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">- Preference list needs a grid layout but we have none</span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">- Input field would need minimum+preferred extent info but TableLayout does not support such layout strategies</span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px"><br></span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">It's still a compromise. I find it acceptable for the</span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">release. It looked worse in the prior releases.</span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px"><br></span></div><div><img id="f83497ea-3171-4080-bd53-31013def9a80" src="cid:975fef43-1f26-4fdb-8ca5-1d17013eda59" width="402" height="267"></img><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px"><br></span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px"><br></span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">Best,</span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">Marcel</span></div><blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 16.06.2022 12:08:59 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p><div style="font-family:Arial,Helvetica,sans-serif">
<div id="divtagdefaultwrapper" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif" dir="ltr">
<p>Hi Marcel,</p>
<p><br>
</p>
<p>this was only intended to be a quick-fix for the release, but you are right that solutions like this use to persist longer than we would love to. IMO the current appearance of the preference browser is not really acceptable for the release. <span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;font-size: 16px">Yes,
we could also only increase the #initialExtent, but this simply requires even more screen space and I considered the original preference name a little bit too verbose anyway (do we even have an official definition of "tool windows vs windows"?).</span></p>
<p><br>
</p>
<p>Any ideas for a more elegant but cheap solution would be welcome.</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Donnerstag, 16. Juni 2022 11:53:05<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] Review Request: fix-preference-browser-overflow.1.cs</span>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Christoph --
<div><br>
</div>
<div>I don't like the reason you provide for changing the title of that preference. This kind of change is not maintainable in the long term. So, you drop the information "tool" for some highly fragile UI optimization. This is not okay. Next time somebody increases
the width of that input field for #String, your change becomes void again.</div>
<div><br>
</div>
<div>Also, you even increased the #initialExtent. So you made two very different changes to tackle the same problem. Why not just increase the #initialExtent only to support this very configuration of preferences we have at the moment? This is not maintainable.</div>
<div><br>
</div>
<div>Your choice but this is a clear -1 from my side.</div>
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 16.06.2022 11:34:12 schrieb christoph.thiede@student.hpi.uni-potsdam.de <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif"><b>=============== Summary ===============</b><br>
<br>
Change Set: fix-preference-browser-overflow<br>
Date: 16 June 2022<br>
Author: Christoph Thiede<br>
<br>
Fixes default width of preference browser. The new preference 'RealEstateAgent windowScaleFactor' had such a long name that it did not fit into the standard width. Shorten the name and extend the initial window extent so that selecting the preference does no
longer offsets all items in the list.<br>
<br>
Note that this is only a quick-fix and might fail again once you change your screen size or fonts. In the long term, it would be nicer if we had something like StringMorph >> #maxWidth: for this (maybe even with an automatic ellipsis ...).<br>
<br>
<b>=============== Diff ===============</b><br>
<br>
<b>PreferenceBrowser>>initialExtent {user interface} · ct 6/16/2022 11:24 (changed)</b><br>
initialExtent<br>
"Scale here because the receiver is not built through a tool builder. See #buildPluggableWindow:."<br>
<br>
<s><span style="color: #0000FF">- ^ (660@440 * RealEstateAgent scaleFactor) rounded<br>
</span></s><span style="color: #FF0000">+ ^ (705 @ 440 * RealEstateAgent scaleFactor) rounded</span><br>
<br>
<b>RealEstateAgent class>>windowScaleFactor {preferences} · ct 6/16/2022 11:23 (changed)</b><br>
<s><span style="color: #0000FF">- windowScaleFactor<br>
- <preference: 'Scale Factor for Default Extent of Tool Windows'<br>
</span></s><span style="color: #FF0000">+ windowScaleFactor <br>
+ <preference: 'Scale Factor for Default Window Extent'<br>
</span> categoryList: #(Morphic Tools Accessibility)<br>
<s><span style="color: #0000FF">- description: 'The extent of tool windows is tweaked for a world extent of 1024@768 (or its scaled equivalent). If you have a larger screen available, you might want to increase a tool''s default extent. Note that you
can also increase the system''s overall scale factor instead.'<br>
</span></s><span style="color: #FF0000">+ description: 'The extent of windows is tweaked for a world extent of 1024@768 (or its scaled equivalent). If you have a larger screen available, you might want to increase a tool''s default extent. Note that
you can also increase the system''s overall scale factor instead.'<br>
</span> type: #String><br>
^ WindowScaleFactor ifNil: [1.0]<br>
<br>
["fix-preference-browser-overflow.1.cs"]<br>
<br>
<span style="color: #808080">---<br>
</span><span style="color: #808080"><i>Sent from </i></span><span style="color: #808080"><i><a href="https://github.com/hpi-swa-lab/squeak-inbox-talk"><u><span style="color: #808080">Squeak Inbox Talk</span></u></a></i></span>
</div>
</blockquote>
</div>
</div>
</div></blockquote></div>