<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Jaromir --<div><br></div><div>> <span style="font-family: Calibri, sans-serif;font-size: 14.6667px">I just thought cancelling the dialogue while NOT saving method</span></div><div><span style="font-family: Calibri, sans-serif;font-size: 14.6667px">> changes would achieve the same result, i.e. no unauthored method</span></div><div><span style="font-family: Calibri, sans-serif;font-size: 14.6667px">> changes.</span></div><div><span style="font-family: Calibri, sans-serif;font-size: 14.6667px"><br></span></div><div><span style="font-family: Calibri, sans-serif"><span style="font-size: 14.6667px">Hmm... that would entail an inadvertent/hidden "CMD+Dot", right? Well, the</span></span></div><div><span style="font-family: Calibri, sans-serif"><span style="font-size: 14.6667px">user should be informed of such things. And we cannot know how deep</span></span></div><div><span style="font-family: Calibri, sans-serif"><span style="font-size: 14.6667px">the control flow currently is...</span></span></div><div><span style="font-family: Calibri, sans-serif"><span style="font-size: 14.6667px"><br></span></span></div><div><span style="font-family: Calibri, sans-serif"><span style="font-size: 14.6667px">Christoph has ideas on how to improve user-input requests along with a proper</span></span></div><div><span style="font-family: Calibri, sans-serif"><span style="font-size: 14.6667px">design of Notifictions/Warnings. Maybe that would also cover this use case.</span></span></div><div><span style="font-family: Calibri, sans-serif"><span style="font-size: 14.6667px"><br></span></span></div><div><span style="font-family: Calibri, sans-serif"><span style="font-size: 14.6667px">Best,</span></span></div><div><span style="font-family: Calibri, sans-serif"><span style="font-size: 14.6667px">Marcel</span></span></div><div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 20.06.2022 10:33:21 schrieb Jaromir Matas <mail@jaromir.net>:</p><div style="font-family:Arial,Helvetica,sans-serif">
<div class="WordSection1">
<p class="MsoNormal">Hi Marcel,</p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks for your explanation.</p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">> <span style="color:black">One possible change -- that needs to be discussed after the release -- would be to answer something like "unknown" if the user cancels the dialog.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:black">My opinion: I like the way it is that you MUST enter some initials otherwise the changes won’t be saved. I just thought cancelling the dialogue while NOT saving method changes would achieve the same result, i.e.
no unauthored method changes.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:black">Anyway; thanks again, shall I close the github issue?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black">Best,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black">jaromir<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNoSpacing"><span lang="CS">--</span></p>
<p class="MsoNoSpacing"><strong><span style="font-family:"Calibri Light",sans-serif;color:#333333;font-weight:normal">Jaromír Matas</span></strong><span style="font-family:"Calibri Light",sans-serif;color:#555555"><o:p></o:p></span></p>
<p class="MsoNoSpacing"><span style="font-family:"Calibri Light",sans-serif;color:#2E75B6">mail@jaromir.net</span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="mso-element:para-border-div;border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="border:none;padding:0in"><b>From: </b><a href="mailto:marcel.taeumel@hpi.de">Marcel Taeumel</a><br>
<b>Sent: </b>Monday, June 20, 2022 10:14<br>
<b>To: </b><a href="mailto:squeak-dev@lists.squeakfoundation.org">squeak-dev</a><br>
<b>Subject: </b>Re: [squeak-dev] #setAuthorInitials inconsistent behavior</p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black">Hi Jaromir --<o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black">> </span><span style="color:black">Is this intentional?</span><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="color:black">Yes. The manual way to set author initials can easily be canceled. However, there are some places that rely on some initials to be set. So, calling #authorInitials will loop until until the user enters something. If
you want to cancel those situations, you have to do, for example, CMD+Dot because you would also cancel any control flow that needs those credentials.</span><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="color:black">One possible change -- that needs to be discussed after the release -- would be to answer something like "unknown" if the user cancels the dialog. Yet, I would argue that that dialog MUST pop up again during the
next request for #authorInitials.</span><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="color:black">Best,</span><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="color:black">Marcel</span><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"><o:p></o:p></span></p>
</div>
<blockquote style="border: none;border-left: solid windowtext 1.0pt;padding: 0in 0in 0in 8.0pt;margin-left: 0in;margin-top: 15.0pt;margin-bottom: 5.0pt;min-width: 500px">
<p style="margin-top:7.5pt"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: #AAAAAA">Am 18.06.2022 15:17:35 schrieb Jaromir Matas <mail@jaromir.net>:<o:p></o:p></span></p>
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black">Hi all,<o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"> <o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black">Two scenarios in a fresh image without author initials previously set:<o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"> <o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black">A) invoke Extras -> Set author initials dialogue<o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"> -> Now hit cancel and the dialogue disappears<o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"> <o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black">B) make a change in a method and try to save -> Save author initials dialogue appears<o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"> -> Now hit cancel and the dialogue reappears and it's impossible to get rid of it...<o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"> ... unless you chose `debug invocation` from the dialogue window menu and close the debugger<o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"> <o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black">Is this intentional? I'd expect the dialogue to disappear and method changes remain unsaved. Opened an
issue on github.<o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"> <o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black">Best,<o:p></o:p></span></p>
<p class="MsoNoSpacing"><span lang="CS" style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black">--</span><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"><o:p></o:p></span></p>
<p class="MsoNoSpacing"><strong><span style="font-size: 10.0pt;font-family: "Calibri Light",sans-serif;color: #333333;font-weight: normal">Jaromír Matas</span></strong><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"><o:p></o:p></span></p>
<p class="MsoNoSpacing"><span style="font-size: 10.0pt;font-family: "Calibri Light",sans-serif;color: #2E75B6">mail@jaromir.net</span><span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"><o:p></o:p></span></p>
</div>
</div>
</blockquote>
<p class="MsoNormal" style="mso-margin-top-alt:auto;margin-right:.5in;mso-margin-bottom-alt:auto">
<span style="font-size: 10.0pt;font-family: "Arial",sans-serif;color: black"> <o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div></blockquote></div>