<body><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
+1<div class="mb_sig"></div><blockquote class='history_container' type='cite' style='border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;'>
<p style='color: #AAAAAA; margin-top: 10px;'>Am 23.07.2022 17:05:08 schrieb commits@source.squeak.org <commits@source.squeak.org>:</p><div style='font-family:Arial,Helvetica,sans-serif'>A new version of Kernel was added to project The Inbox:<br>http://source.squeak.org/inbox/Kernel-ct.1487.mcz<br><br>==================== Summary ====================<br><br>Name: Kernel-ct.1487<br>Author: ct<br>Time: 23 July 2022, 5:04:54.100611 pm<br>UUID: 7b5df1b4-09a6-cd43-a466-9984c0bf96fb<br>Ancestors: Kernel-eem.1486<br><br>Fixes a bug in simulation of primitive 188. The nested #doPrimitive:... send must be passed the methodArg that was passed along with primitive 188, not the the original method that has called the primitive. This seems to be a regression from Kernel-eem.1205.<br><br>=============== Diff against Kernel-eem.1486 ===============<br><br>Item was changed:<br> ----- Method: Context>>doPrimitive:method:receiver:args: (in category 'private') -----<br> doPrimitive: primitiveIndex method: meth receiver: receiver args: arguments<br> "Simulate a primitive method whose index is primitiveIndex. The simulated receiver and<br> arguments are given as arguments to this message. If successful, push result and return<br> resuming context, else ^ {errCode, PrimitiveFailToken}. Any primitive which provokes<br> execution needs to be intercepted and simulated to avoid execution running away."<br> <br> | value |<br> "Judicious use of primitive 19 (a null primitive that doesn't do anything) prevents<br> the debugger from entering various run-away activities such as spawning a new<br> process, etc. Injudicious use results in the debugger not being able to debug<br> interesting code, such as the debugger itself. Hence use primitive 19 with care :-)"<br> "SystemNavigation new browseAllSelect: [:m| m primitive = 19]"<br> primitiveIndex = 19 ifTrue: [<br> [self notify: ('The code being simulated is trying to control a process ({1}). Process controlling cannot be simulated. If you proceed, things may happen outside the observable area of the simulator.' translated format: {meth reference})]<br> ifCurtailed: [self push: nil "Cheap fix of the context's internal state"]].<br> <br> ((primitiveIndex between: 201 and: 222)<br> and: [(self objectClass: receiver) includesBehavior: BlockClosure]) ifTrue:<br> [(primitiveIndex = 206<br> or: [primitiveIndex = 208]) ifTrue: "[Full]BlockClosure>>valueWithArguments:"<br> [^receiver simulateValueWithArguments: arguments first caller: self].<br> ((primitiveIndex between: 201 and: 209) "[Full]BlockClosure>>value[:value:...]"<br> or: [primitiveIndex between: 221 and: 222]) ifTrue: "[Full]BlockClosure>>valueNoContextSwitch[:]"<br> [^receiver simulateValueWithArguments: arguments caller: self]].<br> <br> primitiveIndex = 83 ifTrue: "afr 9/11/1998 19:50" "Object>>perform:[with:...]"<br> [| selector |<br> selector := arguments at: 1 ifAbsent:<br> [^ self class primitiveFailTokenFor: #'bad argument'].<br> arguments size - 1 = selector numArgs ifFalse:<br> [^ self class primitiveFailTokenFor: #'bad number of arguments'].<br> ^self send: selector to: receiver with: arguments allButFirst].<br> primitiveIndex = 84 ifTrue: "afr 9/11/1998 19:50 & eem 8/18/2009 17:04" "Object>>perform:withArguments:"<br> [| selector args |<br> arguments size = 2 ifFalse:<br> [^ self class primitiveFailTokenFor: #'bad argument'].<br> selector := arguments first.<br> args := arguments second.<br> args isArray ifFalse:<br> [^ self class primitiveFailTokenFor: #'bad argument'].<br> args size = selector numArgs ifFalse:<br> [^ self class primitiveFailTokenFor: #'bad number of arguments'].<br> ^self send: selector to: receiver with: args].<br> primitiveIndex = 100 ifTrue: "eem 8/18/2009 16:57" "Object>>perform:withArguments:inSuperclass:"<br> [| rcvr selector args superclass |<br> arguments size<br> caseOf: {<br> [3] -> [<br> rcvr := receiver.<br> selector := arguments first.<br> args := arguments second.<br> superclass := arguments third].<br> [4] -> ["mirror primitive"<br> rcvr := arguments first.<br> selector := arguments second.<br> args := arguments third.<br> superclass := arguments fourth] }<br> otherwise: [^ self class primitiveFailTokenFor: #'bad number of arguments'].<br> args isArray ifFalse:<br> [^ self class primitiveFailTokenFor: #'bad argument'].<br> args size = selector numArgs ifFalse:<br> [^ self class primitiveFailTokenFor: #'bad number of arguments'].<br> ((self objectClass: rcvr) includesBehavior: superclass) ifFalse:<br> [^ self class primitiveFailTokenFor: #'bad argument'].<br> ^self send: selector to: rcvr with: args lookupIn: superclass].<br> <br> "Mutex>>primitiveEnterCriticalSection<br> Mutex>>primitiveTestAndSetOwnershipOfCriticalSection"<br> (primitiveIndex = 186 or: [primitiveIndex = 187]) ifTrue:<br> [| effective |<br> effective := Processor activeProcess effectiveProcess.<br> "active == effective"<br> value := primitiveIndex = 186<br> ifTrue: [receiver primitiveEnterCriticalSectionOnBehalfOf: effective]<br> ifFalse: [receiver primitiveTestAndSetOwnershipOfCriticalSectionOnBehalfOf: effective].<br> ^(self isPrimFailToken: value)<br> ifTrue: [value]<br> ifFalse: [self push: value]].<br> <br> primitiveIndex = 188 ifTrue: "Object>>withArgs:executeMethod:<br> CompiledMethod class>>receiver:withArguments:executeMethod:<br> VMMirror>>ifFail:object:with:executeMethod: et al"<br> [| n args methodArg thisReceiver |<br> ((n := arguments size) between: 2 and: 4) ifFalse:<br> [^self class primitiveFailTokenFor: #'unsupported operation'].<br> ((self objectClass: (args := arguments at: n - 1)) == Array<br> and: [(self objectClass: (methodArg := arguments at: n)) includesBehavior: CompiledMethod]) ifFalse:<br> [^self class primitiveFailTokenFor: #'bad argument'].<br> methodArg numArgs = args size ifFalse:<br> [^self class primitiveFailTokenFor: #'bad number of arguments'].<br> thisReceiver := arguments at: n - 2 ifAbsent: [receiver].<br> methodArg primitive > 0 ifTrue:<br> [methodArg isQuick ifTrue:<br> [^self push: (methodArg valueWithReceiver: thisReceiver arguments: args)].<br>+ ^self doPrimitive: methodArg primitive method: methodArg receiver: thisReceiver args: args].<br>- ^self doPrimitive: methodArg primitive method: meth receiver: thisReceiver args: args].<br> ^self<br> activateMethod: methodArg<br> withArgs: args<br> receiver: thisReceiver].<br> <br> primitiveIndex = 118 ifTrue: "[receiver:]tryPrimitive:withArgs:; avoid recursing in the VM"<br> [(arguments size = 3<br> and: [(self objectClass: arguments second) == SmallInteger<br> and: [(self objectClass: arguments last) == Array]]) ifTrue:<br> [^self doPrimitive: arguments second method: meth receiver: arguments first args: arguments last].<br> (arguments size = 2<br> and: [(self objectClass: arguments first) == SmallInteger<br> and: [(self objectClass: arguments last) == Array]]) ifFalse:<br> [^self class primitiveFailTokenFor: nil].<br> ^self doPrimitive: arguments first method: meth receiver: receiver args: arguments last].<br> <br> value := primitiveIndex = 120 "FFI method"<br> ifTrue: [(meth literalAt: 1) tryInvokeWithArguments: arguments]<br> ifFalse:<br> [primitiveIndex = 117 "named primitives"<br> ifTrue: [self tryNamedPrimitiveIn: meth for: receiver withArgs: arguments]<br> ifFalse: "should use self receiver: receiver tryPrimitive: primitiveIndex withArgs: arguments but this is only in later VMs (and appears to be broken)"<br> [receiver tryPrimitive: primitiveIndex withArgs: arguments]].<br> <br> ^(self isPrimFailToken: value)<br> ifTrue: [value]<br> ifFalse: [self push: value]!<br><br><br></div></blockquote>
</div></body>